| Message ID | 20200306152520.28233-1-james.clark@arm.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | perf tools: Add support for some spe events | expand |
On Fri, Mar 06, 2020 at 03:25:17PM +0000, James Clark wrote: > Hi Mark, > > Yes I think this is something I can look into. For now I have removed > that last patch because the current patch set already works very similarly anyway > and allows people to use SPE in perf: > > ./perf record -e arm_spe_0/branch_filter=1/ > vs > ./perf record -e arm_spe/branch-misses/pp Thanks, FWIW that looks fine to me. > Also I don't have access to any big.LITTLE hardware with SPE so wouldn't be able > to test collating all the SPE PMUs. Likewise, I just want to make sure we don't back ourselves into a corner. Otherwise, I have no comments on these patches, so feel free to take that as: Acked-by: Mark Rutland <mark.rutland@arm.com> Mark. > > Thanks > James > > Tan Xiaojun (3): > perf tools: Move arm-spe-pkt-decoder.h/c to the new dir > perf tools: Add support for "report" for some spe events > perf report: Add SPE options to --itrace argument > > tools/perf/Documentation/itrace.txt | 5 +- > tools/perf/util/Build | 2 +- > tools/perf/util/arm-spe-decoder/Build | 1 + > .../util/arm-spe-decoder/arm-spe-decoder.c | 225 ++++++ > .../util/arm-spe-decoder/arm-spe-decoder.h | 66 ++ > .../arm-spe-pkt-decoder.c | 0 > .../arm-spe-pkt-decoder.h | 2 + > tools/perf/util/arm-spe.c | 747 +++++++++++++++++- > tools/perf/util/auxtrace.c | 13 + > tools/perf/util/auxtrace.h | 13 +- > 10 files changed, 1032 insertions(+), 42 deletions(-) > create mode 100644 tools/perf/util/arm-spe-decoder/Build > create mode 100644 tools/perf/util/arm-spe-decoder/arm-spe-decoder.c > create mode 100644 tools/perf/util/arm-spe-decoder/arm-spe-decoder.h > rename tools/perf/util/{ => arm-spe-decoder}/arm-spe-pkt-decoder.c (100%) > rename tools/perf/util/{ => arm-spe-decoder}/arm-spe-pkt-decoder.h (96%) > > -- > 2.17.1 >
Hi Mark, Yes I think this is something I can look into. For now I have removed that last patch because the current patch set already works very similarly anyway and allows people to use SPE in perf: ./perf record -e arm_spe_0/branch_filter=1/ vs ./perf record -e arm_spe/branch-misses/pp Also I don't have access to any big.LITTLE hardware with SPE so wouldn't be able to test collating all the SPE PMUs. Thanks James Tan Xiaojun (3): perf tools: Move arm-spe-pkt-decoder.h/c to the new dir perf tools: Add support for "report" for some spe events perf report: Add SPE options to --itrace argument tools/perf/Documentation/itrace.txt | 5 +- tools/perf/util/Build | 2 +- tools/perf/util/arm-spe-decoder/Build | 1 + .../util/arm-spe-decoder/arm-spe-decoder.c | 225 ++++++ .../util/arm-spe-decoder/arm-spe-decoder.h | 66 ++ .../arm-spe-pkt-decoder.c | 0 .../arm-spe-pkt-decoder.h | 2 + tools/perf/util/arm-spe.c | 747 +++++++++++++++++- tools/perf/util/auxtrace.c | 13 + tools/perf/util/auxtrace.h | 13 +- 10 files changed, 1032 insertions(+), 42 deletions(-) create mode 100644 tools/perf/util/arm-spe-decoder/Build create mode 100644 tools/perf/util/arm-spe-decoder/arm-spe-decoder.c create mode 100644 tools/perf/util/arm-spe-decoder/arm-spe-decoder.h rename tools/perf/util/{ => arm-spe-decoder}/arm-spe-pkt-decoder.c (100%) rename tools/perf/util/{ => arm-spe-decoder}/arm-spe-pkt-decoder.h (96%)