From patchwork Tue Mar 10 18:49:17 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marc Zyngier X-Patchwork-Id: 11430139 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id E02E413A4 for ; Tue, 10 Mar 2020 18:49:44 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A6FD220873 for ; Tue, 10 Mar 2020 18:49:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="LtpM2HQh"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="e2UggPeF" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A6FD220873 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To :From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=XUwNEhULOA/qLsZdgNkVIPdB5FvZJIBIy0NHgQ2igWg=; b=LtpM2HQh/bRdqm K+EvG0gavOQIHdxq0ItoPB22CoeXOUt0XpDreigbxtw8jPYpS4z0QMb2PjVAeTbxRvMAOEa4kZogP 8RCCiI67k4Bq/4Duz/0gtQQCFYJdJByUr58o3fohFd22pCMLGnAeFo1nKxtRBi2GIqlEnCkUlGkUR q+rn+ot2OhhGxTLaKkwQ9nB+Sp+A9LOzBeSaVbrrjZY1/zT3uuQQUw6CkEquHmPsu6Q8saQt3wiJW eUaBDTDFEdInCDcjP3wuMdAFVBkIPjmwsyZ1dg116ATOboD/2UppyCQiVjWW33Hj15fcWNmxt5Olj yqpVmZTXcmqwPVtOYxnw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jBjwi-00085v-Bv; Tue, 10 Mar 2020 18:49:40 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jBjwZ-0007w0-W5 for linux-arm-kernel@lists.infradead.org; Tue, 10 Mar 2020 18:49:33 +0000 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5F18C208C3; Tue, 10 Mar 2020 18:49:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1583866169; bh=Z+esqeekOvcK2NlG82c5Na805Zd2SVU9aa9FMtHbcgI=; h=From:To:Cc:Subject:Date:From; b=e2UggPeF8iA59akyJ483DNpcLE+EGJD1P244SZYW9oLCBJ7O2l2FGNT1KnYCOMYCi rP12B1uIXWZj22kFXhhzqtz6KvszfbarvaZoxP3xNrdr8vcMlseCBC27SyRgel3sbe z6pkEo+rEIArhs2H0UuUmMmuuvO2qNFu9IE+WAsQ= Received: from 78.163-31-62.static.virginmediabusiness.co.uk ([62.31.163.78] helo=why.lan) by disco-boy.misterjones.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jBjwV-00Bi6k-Lr; Tue, 10 Mar 2020 18:49:27 +0000 From: Marc Zyngier To: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH 0/4] irqchip: Random irq_retrigger fixes Date: Tue, 10 Mar 2020 18:49:17 +0000 Message-Id: <20200310184921.23552-1-maz@kernel.org> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 X-SA-Exim-Connect-IP: 62.31.163.78 X-SA-Exim-Rcpt-To: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, tglx@linutronix.de, jason@lakedaemon.net, linux@arm.linux.org.uk, nicolas.ferre@microchip.com, alexandre.belloni@bootlin.com, ludovic.desroches@microchip.com, yuzenghui@huawei.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200310_114932_089005_563E68E1 X-CRM114-Status: UNSURE ( 9.36 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -5.2 (-----) X-Spam-Report: SpamAssassin version 3.4.3 on bombadil.infradead.org summary: Content analysis details: (-5.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -5.0 RCVD_IN_DNSWL_HI RBL: Sender listed at https://www.dnswl.org/, high trust [198.145.29.99 listed in list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.0 DKIMWL_WL_HIGH DKIMwl.org - Whitelisted High sender X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alexandre Belloni , Russell King , Jason Cooper , Ludovic Desroches , Zenghui Yu , Thomas Gleixner Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org As I was investigating some ugly retrigger locking issues (see patch 4), I managed to find three occurences of irq_retrigger callbacks that return the wrong value, leading to a SW retrigger on top of the HW one. Not really a big deal, but definitely worth fixing. Marc Zyngier (4): irqchip/atmel-aic: Fix irq_retrigger callback return value irqchip/atmel-aic5: Fix irq_retrigger callback return value ARM: sa1111: Fix irq_retrigger callback return value irqchip/gic-v4: Provide irq_retrigger to avoid circular locking dependency arch/arm/common/sa1111.c | 7 +++++-- drivers/irqchip/irq-atmel-aic.c | 2 +- drivers/irqchip/irq-atmel-aic5.c | 2 +- drivers/irqchip/irq-gic-v3-its.c | 6 ++++++ 4 files changed, 13 insertions(+), 4 deletions(-)