| Message ID | 20200520175539.28464-1-will@kernel.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | arm64 sigreturn unwinding fixes | expand |
Hi Will, Works okay, LGTM. Thanks for the patch. Cheers, Daniel > On 20 May 2020, at 19:55, Will Deacon <will@kernel.org> wrote: > > Hi folks, > > Here is v3 of my attempt at fixing the vdso sigreturn code for unwinders. > Previous versions are available here: > > v1: https://lore.kernel.org/r/20200519121818.14511-1-will@kernel.org > v2: https://lore.kernel.org/r/20200519162821.16857-1-will@kernel.org > > Changes since v2 include: > > * Fix the .cfi directives to identify the link register correctly > * Even more comments > > Daniel, please can you give this a spin with the LLVM unwinder? It should work > this time. > > Cheers, > > Will > > Cc: Dave Martin <dave.martin@arm.com> > Cc: Tamas Zsoldos <tamas.zsoldos@arm.com> > Cc: Daniel Kiss <daniel.kiss@arm.com> > Cc: Mark Brown <broonie@kernel.org> > Cc: <kernel-team@android.com> > > --->8 > > Will Deacon (2): > arm64: vdso: Don't prefix sigreturn trampoline with a BTI C > instruction > arm64: vdso: Fix CFI directives in sigreturn trampoline > > arch/arm64/include/asm/linkage.h | 6 ++-- > arch/arm64/kernel/vdso/sigreturn.S | 51 ++++++++++++++++++++++++---- > arch/arm64/kernel/vdso32/sigreturn.S | 19 ++++++----- > 3 files changed, 58 insertions(+), 18 deletions(-) > > -- > 2.26.2.761.g0e0b3e54be-goog >
Hi folks, Here is v3 of my attempt at fixing the vdso sigreturn code for unwinders. Previous versions are available here: v1: https://lore.kernel.org/r/20200519121818.14511-1-will@kernel.org v2: https://lore.kernel.org/r/20200519162821.16857-1-will@kernel.org Changes since v2 include: * Fix the .cfi directives to identify the link register correctly * Even more comments Daniel, please can you give this a spin with the LLVM unwinder? It should work this time. Cheers, Will Cc: Dave Martin <dave.martin@arm.com> Cc: Tamas Zsoldos <tamas.zsoldos@arm.com> Cc: Daniel Kiss <daniel.kiss@arm.com> Cc: Mark Brown <broonie@kernel.org> Cc: <kernel-team@android.com> --->8 Will Deacon (2): arm64: vdso: Don't prefix sigreturn trampoline with a BTI C instruction arm64: vdso: Fix CFI directives in sigreturn trampoline arch/arm64/include/asm/linkage.h | 6 ++-- arch/arm64/kernel/vdso/sigreturn.S | 51 ++++++++++++++++++++++++---- arch/arm64/kernel/vdso32/sigreturn.S | 19 ++++++----- 3 files changed, 58 insertions(+), 18 deletions(-)