mbox series

[RESEND,v3,0/6] soc: xilinx: vcu: provide interfaces for other drivers

Message ID 20200619075913.18900-1-m.tretter@pengutronix.de (mailing list archive)
Headers show
Series soc: xilinx: vcu: provide interfaces for other drivers | expand

Message

Michael Tretter June 19, 2020, 7:59 a.m. UTC
Hello,

I'm resending v3 of the series to expose interfaces that can be used by other
drivers from the xlnx_vcu driver, because unfortunately there wasn't any
feedback on the actual code changes in the series.

This driver controls the glue between the ZynqMP and the actual video codec
unit.  Therefore, a driver for the video codec unit (i.e. the allegro-dvt
driver) needs to be able to control the glue and read information about the
codec configuration from the glue. The interfaces to do so are exposed by this
patch series.

This resend contains Rob Herring's Acked-By and Reviewed-By for the device
tree changes.

Michael

Changelog:

v2 -> v3:
- drop unused xvcu_reset() function

v1 -> v2:
- drop custom select for syscon
- unregister registered clocks on driver remove

Michael Tretter (6):
  soc: xilinx: vcu: drop useless success message
  ARM: dts: define indexes for output clocks
  soc: xilinx: vcu: implement clock provider for output clocks
  dt-bindings: soc: xlnx: extract xlnx, vcu-settings to separate binding
  soc: xilinx: vcu: use vcu-settings syscon registers
  soc: xilinx: vcu: add missing register NUM_CORE

 .../soc/xilinx/xlnx,vcu-settings.yaml         |  34 ++++
 .../bindings/soc/xilinx/xlnx,vcu.txt          |   9 +-
 drivers/soc/xilinx/Kconfig                    |   3 +-
 drivers/soc/xilinx/xlnx_vcu.c                 | 158 ++++++++++++------
 include/dt-bindings/clock/xlnx-vcu.h          |  15 ++
 include/linux/mfd/syscon/xlnx-vcu.h           |  39 +++++
 6 files changed, 200 insertions(+), 58 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/soc/xilinx/xlnx,vcu-settings.yaml
 create mode 100644 include/dt-bindings/clock/xlnx-vcu.h
 create mode 100644 include/linux/mfd/syscon/xlnx-vcu.h

Comments

Michal Simek July 13, 2020, 7:55 a.m. UTC | #1
Hi,

On 19. 06. 20 9:59, Michael Tretter wrote:
> Hello,
> 
> I'm resending v3 of the series to expose interfaces that can be used by other
> drivers from the xlnx_vcu driver, because unfortunately there wasn't any
> feedback on the actual code changes in the series.
> 
> This driver controls the glue between the ZynqMP and the actual video codec
> unit.  Therefore, a driver for the video codec unit (i.e. the allegro-dvt
> driver) needs to be able to control the glue and read information about the
> codec configuration from the glue. The interfaces to do so are exposed by this
> patch series.
> 
> This resend contains Rob Herring's Acked-By and Reviewed-By for the device
> tree changes.
> 
> Michael
> 
> Changelog:
> 
> v2 -> v3:
> - drop unused xvcu_reset() function
> 
> v1 -> v2:
> - drop custom select for syscon
> - unregister registered clocks on driver remove
> 
> Michael Tretter (6):
>   soc: xilinx: vcu: drop useless success message
>   ARM: dts: define indexes for output clocks
>   soc: xilinx: vcu: implement clock provider for output clocks
>   dt-bindings: soc: xlnx: extract xlnx, vcu-settings to separate binding
>   soc: xilinx: vcu: use vcu-settings syscon registers
>   soc: xilinx: vcu: add missing register NUM_CORE
> 
>  .../soc/xilinx/xlnx,vcu-settings.yaml         |  34 ++++
>  .../bindings/soc/xilinx/xlnx,vcu.txt          |   9 +-
>  drivers/soc/xilinx/Kconfig                    |   3 +-
>  drivers/soc/xilinx/xlnx_vcu.c                 | 158 ++++++++++++------
>  include/dt-bindings/clock/xlnx-vcu.h          |  15 ++
>  include/linux/mfd/syscon/xlnx-vcu.h           |  39 +++++
>  6 files changed, 200 insertions(+), 58 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/soc/xilinx/xlnx,vcu-settings.yaml
>  create mode 100644 include/dt-bindings/clock/xlnx-vcu.h
>  create mode 100644 include/linux/mfd/syscon/xlnx-vcu.h
> 

Rohit, Dhaval: Can you please comment it?

Thanks,
Michal
Rohit Visavalia July 15, 2020, 8:20 a.m. UTC | #2
+Rajan & Tejas

Can you please review the patch series? As it contains changes related to clock providers & mfd/syscon and you have already made similar changes for CCF and MFD in current Xilinx repos, so that both changes can be in sync for future upgrades.

Thanks
Rohit

> -----Original Message-----
> From: Michal Simek [mailto:michal.simek@xilinx.com]
> Sent: Monday, July 13, 2020 1:25 PM
> To: Michael Tretter <m.tretter@pengutronix.de>; linux-arm-
> kernel@lists.infradead.org
> Cc: Rohit Visavalia <RVISAVAL@xilinx.com>; Michal Simek
> <michals@xilinx.com>; Dhaval Rajeshbhai Shah <dshah@xilinx.com>; Greg
> Kroah-Hartman <gregkh@linuxfoundation.org>; kernel@pengutronix.de
> Subject: Re: [RESEND PATCH v3 0/6] soc: xilinx: vcu: provide interfaces for
> other drivers
> 
> Hi,
> 
> On 19. 06. 20 9:59, Michael Tretter wrote:
> > Hello,
> >
> > I'm resending v3 of the series to expose interfaces that can be used
> > by other drivers from the xlnx_vcu driver, because unfortunately there
> > wasn't any feedback on the actual code changes in the series.
> >
> > This driver controls the glue between the ZynqMP and the actual video
> > codec unit.  Therefore, a driver for the video codec unit (i.e. the
> > allegro-dvt
> > driver) needs to be able to control the glue and read information
> > about the codec configuration from the glue. The interfaces to do so
> > are exposed by this patch series.
> >
> > This resend contains Rob Herring's Acked-By and Reviewed-By for the
> > device tree changes.
> >
> > Michael
> >
> > Changelog:
> >
> > v2 -> v3:
> > - drop unused xvcu_reset() function
> >
> > v1 -> v2:
> > - drop custom select for syscon
> > - unregister registered clocks on driver remove
> >
> > Michael Tretter (6):
> >   soc: xilinx: vcu: drop useless success message
> >   ARM: dts: define indexes for output clocks
> >   soc: xilinx: vcu: implement clock provider for output clocks
> >   dt-bindings: soc: xlnx: extract xlnx, vcu-settings to separate binding
> >   soc: xilinx: vcu: use vcu-settings syscon registers
> >   soc: xilinx: vcu: add missing register NUM_CORE
> >
> >  .../soc/xilinx/xlnx,vcu-settings.yaml         |  34 ++++
> >  .../bindings/soc/xilinx/xlnx,vcu.txt          |   9 +-
> >  drivers/soc/xilinx/Kconfig                    |   3 +-
> >  drivers/soc/xilinx/xlnx_vcu.c                 | 158 ++++++++++++------
> >  include/dt-bindings/clock/xlnx-vcu.h          |  15 ++
> >  include/linux/mfd/syscon/xlnx-vcu.h           |  39 +++++
> >  6 files changed, 200 insertions(+), 58 deletions(-)  create mode
> > 100644
> > Documentation/devicetree/bindings/soc/xilinx/xlnx,vcu-settings.yaml
> >  create mode 100644 include/dt-bindings/clock/xlnx-vcu.h
> >  create mode 100644 include/linux/mfd/syscon/xlnx-vcu.h
> >
> 
> Rohit, Dhaval: Can you please comment it?
> 
> Thanks,
> Michal