[v1,0/5] imx6qp QuadPlus: support improved enet clocking

Message

Sven Van Asbroeck July 13, 2020, 12:25 a.m. UTC

On the imx6qp QuadPlus, the h/w designers have improved enet clocking.

This patchset extends the clock tree to reflect the situation on QuadPlus.

This allows board designers to choose the enet clocking method by making
simple clocktree changes in the devicetree.

Default setting: external routing of enet_ref from pad to pad.

Example, change the default to enet_ref @ 125MHz clock routed internally:

&fec {
	assigned-clocks = <&clks IMX6QDL_CLK_ENET_PTP>,
			  <&clks IMX6QDL_CLK_ENET_REF>;
	assigned-clock-parents = <&clks IMX6QDL_CLK_ENET_REF>;
	assigned-clock-rates = <0>, <125000000>;
};

To: Shawn Guo <[e-mail]>
To: Sascha Hauer <[e-mail]>
Cc: Pengutronix Kernel Team <[e-mail]>
Cc: Fabio Estevam <[e-mail]>
Cc: NXP Linux Team <[e-mail]>
Cc: [e-mail]
Cc: [e-mail]
Cc: [e-mail]

Sven Van Asbroeck (5):
  ARM: mach-imx6q: do not select enet PTP clock source on QuadPlus
  clk: imx: add simple regmap-backed clock mux
  dt-bindings: imx6qdl-clock: add QuadPlus enet clocks
  clk: imx6q: support improved enet clocking on QuadPlus
  ARM: dts: imx6qp: support improved enet clocking on QuadPlus

 .../bindings/clock/imx6q-clock.yaml           |   2 +
 arch/arm/boot/dts/imx6qp.dtsi                 |   3 +
 arch/arm/mach-imx/mach-imx6q.c                |   4 +
 drivers/clk/imx/Makefile                      |   1 +
 drivers/clk/imx/clk-imx6q.c                   |  46 ++++++++
 drivers/clk/imx/clk-mux-regmap.c              | 110 ++++++++++++++++++
 drivers/clk/imx/clk.h                         |   7 ++
 include/dt-bindings/clock/imx6qdl-clock.h     |   5 +-
 include/linux/mfd/syscon/imx6q-iomuxc-gpr.h   |   1 +
 9 files changed, 178 insertions(+), 1 deletion(-)
 create mode 100644 drivers/clk/imx/clk-mux-regmap.c

Comments

Shawn Guo Aug. 17, 2020, 7:17 a.m. UTC | #1

On Sun, Jul 12, 2020 at 08:25:07PM -0400, Sven Van Asbroeck wrote:
> On the imx6qp QuadPlus, the h/w designers have improved enet clocking.
> 
> This patchset extends the clock tree to reflect the situation on QuadPlus.
> 
> This allows board designers to choose the enet clocking method by making
> simple clocktree changes in the devicetree.
> 
> Default setting: external routing of enet_ref from pad to pad.
> 
> Example, change the default to enet_ref @ 125MHz clock routed internally:
> 
> &fec {
> 	assigned-clocks = <&clks IMX6QDL_CLK_ENET_PTP>,
> 			  <&clks IMX6QDL_CLK_ENET_REF>;
> 	assigned-clock-parents = <&clks IMX6QDL_CLK_ENET_REF>;
> 	assigned-clock-rates = <0>, <125000000>;
> };
> 
> To: Shawn Guo <[e-mail]>
> To: Sascha Hauer <[e-mail]>
> Cc: Pengutronix Kernel Team <[e-mail]>
> Cc: Fabio Estevam <[e-mail]>
> Cc: NXP Linux Team <[e-mail]>
> Cc: [e-mail]
> Cc: [e-mail]
> Cc: [e-mail]
> 
> Sven Van Asbroeck (5):
>   ARM: mach-imx6q: do not select enet PTP clock source on QuadPlus
>   clk: imx: add simple regmap-backed clock mux
>   dt-bindings: imx6qdl-clock: add QuadPlus enet clocks
>   clk: imx6q: support improved enet clocking on QuadPlus
>   ARM: dts: imx6qp: support improved enet clocking on QuadPlus

Hi Fugang,

Can you take a look at the series?

Shawn

Andy Duan Aug. 17, 2020, 7:26 a.m. UTC | #2

From: Shawn Guo <[e-mail]> Sent: Monday, August 17, 2020 3:17 PM
> On Sun, Jul 12, 2020 at 08:25:07PM -0400, Sven Van Asbroeck wrote:
> > On the imx6qp QuadPlus, the h/w designers have improved enet clocking.
> >
> > This patchset extends the clock tree to reflect the situation on QuadPlus.
> >
> > This allows board designers to choose the enet clocking method by
> > making simple clocktree changes in the devicetree.
> >
> > Default setting: external routing of enet_ref from pad to pad.
> >
> > Example, change the default to enet_ref @ 125MHz clock routed internally:
> >
> > &fec {
> >       assigned-clocks = <&clks IMX6QDL_CLK_ENET_PTP>,
> >                         <&clks IMX6QDL_CLK_ENET_REF>;
> >       assigned-clock-parents = <&clks IMX6QDL_CLK_ENET_REF>;
> >       assigned-clock-rates = <0>, <125000000>; };
> >
> > To: Shawn Guo <[e-mail]>
> > To: Sascha Hauer <[e-mail]>
> > Cc: Pengutronix Kernel Team <[e-mail]>
> > Cc: Fabio Estevam <[e-mail]>
> > Cc: NXP Linux Team <[e-mail]>
> > Cc: [e-mail]
> > Cc: [e-mail]
> > Cc: [e-mail]
> >
> > Sven Van Asbroeck (5):
> >   ARM: mach-imx6q: do not select enet PTP clock source on QuadPlus
> >   clk: imx: add simple regmap-backed clock mux
> >   dt-bindings: imx6qdl-clock: add QuadPlus enet clocks
> >   clk: imx6q: support improved enet clocking on QuadPlus
> >   ARM: dts: imx6qp: support improved enet clocking on QuadPlus
> 
> Hi Fugang,
> 
> Can you take a look at the series?
> 
> Shawn

In fact, Sven already sent the patch list to me in private for review
due to miss cc to me. We discussed the series for long time and suppose
Sven will send v2 patch set.

Regards,
Fugang