[v7,0/2] phy: bcm63xx-usbh: Add BCM63xx USBH driver

Message

Álvaro Fernández Rojas July 17, 2020, 9:47 a.m. UTC

Add BCM63xx USBH PHY driver for BMIPS.

v7: remove Simon from authors and introduce changes suggested by Rob:
  - Move clock conditions to the main section.
  - Set missing additionalProperties to false.
v6: introduce changes suggested by Rob and Vinod:
 - Remove BMIPS_GENERIC default from kconfig.
 - Print registered message as debug.
 - Add another if case to device tree binding for SoCs with just 1 clock.
 - Ignored "additionalProperties: false" suggestion since it triggers a
  warning. This has been reported, but I haven't received any answer yet.
v5: use devm_reset_control_get_exclusive.
v4: fix dt-bindings documentation and improve device mode config.
v3: introduce changes suggested by Florian:
 - Add support for device mode.
v2: introduce changes suggested by Florian:
 - phy-cells changed to 1.
 - Drop OF dependency (use device_get_match_data).
 - Drop __initconst from variant tables.
 - Use devm_clk_get_optional.

Álvaro Fernández Rojas (2):
  dt-bindings: phy: add bcm63xx-usbh bindings
  phy: bcm63xx-usbh: Add BCM63xx USBH driver

 .../bindings/phy/brcm,bcm63xx-usbh-phy.yaml   |  79 +++
 drivers/phy/broadcom/Kconfig                  |   8 +
 drivers/phy/broadcom/Makefile                 |   1 +
 drivers/phy/broadcom/phy-bcm63xx-usbh.c       | 456 ++++++++++++++++++
 4 files changed, 544 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/phy/brcm,bcm63xx-usbh-phy.yaml
 create mode 100644 drivers/phy/broadcom/phy-bcm63xx-usbh.c

Comments

Simon Arlott July 17, 2020, 10:35 a.m. UTC | #1

On 2020-07-17 10:47, Álvaro Fernández Rojas wrote:
> Add BCM63xx USBH PHY driver for BMIPS.
> 
> v7: remove Simon from authors and introduce changes suggested by Rob:

I asked you to remove my email address from the source code. All you've
done is update it. I don't want spam. I know the address appears in the
commit but you don't have to spray it around everywhere else.

You can keep my name in the MODULE_AUTHOR text but you need to omit the
email address.

None of the original copyright notices included email addresses so I
don't know why you think it is appropriate for you to add them.

Please only Cc: this email address, I don't want multiple copies of
everything.