From patchwork Fri Jul 24 14:34:59 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Will Deacon X-Patchwork-Id: 11683437 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 92B2D138A for ; Fri, 24 Jul 2020 14:37:00 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 69AED2065C for ; Fri, 24 Jul 2020 14:37:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="SV1Spn3f"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="DHa2vWwb" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 69AED2065C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To:From: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=AmaLZbS7jL1jZLjgOR5PKxu9vtkZ/gtlSrglnfO0Y9Y=; b=SV1Spn3fBBEba2nD2tEjMt5sy4 cfx2qr4J/ExMlE4pr0VTC/KmLX/jmlBeFkZFTNPgi2xMSaroTxV3aBKDmtmzNb244Qvm0cn+ed4Th yIa6rl/uFgpVYfprbigDPO7AKHz1SljHit2ut3beC5oRfBca+5NaRwrOWDbfKS49UbDyQV+whNzoD XzN4NOjVweJtBaz5sSNNreeRLyz9SSDLWuR8/89E1eDtNpF75pFcNVWYhHWT43H/NaoAk8PQBvEzu Lr9IF/q8x6KQTUA85Xood188aRIjo/ZBOz0QBoKL5GPNYeWmziZblekd/K9Ir1lSCaBMtOhEwFJM2 1nPs4PiA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jyyn5-0003Bj-O6; Fri, 24 Jul 2020 14:35:15 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jyyn3-0003BB-R6 for linux-arm-kernel@lists.infradead.org; Fri, 24 Jul 2020 14:35:14 +0000 Received: from localhost.localdomain (236.31.169.217.in-addr.arpa [217.169.31.236]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7A5682063A; Fri, 24 Jul 2020 14:35:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595601312; bh=WTr6hbkNz8uIk+9+PXztZX4f3S3xEa6hEDq7MKDUfN8=; h=From:To:Cc:Subject:Date:From; b=DHa2vWwbOcPxsZhyaojzIC+FrMSV/7QI8InQV+deY83HlJ5b2OZXwSFDcUiu13SY+ nbiBad/k/RU+SZ1K9OwOMwa6HJzjdlCT2vphPIv/zsTDSDwuSOzHLq/HFqNr2nwSjy ExSXfqxM6b7iFYzUcN6NoR/vKHkLGG0DAh0+1m+8= From: Will Deacon To: kvmarm@lists.cs.columbia.edu Subject: [PATCH 0/7] KVM: arm64: Fixes to early stage-2 fault handling Date: Fri, 24 Jul 2020 15:34:59 +0100 Message-Id: <20200724143506.17772-1-will@kernel.org> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200724_103514_023806_091FEF3F X-CRM114-Status: UNSURE ( 9.35 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -5.2 (-----) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-5.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -5.0 RCVD_IN_DNSWL_HI RBL: Sender listed at https://www.dnswl.org/, high trust [198.145.29.99 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.0 DKIMWL_WL_HIGH DKIMwl.org - Whitelisted High sender X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Quentin Perret , kernel-team@android.com, Suzuki Poulose , James Morse , Marc Zyngier , Will Deacon , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Hi folks, Continuing my journey into the KVM stage-2 page-table code, here are some fixes for a bunch of issues I spotted purely by code inspection. Most of these involve really unusual scenarios, but I'm a bit worried about the stage-2 fault on stage-1 page-table walk during instruction fetch from a read-only memslot, as that feels like it might be hittable with EFI. Anyway, feedback welcome, especially as this is a user-visible change. Cheers, Will Cc: Marc Zyngier Cc: Quentin Perret Cc: James Morse Cc: Suzuki Poulose --->8 Will Deacon (7): KVM: arm64: Update comment when skipping guest MMIO access instruction KVM: arm64: Rename kvm_vcpu_dabt_isextabt() KVM: arm64: Handle data and instruction external aborts the same way KVM: arm64: Remove useless local variable KVM: arm64: Move 'invalid syndrome' logic out of io_mem_abort() KVM: arm64: Handle stage-2 faults on stage-1 page-table walks earlier KVM: arm64: Separate write faults on read-only memslots from MMIO arch/arm64/include/asm/kvm_emulate.h | 2 +- arch/arm64/kvm/hyp/switch.c | 2 +- arch/arm64/kvm/mmio.c | 29 +++------- arch/arm64/kvm/mmu.c | 87 +++++++++++++++++++--------- 4 files changed, 69 insertions(+), 51 deletions(-)