[v4,00/10] irqchip: ti, sci-intr/inta: Update the dt bindings to accept different interrupt parents

Message

Lokesh Vutla July 25, 2020, 4:36 p.m. UTC

Hi Marc,
	This is continuation of the RFC patches[0] regarding the driver
updates to support for following interrupt parent connection:
- INTR -> INTR
- INTA -> GICv3
The current existing driver assumes that INTR is always connected to
GICv3 and INTA is always connected to INTR.

As discussed this change breaks the DT backward compatibility but it
allows to not depend on TISCI firmware properties in DT node. IMHO, this
will ensure that any future changes will not effect DT properties.

This series depends on the the new Yaml bindings for common TISCI[1]

[0] https://lore.kernel.org/linux-arm-kernel/[e-mail]/
[1] https://patchwork.kernel.org/patch/11676843/

Changes since v3:
- Hardcode param_count based on parent instead of reading it from DT.
- Drop storing TISCI device id in platform device id field.

Changes since v2:
- Fixed comments from Rob
- Fixed DT schema warnings.

Changes since v1:
- Rebased on top of latest Linux master
- Dropped DT patches.


Lokesh Vutla (10):
  firmware: ti_sci: Drop the device id to resource type translation
  firmware: ti_sci: Drop unused structure ti_sci_rm_type_map
  firmware: ti_sci: Add support for getting resource with subtype
  dt-bindings: irqchip: ti,sci-intr: Update bindings to drop the usage
    of gic as parent
  dt-bindings: irqchip: Convert ti,sci-intr bindings to yaml
  irqchip/ti-sci-intr: Add support for INTR being a parent to INTR
  dt-bindings: irqchip: ti,sci-inta: Update docs to support different
    parent.
  dt-bindings: irqchip: Convert ti,sci-inta bindings to yaml
  irqchip/ti-sci-inta: Do not store TISCI device id in platform device
    id field
  irqchip/ti-sci-inta: Add support for INTA directly connecting to GIC

 .../interrupt-controller/ti,sci-inta.txt      |  66 --------
 .../interrupt-controller/ti,sci-inta.yaml     |  98 +++++++++++
 .../interrupt-controller/ti,sci-intr.txt      |  82 ---------
 .../interrupt-controller/ti,sci-intr.yaml     | 102 ++++++++++++
 MAINTAINERS                                   |   4 +-
 drivers/firmware/ti_sci.c                     | 155 ++++++++----------
 drivers/irqchip/irq-ti-sci-inta.c             |  95 +++++++++--
 drivers/irqchip/irq-ti-sci-intr.c             | 152 ++++++++++-------
 include/linux/soc/ti/ti_sci_protocol.h        |  13 ++
 9 files changed, 455 insertions(+), 312 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/interrupt-controller/ti,sci-inta.txt
 create mode 100644 Documentation/devicetree/bindings/interrupt-controller/ti,sci-inta.yaml
 delete mode 100644 Documentation/devicetree/bindings/interrupt-controller/ti,sci-intr.txt
 create mode 100644 Documentation/devicetree/bindings/interrupt-controller/ti,sci-intr.yaml

Comments

Nishanth Menon July 28, 2020, 2:01 a.m. UTC | #1

On 22:06-20200725, Lokesh Vutla wrote:
> Lokesh Vutla (10):
>   firmware: ti_sci: Drop the device id to resource type translation
>   firmware: ti_sci: Drop unused structure ti_sci_rm_type_map
>   firmware: ti_sci: Add support for getting resource with subtype
>   dt-bindings: irqchip: ti,sci-intr: Update bindings to drop the usage
>     of gic as parent
>   dt-bindings: irqchip: Convert ti,sci-intr bindings to yaml
>   irqchip/ti-sci-intr: Add support for INTR being a parent to INTR
>   dt-bindings: irqchip: ti,sci-inta: Update docs to support different
>     parent.
>   dt-bindings: irqchip: Convert ti,sci-inta bindings to yaml
>   irqchip/ti-sci-inta: Do not store TISCI device id in platform device
>     id field
>   irqchip/ti-sci-inta: Add support for INTA directly connecting to GIC
> 
>  .../interrupt-controller/ti,sci-inta.txt      |  66 --------
>  .../interrupt-controller/ti,sci-inta.yaml     |  98 +++++++++++
>  .../interrupt-controller/ti,sci-intr.txt      |  82 ---------
>  .../interrupt-controller/ti,sci-intr.yaml     | 102 ++++++++++++
>  MAINTAINERS                                   |   4 +-
>  drivers/firmware/ti_sci.c                     | 155 ++++++++----------
>  drivers/irqchip/irq-ti-sci-inta.c             |  95 +++++++++--
>  drivers/irqchip/irq-ti-sci-intr.c             | 152 ++++++++++-------
>  include/linux/soc/ti/ti_sci_protocol.h        |  13 ++

For the firmware related changes:

Acked-by: Nishanth Menon <[e-mail]>

I assume you will take care of the comments from Rob for the yaml
conversion and get his ack as well.