From patchwork Thu Oct 29 13:16:40 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marco Elver X-Patchwork-Id: 11866351 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE94FC55178 for ; Thu, 29 Oct 2020 13:17:43 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 648332067D for ; Thu, 29 Oct 2020 13:17:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="bAgsRr3Q"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=google.com header.i=@google.com header.b="bkpQw3q1" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 648332067D Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:From:Subject:Mime-Version:Message-Id:Date: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=npS/j7XyFkWZyyNd7umop+U9vdKhrBCb+uedBN59IYU=; b=bAgsRr3QLuF8ej52hdeUX4EL6m hIwLB8yKo2V5GAUH4vjrIe1hnZ+kIx+k9ifxMSINCNzX8CvQZyJKQvIRNbwv1WgwCQ+dKuZ8QNZbM /O4p7H2jJ1zVnq1V8WjvNJiZupvpZPAbBMIGPKy479tpgU4a3QZ8ld9+eJ5LuoS/aqoCRbIjwJHay 35ccg+VhN7P4z1SVGjgTl38RrwIadoZIB8G4jX8bTlPjkRoafGN3I0tFBLAxDvhzRBEZQ767ZBMn/ cH9ouPOsAKw+e3iK2NWqUXPANTHRldxf3VNpKXANU2Gu7IZRcFn6n2nVRqA1olezQAPaKGRz3C0O0 MIhsVc+A==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kY7nf-000285-8q; Thu, 29 Oct 2020 13:17:07 +0000 Received: from mail-qk1-x749.google.com ([2607:f8b0:4864:20::749]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kY7na-000257-Cp for linux-arm-kernel@lists.infradead.org; Thu, 29 Oct 2020 13:17:03 +0000 Received: by mail-qk1-x749.google.com with SMTP id s5so1715928qkj.21 for ; Thu, 29 Oct 2020 06:17:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=sender:date:message-id:mime-version:subject:from:to:cc; bh=gJ+NyZrwSjh9xv4IitL3tDIsRKqkaN8A5XofNgnAjw0=; b=bkpQw3q1vLKk8DHo5pHLHBVE1CIav1oE1voIWji1HnsQ08+YTjgHqmcXNPvpEvKeJX fqyg8UADfhL3YCWwAyuqU1senrwPc8QfPpEt5Lk0hmZL10YHWhVsO4gZ7ivQm8EhP9x0 D/SXkdwqzsmoEdyysNzopPSuloZqi0uBgd59zF9Ik1Z3OS2aAO59SjyVg2z1dfhOlafL K9R8qDs+QEnNahOgYlbKRFVOgdBl+JRhs91xoEyWKV5tIksD26LJDse70QYAfLdS+RS3 IKaXGR4ELKqHdBk0eVTImANA7yaRtoe2Gtp/13tf/72Si6arhIafA5VVPQMvj4cjk8Jc uLhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:message-id:mime-version:subject:from :to:cc; bh=gJ+NyZrwSjh9xv4IitL3tDIsRKqkaN8A5XofNgnAjw0=; b=nqF8lyr9w8vNuI/aNBAu6R1d9tlt6w4XSHjdRvYJZN00IR1UhrIhZISFkHnfObrjVS abHlCAHEyrqgAhkY6VwA2Up92lO4hOaX0wtmcwtnLPsRs6vUJg9mLupaTfuYL4vT/QtI 0+Jk5k2IFVg44sTWAMJVf55dTjFDldKrwtXozKMvo3/jLDRw5Nbmtpen5H+aHr+tcY+W sRKn5KNKIIoqUiMxsXRHYKNU0yp6ZmgMQ1M7e0fySuVuyVZ9ESGhO/k8LSB+YH7RT8pn B0mCduaKuA8IvIrZiDyldZcZ4l2TTVq9uvDdT+D5ZrnJQJxjb0Iw3DbI/3Yvb/QnXmnx CdAA== X-Gm-Message-State: AOAM533ES5kLhdqa8yPiiYgO65R+1BocO1TuOu1F2vTa9NE8VLKCmwyG IilpNZSlK412/UuyO9vZl3/COEYKmA== X-Google-Smtp-Source: ABdhPJyiBEUA7qxqCN7bgZyMqRXcQURQ1iojG+u5gBlNOJrvBwDovJB4Z2UVeJEY7owHFDQXsGpnumDHpA== X-Received: from elver.muc.corp.google.com ([2a00:79e0:15:13:f693:9fff:fef4:2449]) (user=elver job=sendgmr) by 2002:ad4:45ca:: with SMTP id v10mr4429043qvt.48.1603977418489; Thu, 29 Oct 2020 06:16:58 -0700 (PDT) Date: Thu, 29 Oct 2020 14:16:40 +0100 Message-Id: <20201029131649.182037-1-elver@google.com> Mime-Version: 1.0 X-Mailer: git-send-email 2.29.1.341.ge80a0c044ae-goog Subject: [PATCH v6 0/9] KFENCE: A low-overhead sampling-based memory safety error detector From: Marco Elver To: elver@google.com, akpm@linux-foundation.org, glider@google.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201029_091702_471008_657B8B49 X-CRM114-Status: GOOD ( 18.44 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, hdanton@sina.com, linux-doc@vger.kernel.org, peterz@infradead.org, catalin.marinas@arm.com, dave.hansen@linux.intel.com, linux-mm@kvack.org, edumazet@google.com, hpa@zytor.com, cl@linux.com, will@kernel.org, sjpark@amazon.com, corbet@lwn.net, x86@kernel.org, kasan-dev@googlegroups.com, mingo@redhat.com, vbabka@suse.cz, rientjes@google.com, aryabinin@virtuozzo.com, joern@purestorage.com, keescook@chromium.org, paulmck@kernel.org, jannh@google.com, andreyknvl@google.com, bp@alien8.de, luto@kernel.org, Jonathan.Cameron@huawei.com, tglx@linutronix.de, dvyukov@google.com, linux-arm-kernel@lists.infradead.org, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, penberg@kernel.org, iamjoonsoo.kim@lge.com Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org This adds the Kernel Electric-Fence (KFENCE) infrastructure. KFENCE is a low-overhead sampling-based memory safety error detector of heap use-after-free, invalid-free, and out-of-bounds access errors. This series enables KFENCE for the x86 and arm64 architectures, and adds KFENCE hooks to the SLAB and SLUB allocators. KFENCE is designed to be enabled in production kernels, and has near zero performance overhead. Compared to KASAN, KFENCE trades performance for precision. The main motivation behind KFENCE's design, is that with enough total uptime KFENCE will detect bugs in code paths not typically exercised by non-production test workloads. One way to quickly achieve a large enough total uptime is when the tool is deployed across a large fleet of machines. KFENCE objects each reside on a dedicated page, at either the left or right page boundaries. The pages to the left and right of the object page are "guard pages", whose attributes are changed to a protected state, and cause page faults on any attempted access to them. Such page faults are then intercepted by KFENCE, which handles the fault gracefully by reporting a memory access error. Guarded allocations are set up based on a sample interval (can be set via kfence.sample_interval). After expiration of the sample interval, the next allocation through the main allocator (SLAB or SLUB) returns a guarded allocation from the KFENCE object pool. At this point, the timer is reset, and the next allocation is set up after the expiration of the interval. To enable/disable a KFENCE allocation through the main allocator's fast-path without overhead, KFENCE relies on static branches via the static keys infrastructure. The static branch is toggled to redirect the allocation to KFENCE. The KFENCE memory pool is of fixed size, and if the pool is exhausted no further KFENCE allocations occur. The default config is conservative with only 255 objects, resulting in a pool size of 2 MiB (with 4 KiB pages). We have verified by running synthetic benchmarks (sysbench I/O, hackbench) that a kernel with KFENCE is performance-neutral compared to a non-KFENCE baseline kernel. KFENCE is inspired by GWP-ASan [1], a userspace tool with similar properties. The name "KFENCE" is a homage to the Electric Fence Malloc Debugger [2]. For more details, see Documentation/dev-tools/kfence.rst added in the series -- also viewable here: https://raw.githubusercontent.com/google/kasan/kfence/Documentation/dev-tools/kfence.rst [1] http://llvm.org/docs/GwpAsan.html [2] https://linux.die.net/man/3/efence v6: * Record allocation and free task pids, and show them in reports. This information helps more easily identify e.g. racy use-after-frees. v5: https://lkml.kernel.org/r/20201027141606.426816-1-elver@google.com * Lots of smaller fixes (see details in patches). * Optimize is_kfence_address() by using better in-range check. * Removal of HAVE_ARCH_KFENCE_STATIC_POOL and static pool support in favor of memblock_alloc'd pool only, as it avoids all issues with virt_to translations. With the new optimizations to is_kfence_address(), we measure no noticeable performance impact. * Taint with TAINT_BAD_PAGE, to distinguish memory errors from regular warnings (also used by SL*B/KASAN/etc. for memory errors). * Rework sample_interval parameter dynamic setting semantics. * Rework kfence_shutdown_cache(). * Fix obj_to_index+objs_per_slab_page, which among other things is required when using memcg accounted allocations. * Rebase to 5.10-rc1. v4: https://lkml.kernel.org/r/20200929133814.2834621-1-elver@google.com * MAINTAINERS: Split out from first patch. * Make static memory pool's attrs entirely arch-dependent. * Fix report generation if __slab_free tail-called. * Clarify RCU test comment [reported by Paul E. McKenney]. v3: https://lkml.kernel.org/r/20200921132611.1700350-1-elver@google.com * Rewrite SLAB/SLUB patch descriptions to clarify need for 'orig_size'. * Various smaller fixes (see details in patches). v2: https://lkml.kernel.org/r/20200915132046.3332537-1-elver@google.com * Various comment/documentation changes (see details in patches). * Various smaller fixes (see details in patches). * Change all reports to reference the kfence object, "kfence-#nn". * Skip allocation/free internals stack trace. * Rework KMEMLEAK compatibility patch. RFC/v1: https://lkml.kernel.org/r/20200907134055.2878499-1-elver@google.com Alexander Potapenko (5): mm: add Kernel Electric-Fence infrastructure x86, kfence: enable KFENCE for x86 mm, kfence: insert KFENCE hooks for SLAB mm, kfence: insert KFENCE hooks for SLUB kfence, kasan: make KFENCE compatible with KASAN Marco Elver (4): arm64, kfence: enable KFENCE for ARM64 kfence, Documentation: add KFENCE documentation kfence: add test suite MAINTAINERS: Add entry for KFENCE Documentation/dev-tools/index.rst | 1 + Documentation/dev-tools/kfence.rst | 291 ++++++++++ MAINTAINERS | 11 + arch/arm64/Kconfig | 1 + arch/arm64/include/asm/kfence.h | 19 + arch/arm64/mm/fault.c | 4 + arch/arm64/mm/mmu.c | 7 +- arch/x86/Kconfig | 1 + arch/x86/include/asm/kfence.h | 65 +++ arch/x86/mm/fault.c | 4 + include/linux/kfence.h | 191 +++++++ include/linux/slab_def.h | 3 + include/linux/slub_def.h | 3 + init/main.c | 3 + lib/Kconfig.debug | 1 + lib/Kconfig.kfence | 73 +++ mm/Makefile | 1 + mm/kasan/common.c | 15 + mm/kasan/generic.c | 3 +- mm/kfence/Makefile | 6 + mm/kfence/core.c | 821 ++++++++++++++++++++++++++++ mm/kfence/kfence.h | 107 ++++ mm/kfence/kfence_test.c | 822 +++++++++++++++++++++++++++++ mm/kfence/report.c | 235 +++++++++ mm/slab.c | 37 +- mm/slab_common.c | 5 +- mm/slub.c | 72 ++- 27 files changed, 2771 insertions(+), 31 deletions(-) create mode 100644 Documentation/dev-tools/kfence.rst create mode 100644 arch/arm64/include/asm/kfence.h create mode 100644 arch/x86/include/asm/kfence.h create mode 100644 include/linux/kfence.h create mode 100644 lib/Kconfig.kfence create mode 100644 mm/kfence/Makefile create mode 100644 mm/kfence/core.c create mode 100644 mm/kfence/kfence.h create mode 100644 mm/kfence/kfence_test.c create mode 100644 mm/kfence/report.c