From patchwork Wed Nov 4 01:29:25 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Doug Anderson X-Patchwork-Id: 11879475 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5E205C388F7 for ; Wed, 4 Nov 2020 01:32:07 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 06B8E223C7 for ; Wed, 4 Nov 2020 01:32:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="nv3JfcKH"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="fHKmoVtG" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 06B8E223C7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To:From: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=aU7Spk1Isj3Vr3wJURnSiQWieDyJnEM0M7eXrSl7oSM=; b=nv3JfcKHoLVgBGYuI2PMeDAkOP l90rSyk0U52DU29+WkbsYZL0/HokBD43gCVZ5zuAEYMPymjvff1boVfY3X9D0A9e5h5wM5gSfJQZj DRdd6xGWl6diaB5DfhLMH85Xk5baRc+a8EkFtQvcQNpLv+9xevJlVcUzoojI4N4ug31oOb3p8WczX SfK8SYiipEmwXVEe6n/LKd0tYi0IX/+Xh/jSScm2rpaueX95UJeHXv8wrFeGkMRzvVwwg0GUoG/+W PMfPUUQLG4Fa+SP77uLYuHZejOP9K8nFUJBLdA/9LIA4XdP8xuWvL9ai3N7smuvMUaRey/wiZ1f+e PM7bsbqg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ka7co-0001BH-RC; Wed, 04 Nov 2020 01:30:11 +0000 Received: from mail-pl1-x643.google.com ([2607:f8b0:4864:20::643]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1ka7ci-00019Y-TH for linux-arm-kernel@lists.infradead.org; Wed, 04 Nov 2020 01:30:06 +0000 Received: by mail-pl1-x643.google.com with SMTP id w11so9475380pll.8 for ; Tue, 03 Nov 2020 17:29:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=aMTaSm89kT5TDRihafmXN8fpXabsdYs0qDU43+JwbS0=; b=fHKmoVtGYK4sREwOdOU4Lct3hnbiNwEW+GYbl98M7c1mvS5wdl8AE21fkfFF0sd0FZ C2PVeaBbQw/o9686zJwDajQOuToUyje3hR7IdmOUKKuOhsdEIXFfQkVk5CNd+5h2cYJj ANOgtGhRljNjiHSSOrTiMGFLQTcQDPiuAQ1t4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=aMTaSm89kT5TDRihafmXN8fpXabsdYs0qDU43+JwbS0=; b=oGCgkq/BHqzufwSyLlxIxODmQpwI15+wyvFHw+QNlv0QRFf5cAUme5x5x1+zOuuKNF +A8fNDqOd8ITa/km5/ns7ohKpi1lH+AHTal9jCjyXUjTuHXud85GZYiuwg0vQarf9wny TML3/oieL5toVcLyB7n3CzGAY988ySYkWzLaVovE5fz8/SuAddoUNIt60jISgbe/HZO2 pX3WEbIrH46sxDhlYqxfJ+4CT3szfrEkZdnXo6l/fverZZ69vLHWAjMi52J/dzj825DX 34PXwNjZByb7LR2y3rwDJZ8dwCr+xMnb8UGGoseedttGyEC0mXOuDlV4cZEJZQa+tadv melA== X-Gm-Message-State: AOAM53062fRGsyk05WOO5L6F7nJqmU5NGH9vYO3Efc3u6auqCXII0zmU WKp5qqfeeGnLc0UGl5IT6yCuVw== X-Google-Smtp-Source: ABdhPJxCpGL3gLtUMaj65HaRL8OI22vjNZDD93pNWHBqdtvQvNhwYi5Rfdlm5Nm68IFVufqOv1Misg== X-Received: by 2002:a17:902:654a:b029:d5:e98f:2436 with SMTP id d10-20020a170902654ab02900d5e98f2436mr27621181pln.21.1604453393066; Tue, 03 Nov 2020 17:29:53 -0800 (PST) Received: from tictac2.mtv.corp.google.com ([2620:15c:202:1:42b0:34ff:fe3d:58e6]) by smtp.gmail.com with ESMTPSA id m3sm347424pjv.52.2020.11.03.17.29.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Nov 2020 17:29:52 -0800 (PST) From: Douglas Anderson To: jkosina@suse.cz, benjamin.tissoires@redhat.com, gregkh@linuxfoundation.org, Dmitry Torokhov Subject: [PATCH v4 0/4] HID: i2c-hid: Reorganize to allow supporting goodix, gt7375p Date: Tue, 3 Nov 2020 17:29:25 -0800 Message-Id: <20201104012929.3850691-1-dianders@chromium.org> X-Mailer: git-send-email 2.29.1.341.ge80a0c044ae-goog MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201103_203005_178644_462B86F4 X-CRM114-Status: GOOD ( 18.44 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Geert Uytterhoeven , Catalin Marinas , Bjorn Andersson , kai.heng.feng@canonical.com, Will Deacon , Anson Huang , Masahiro Yamada , Michael Walle , Krzysztof Kozlowski , You-Sheng Yang , linux-arm-kernel@lists.infradead.org, linux-input@vger.kernel.org, Aaron Ma , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Jiri Kosina , swboyd@chromium.org, hdegoede@redhat.com, robh+dt@kernel.org, andrea@borgia.bo.it, Douglas Anderson , Li Yang , Vinod Koul , Xiaofei Tan , Olof Johansson , Shawn Guo , Pavel Balan Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The goal of this series is to support the Goodix GT7375P touchscreen. This touchscreen is special because it has power sequencing requirements that necessitate driving a reset GPIO. To do this, we totally rejigger the way i2c-hid is organized so that it's easier to jam the Goodix support in there. This series was: - Tested on a device that uses normal i2c-hid - Tested on a device that pretended to have a Goodix i2c-hid device on it. I don't have a device with GT7375P setup yet and the person who has been testing remotely for me hasn't tested this exact series. I think it should still work, though. - NOT tested on any ACPI devices (just compile tested). There are probably still small nits, but hopefully we're getting closer to something people like. Changes in v4: - Fully rejigger so ACPI and OF are full subclasses. - ("arm64: defconfig: Update config names for i2c-hid rejigger") new for v4. - Totally redid based on the new subclass system. Changes in v3: - Rework to use subclassing. - Removed Benjamin as a maintainer. - Fixed compatible in example. - Updated description. - Rework to use subclassing. Changes in v2: - Use a separate compatible string for this new touchscreen. - Get timings based on the compatible string. - ("dt-bindings: HID: i2c-hid: Introduce bindings for the Goodix GT7375P") new in v2. Douglas Anderson (4): HID: i2c-hid: Reorganize so ACPI and OF are subclasses arm64: defconfig: Update config names for i2c-hid rejigger dt-bindings: HID: i2c-hid: Introduce bindings for the Goodix GT7375P HID: i2c-hid: Introduce goodix-i2c-hid as a subclass of i2c-hid .../bindings/input/goodix,gt7375p.yaml | 63 +++++ arch/arm64/configs/defconfig | 3 +- drivers/hid/Makefile | 2 +- drivers/hid/i2c-hid/Kconfig | 47 +++- drivers/hid/i2c-hid/Makefile | 6 +- drivers/hid/i2c-hid/i2c-hid-acpi.c | 167 ++++++++++++ drivers/hid/i2c-hid/i2c-hid-core.c | 253 +++--------------- drivers/hid/i2c-hid/i2c-hid-of-goodix.c | 120 +++++++++ drivers/hid/i2c-hid/i2c-hid-of.c | 149 +++++++++++ drivers/hid/i2c-hid/i2c-hid.h | 24 ++ include/linux/platform_data/i2c-hid.h | 41 --- 11 files changed, 607 insertions(+), 268 deletions(-) create mode 100644 Documentation/devicetree/bindings/input/goodix,gt7375p.yaml create mode 100644 drivers/hid/i2c-hid/i2c-hid-acpi.c create mode 100644 drivers/hid/i2c-hid/i2c-hid-of-goodix.c create mode 100644 drivers/hid/i2c-hid/i2c-hid-of.c delete mode 100644 include/linux/platform_data/i2c-hid.h