From patchwork Mon Nov 9 21:36:32 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Doug Anderson X-Patchwork-Id: 11892637 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8237C55ABD for ; Mon, 9 Nov 2020 21:38:35 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 34BEE206CB for ; Mon, 9 Nov 2020 21:38:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="fBTh3mNl"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="R4dcTpQU" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 34BEE206CB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To:From: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=JfeSj6cvDcQoax0fjzbDp1YDy0vEy3S2+xdn9HQ3z0Q=; b=fBTh3mNlMuFjsUSWQOLJIQw7vC CzqQL5qHgeigcfIyjLSKIKImQZVPh/hQuZqHqwp7Nt6VsdY8C7wvG07zu4PXF3vSCxZouPoQ/EAyZ C0HMzEatDBr4tV9BjLX0vxBNP89kxOkQLl2ywGXh0D6sFPAXzT/gU/QZNyK61TLhVfJiAuWZ8M8B7 TvnUPsTVHqEnuC/Q9H8K7wzjPjZyVjZnTo4GBiqfq7jPOl8AJMvM72bN8pnP/VNZxpLRvl3YvOeRD 0gyw6NU/AjI+4gOm3hSXB8kLPuHLg2G2K+0zYBcKStxGphWhM/qRl/gcAuAozfLXYLAgjKKTD7Fot iukLa6+g==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kcEqw-0003La-F3; Mon, 09 Nov 2020 21:37:30 +0000 Received: from mail-pf1-x441.google.com ([2607:f8b0:4864:20::441]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kcEqt-0003KI-09 for linux-arm-kernel@lists.infradead.org; Mon, 09 Nov 2020 21:37:27 +0000 Received: by mail-pf1-x441.google.com with SMTP id q10so9420532pfn.0 for ; Mon, 09 Nov 2020 13:37:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=b1NwiXOXlnIKNGIq2jOgXwU9+Xz/K9vApGe2ajZ4L/M=; b=R4dcTpQUd2iqX73ACvGUPmT1VVIUx3/A6Qxo4tCla0hRau8MucwhNWUtToscfnQYhX sWxS1M5Ppcfib6j2cLE1xYgwwzBSW6wEjHPoKVGK0hh4+OBvnLSMKzacFIKjJBbVgaIx UmMbG7zv/R+3Ny7vDuqY6mgL0gaF77Vf1ckdE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=b1NwiXOXlnIKNGIq2jOgXwU9+Xz/K9vApGe2ajZ4L/M=; b=sZ4uw79qXpgOIkn3wb1b8o8sfBzq4g96CrG6DFE3HB1FzCVC8DNhppYOJ0V9QkLNr5 Y8PW0poPaiWBeljpuqaABuls3dkvDuDusARq0ptP143AO9YNvp1NoXtpheBtN11y8quZ v9rSYdbvcOepcBcupEotRaJmht5M6VgEXvcUXNsftUbfutnSEMrN7bghOoV2yOGPMpiX uR/DqwCPFAYv4pfSmprZGHT6VSW5+K13R+lbBdABr2K1F6u1mLE91UaEMAzFTUuJov/M /Q9WvmdRvZwuUt+herp7w9PwsCr1zi7x8iqnkujxsFKK4EziHRqkb7tS5IST361NW8op nSgw== X-Gm-Message-State: AOAM530hqhyd7R82iXAwm0LNzCzROEv2bBMlB1mPo0argoFag3UIpmx9 hXRfliGJVaRuwuPCsFCBXQRhLg== X-Google-Smtp-Source: ABdhPJzzLRXx56fIwabSNEYhOPA3YuOpDVtH42rriiwwfcNJKtY0Z3PUX3P7l9sEgtfXBOPAQpgwAw== X-Received: by 2002:aa7:868f:0:b029:155:dcd2:7320 with SMTP id d15-20020aa7868f0000b0290155dcd27320mr3869685pfo.53.1604957843517; Mon, 09 Nov 2020 13:37:23 -0800 (PST) Received: from tictac2.mtv.corp.google.com ([2620:15c:202:1:42b0:34ff:fe3d:58e6]) by smtp.gmail.com with ESMTPSA id i10sm11895444pfd.60.2020.11.09.13.37.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Nov 2020 13:37:22 -0800 (PST) From: Douglas Anderson To: jkosina@suse.cz, benjamin.tissoires@redhat.com, gregkh@linuxfoundation.org, Dmitry Torokhov Subject: [PATCH v5 0/4] HID: i2c-hid: Reorganize to allow supporting goodix, gt7375p Date: Mon, 9 Nov 2020 13:36:32 -0800 Message-Id: <20201109213636.1267536-1-dianders@chromium.org> X-Mailer: git-send-email 2.29.2.222.g5d2a92d10f8-goog MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201109_163727_056972_F2B89416 X-CRM114-Status: GOOD ( 16.54 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Geert Uytterhoeven , Catalin Marinas , Bjorn Andersson , kai.heng.feng@canonical.com, Will Deacon , Anson Huang , Masahiro Yamada , Michael Walle , Krzysztof Kozlowski , You-Sheng Yang , linux-arm-kernel@lists.infradead.org, linux-input@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Jiri Kosina , swboyd@chromium.org, hdegoede@redhat.com, Xiaofei Tan , andrea@borgia.bo.it, Douglas Anderson , Li Yang , Vinod Koul , robh+dt@kernel.org, Olof Johansson , Shawn Guo , Pavel Balan Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The goal of this series is to support the Goodix GT7375P touchscreen. This touchscreen is special because it has power sequencing requirements that necessitate driving a reset GPIO. To do this, we totally rejigger the way i2c-hid is organized so that it's easier to jam the Goodix support in there. This series was: - Tested on a device that uses normal i2c-hid. - Tested on a device that has a Goodix i2c-hid device. - NOT tested on any ACPI devices (just compile tested). Changes in v5: - Add shutdown_tail op and use it in ACPI. - Added mention of i2c-hid in the yaml itself as per Rob. - Adjusted subject as per Rob. - i2chid_subclass_data => i2chid_ops. - power_up_device => power_up (same with power_down). - subclass => ops. Changes in v4: - ("arm64: defconfig: Update config names for i2c-hid rejigger") new for v4. - Fully rejigger so ACPI and OF are full subclasses. - Totally redid based on the new subclass system. Changes in v3: - Fixed compatible in example. - Removed Benjamin as a maintainer. - Rework to use subclassing. - Updated description. Changes in v2: - ("dt-bindings: HID: i2c-hid: Introduce bindings for the Goodix GT7375P") new in v2. - Get timings based on the compatible string. - Use a separate compatible string for this new touchscreen. Douglas Anderson (4): HID: i2c-hid: Reorganize so ACPI and OF are separate modules arm64: defconfig: Update config names for i2c-hid rejigger dt-bindings: input: HID: i2c-hid: Introduce bindings for the Goodix GT7375P HID: i2c-hid: Introduce goodix-i2c-hid using i2c-hid core .../bindings/input/goodix,gt7375p.yaml | 65 +++++ arch/arm64/configs/defconfig | 3 +- drivers/hid/Makefile | 2 +- drivers/hid/i2c-hid/Kconfig | 47 +++- drivers/hid/i2c-hid/Makefile | 6 +- drivers/hid/i2c-hid/i2c-hid-acpi.c | 170 ++++++++++++ drivers/hid/i2c-hid/i2c-hid-core.c | 252 +++--------------- drivers/hid/i2c-hid/i2c-hid-of-goodix.c | 120 +++++++++ drivers/hid/i2c-hid/i2c-hid-of.c | 147 ++++++++++ drivers/hid/i2c-hid/i2c-hid.h | 25 ++ include/linux/platform_data/i2c-hid.h | 41 --- 11 files changed, 615 insertions(+), 263 deletions(-) create mode 100644 Documentation/devicetree/bindings/input/goodix,gt7375p.yaml create mode 100644 drivers/hid/i2c-hid/i2c-hid-acpi.c create mode 100644 drivers/hid/i2c-hid/i2c-hid-of-goodix.c create mode 100644 drivers/hid/i2c-hid/i2c-hid-of.c delete mode 100644 include/linux/platform_data/i2c-hid.h