From patchwork Thu Nov 12 00:41:26 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Doug Anderson X-Patchwork-Id: 11898727 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E7FAC55ABD for ; Thu, 12 Nov 2020 00:42:22 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7B874206A1 for ; Thu, 12 Nov 2020 00:42:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="g/bk3tyE"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="R2s1M0pm" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7B874206A1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To:From: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=m9BSmhtoiqLMbH3i6r3OEVJHrV4B30MbaQI0waAava8=; b=g/bk3tyESVVQHhtt46RXkSBTJ/ Lunu9NpDDNhyXxofmJAbRZBKN2SU6wAEUXKBIQZXbEzOmkrlJWFTcz9Fh9eON+cYUpxJMId11s3cz IFEBgyLcW30N/KKk3box8iefLxIj66H8u4/lpl2W9LW0n/NXxjusFH3ILefwM1a8gvlim3j5hQdwn jE0pUg+J+GDWfoZMOirCs/IkvcgH42OOmAlLIKjoi47KOXuIXkQVFyLtW/bc88XivVhPqiHCg1aXj HiMXVYQo+tE2SYTEb7ISj9oAzNsTIa9SrqHunSf45POXZMKGyVmFmExKze/BBd1v9Cik/aoyOlrT5 +90t16IA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kd0gN-0003bj-LI; Thu, 12 Nov 2020 00:41:47 +0000 Received: from mail-pf1-x443.google.com ([2607:f8b0:4864:20::443]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kd0gI-0003at-Io for linux-arm-kernel@lists.infradead.org; Thu, 12 Nov 2020 00:41:43 +0000 Received: by mail-pf1-x443.google.com with SMTP id w6so2912198pfu.1 for ; Wed, 11 Nov 2020 16:41:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=Utwe4xR8J8QGLdCImujYGLQlNTOgzBqC1iHA5Eyo1w4=; b=R2s1M0pmReZg68qwieY3zSp8emiSgL1YMPaMVa32i0hE9tK60LpmUBVrpNiinG6vQJ i07E5AMD14YR0zSnIE9S1JJyVleGMI+Zcjm77YA/Ddmh6xWeMK+51bUDesZWNZ9XKRY1 YGLn+bz3iMLkZu6zhEs8FfLq3CY4Ml06aoXVo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=Utwe4xR8J8QGLdCImujYGLQlNTOgzBqC1iHA5Eyo1w4=; b=tFi+3PilblQmYqQyeYh1l6XCqBwAGl0dhz31pVnptet5pyIDKyTNEM56Mw/H0nM5sE Tg38U/hIYWoWwIbIJkuaTeXZcrdoUiPuZJ0w+pigtVnw6SFMheR8On1H9dJJs74uYgzA Xo5f0dSKkuMQUiOL1zDSHOGy7xr0/DG0/CqVn5uC2gKHOYmCp/TUXZKrehbsnzD3YHiV 5XkmDGgxcreSvPnTG6N5DkqZg8UEV/X3sHxW9mR/qerwuH3pFOMv4PBjE966O/SJzbFJ abvzsbC1RhG8KaNNmluvDQ7FLGbXXhCa3ICdpkcf/lDAtnkBqeqDQ2PpxVA86a9DAd4a PyKw== X-Gm-Message-State: AOAM532CD2oc1huC3RHX8QoE6B3wHjSAJn1pvse0sQipA8YpMi0YIGIm UMVBOZ+HK5BYE7rmAJzC3EZriQ== X-Google-Smtp-Source: ABdhPJyVp3nagtjEa+HXLXT+UNnpG/bMPWN3BscAh7XrhLgMKsFjUAPbrXErc++yKAhQWjX5SqM88A== X-Received: by 2002:a17:90a:df15:: with SMTP id gp21mr6542210pjb.37.1605141698821; Wed, 11 Nov 2020 16:41:38 -0800 (PST) Received: from tictac2.mtv.corp.google.com ([2620:15c:202:1:42b0:34ff:fe3d:58e6]) by smtp.gmail.com with ESMTPSA id t26sm4265522pfl.72.2020.11.11.16.41.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Nov 2020 16:41:38 -0800 (PST) From: Douglas Anderson To: jkosina@suse.cz, benjamin.tissoires@redhat.com, gregkh@linuxfoundation.org, Dmitry Torokhov Subject: [PATCH v6 0/4] HID: i2c-hid: Reorganize to allow supporting goodix, gt7375p Date: Wed, 11 Nov 2020 16:41:26 -0800 Message-Id: <20201112004130.17290-1-dianders@chromium.org> X-Mailer: git-send-email 2.29.2.222.g5d2a92d10f8-goog MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201111_194142_681414_9B183A6A X-CRM114-Status: GOOD ( 17.19 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Geert Uytterhoeven , Catalin Marinas , Bjorn Andersson , kai.heng.feng@canonical.com, Will Deacon , Anson Huang , Masahiro Yamada , Michael Walle , Krzysztof Kozlowski , You-Sheng Yang , linux-arm-kernel@lists.infradead.org, linux-input@vger.kernel.org, Aaron Ma , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Jiri Kosina , swboyd@chromium.org, hdegoede@redhat.com, robh+dt@kernel.org, andrea@borgia.bo.it, Douglas Anderson , Li Yang , Vinod Koul , Xiaofei Tan , Olof Johansson , Shawn Guo , Pavel Balan Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The goal of this series is to support the Goodix GT7375P touchscreen. This touchscreen is special because it has power sequencing requirements that necessitate driving a reset GPIO. To do this, we totally rejigger the way i2c-hid is organized so that it's easier to jam the Goodix support in there. This series was: - Tested on a device that uses normal i2c-hid. - Tested on a device that has a Goodix i2c-hid device. - Tested on an ACPI device, but an earlier version of the series. Changes in v6: - ACPI probe function should have been "static" - Don't export suspend/resume, just export dev_pm_ops from core. - Fixed crash in ACPI module (missing init of "client") - No need for regulator include in the core. - Removed i2c_device_id table from ACPI module. - Suspend/resume are no longer exported from the core. Changes in v5: - Add shutdown_tail op and use it in ACPI. - Added mention of i2c-hid in the yaml itself as per Rob. - Adjusted subject as per Rob. - i2chid_subclass_data => i2chid_ops. - power_up_device => power_up (same with power_down). - subclass => ops. Changes in v4: - ("arm64: defconfig: Update config names for i2c-hid rejigger") new for v4. - Fully rejigger so ACPI and OF are full subclasses. - Totally redid based on the new subclass system. Changes in v3: - Fixed compatible in example. - Removed Benjamin as a maintainer. - Rework to use subclassing. - Updated description. Changes in v2: - ("dt-bindings: HID: i2c-hid: Introduce bindings for the Goodix GT7375P") new in v2. - Get timings based on the compatible string. - Use a separate compatible string for this new touchscreen. Douglas Anderson (4): HID: i2c-hid: Reorganize so ACPI and OF are separate modules arm64: defconfig: Update config names for i2c-hid rejigger dt-bindings: input: HID: i2c-hid: Introduce bindings for the Goodix GT7375P HID: i2c-hid: Introduce goodix-i2c-hid using i2c-hid core .../bindings/input/goodix,gt7375p.yaml | 65 +++++ arch/arm64/configs/defconfig | 3 +- drivers/hid/Makefile | 2 +- drivers/hid/i2c-hid/Kconfig | 47 +++- drivers/hid/i2c-hid/Makefile | 6 +- drivers/hid/i2c-hid/i2c-hid-acpi.c | 159 +++++++++++ drivers/hid/i2c-hid/i2c-hid-core.c | 254 +++--------------- drivers/hid/i2c-hid/i2c-hid-of-goodix.c | 116 ++++++++ drivers/hid/i2c-hid/i2c-hid-of.c | 143 ++++++++++ drivers/hid/i2c-hid/i2c-hid.h | 22 ++ include/linux/platform_data/i2c-hid.h | 41 --- 11 files changed, 596 insertions(+), 262 deletions(-) create mode 100644 Documentation/devicetree/bindings/input/goodix,gt7375p.yaml create mode 100644 drivers/hid/i2c-hid/i2c-hid-acpi.c create mode 100644 drivers/hid/i2c-hid/i2c-hid-of-goodix.c create mode 100644 drivers/hid/i2c-hid/i2c-hid-of.c delete mode 100644 include/linux/platform_data/i2c-hid.h Acked-by: Will Deacon