From patchwork Sun Dec 6 19:02:34 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sam Ravnborg X-Patchwork-Id: 11954297 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0FA24C4361B for ; Sun, 6 Dec 2020 19:04:32 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C740A2310E for ; Sun, 6 Dec 2020 19:04:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C740A2310E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ravnborg.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To:From: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=m3/kIuhLOZ1+uGoN0pXOT8hbdPICcnds/0ZeJjDPiIY=; b=NFTUSCz0VsTDtPvlqICmi4g2Fa Qblhnra1NuC6OnFR3Gc0cCTy8mifd+lM3XD1ox9isnAVQW5UOKQHvw0STkF4aBG08MX3/fOFjIC7E CZ7msMdqwR56Akh0QJE2OFnM2366pxxGEUA18uOqOpkvWQUQtLpbne7e2d5xgdfo6gVLriZsDk+8X ctgknFc8wIZNpP0F+EaXV4PGLz52jgauH6T+U+KNoOYy9Nz8okzYMUf9JFua0+vWhcOuX9q7xtJpH mZ/eNR5veiSKfJIrJHsiI2MnyAJPpLD8pg2AcAGroYZY76K24dVgSPtubsGPPK96Qr4BihdUVK8oN S6r8KAXA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1klzJF-0005B3-PB; Sun, 06 Dec 2020 19:03:01 +0000 Received: from mail-lj1-x242.google.com ([2a00:1450:4864:20::242]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1klzJD-0005AK-3s for linux-arm-kernel@lists.infradead.org; Sun, 06 Dec 2020 19:03:00 +0000 Received: by mail-lj1-x242.google.com with SMTP id j10so12662603lja.5 for ; Sun, 06 Dec 2020 11:02:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=gOK5EsUnBK6I0SB14+NAG+xJwYrELRFSAKPeWrBBqm0=; b=F5B/Dk2Vkp1/cK20z+ZEyqFMI4MhCOK1at24ue0UjfUbKVxXzUto9EPpBz17r9aNxb DQ+iCsfg16Ld/0BdlTVRJNUUBu/KoAZWu9eHkNiITsc3fUwfAXS3AE1WbkqIsVlhVZTz e228UaP+a+H4XJJ6fclx3ZCzVrkeqzV8iToa1GWcc3fxpT5EkwRuTlrenhEX2CfUisdz LFd7aVe8D3edJSf+5+ODMl8qKNBfWwChQzsHZrOPSq0cj+SQsAL3lLaIbzyzrQhxToV/ 2k5Zv+Gfrl9Dah/SGX98ZRI7J/Qvy5bdprVwcTTtwFyKIDcQUxeGexXpSTIe0k5AqJHw 94Tg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :mime-version:content-transfer-encoding; bh=gOK5EsUnBK6I0SB14+NAG+xJwYrELRFSAKPeWrBBqm0=; b=W3uf2YY8jx5CDFCAsyHn5V5BgJ09YGGRVnNUOMrvjqoiwZNrvLBKnBpLWSgg99oUo+ 4wIruC13c6/mlyOYHAiJefNMQRFAHJSicnM5/vr33WhtNSlqGe+GCDGNA96nzK7K4iyC +T8Hkb+R8+KrJ3uaeZgA+uu49yYxG/clvfd3RCfsIXUOMl7WYttVQfuljqn5oHLuBo8Y +l3GJhb3eTBSOFesMint/L5Lf4FacT49lftNoObZwJcVKQeoXTIvtRikBxZLuiIINuav Wta+uoUK7Fjn1FhF+RCehVnawlUU0n28dy+y2gVLVnkTcGEDSOV+u7VMVjmynk6Jn7lu hvuQ== X-Gm-Message-State: AOAM530o1pCEU5Gz7B6X54CdC5ViFpFmoqSgZzrJVUypYjmi+QMsip5p RVJ3IKgznzj8F30K8KKhuMg= X-Google-Smtp-Source: ABdhPJyqzMYmJv7+YC6fIUFr0DLw7ne5V1xvD/3AheCOymxXwONczk9HXcZoCzmw03frYFQO64dxOA== X-Received: by 2002:a2e:5750:: with SMTP id r16mr7150233ljd.61.1607281374626; Sun, 06 Dec 2020 11:02:54 -0800 (PST) Received: from saturn.localdomain ([2a00:fd00:8060:1c00:c1c3:bbc6:3ac5:732d]) by smtp.gmail.com with ESMTPSA id v28sm2483865ljv.29.2020.12.06.11.02.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 06 Dec 2020 11:02:54 -0800 (PST) From: Sam Ravnborg To: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, Lee Jones Subject: [PATCH v3 0/13] drivers/video: W=1 warning fixes Date: Sun, 6 Dec 2020 20:02:34 +0100 Message-Id: <20201206190247.1861316-1-sam@ravnborg.org> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201206_140259_300166_C19EE69E X-CRM114-Status: GOOD ( 19.12 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rich Felker , Kuninori Morimoto , Peter Zijlstra , Daniel Vetter , Gustavo A R Silva , Andrzej Hajda , Peter Jones , Sam Ravnborg , Geert Uytterhoeven , Michael Ellerman , Thomas Zimmermann , Arnd Bergmann , Bartlomiej Zolnierkiewicz , Thomas Winischhofer , linux-arm-kernel@lists.infradead.org, Qilong Zhang , Randy Dunlap , Douglas Anderson , Tony Prisk , Thierry Reding , Alexander Klimov , Colin Ian King , Andrew Morton , Mike Rapoport Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Following the great work of Lee Jones in other subsystems here is a set of patches that address all remaining W=1 warnings in drivers/video/. Lee Jones already fixed all warnings in video/backlight/ so this is mostly fbdev related fixes. The general approach used were: - Fix kernel-doc, this is often very trivial - Drop unused local variables Build tested on a set of architectures with various configs. The patches do not depend on each other and fixes for one driver are kept in a single patch. v2: - Updated subject of the patches to tell what was fixed (Lee) - Fixed build error in one patch (kernel test robot) - A few editorials updates to the changelog messages v3: - Applied patches that was acked - thanks Thomas! - Updated patches after feedback from Randy and Thomas - Added several new patches to cover warnings that triggers with other architectures than the one I used for v1 + v2 - Included one sh specific fix that handle a corner-case, let's see what the sh people say to that - One fix to previous set of patches to fix an issue reported by Coverity (By Colin) Sam Sam Ravnborg (13): video: fbdev: hgafb: Fix kernel-doc warnings video: fbdev: core: Fix kernel-doc warnings in fbmon + fb_notify video: fbdev: omapfb: Fix set but not used warnings in hdmi*_core video: fbdev: uvesafb: Fix set but not used warning sh: Fix set but not used warnings with !CONFIG_MMU video: fbdev: sparc drivers: fix kernel-doc warnings for blank_mode video: fbdev: mmp: Fix kernel-doc warning for lcd_spi_write video: fbdev: wmt_ge_rops: Fix function not declared warnings video: fbdev: goldfishfb: Fix defined but not used warning video: fbdev: gbefb: Fix set but not used warning video: fbdev: efifb: Fix set but not used warning for screen_pitch video: fbdev: controlfb: Fix set but not used warnings video: fbdev: sis: Drop useless call to SiS_GetResInfo() arch/sh/include/asm/io.h | 2 +- drivers/video/fbdev/bw2.c | 2 +- drivers/video/fbdev/cg3.c | 2 +- drivers/video/fbdev/cg6.c | 2 +- drivers/video/fbdev/controlfb.c | 4 ++-- drivers/video/fbdev/core/fb_notify.c | 10 ++++++++++ drivers/video/fbdev/core/fbmon.c | 2 +- drivers/video/fbdev/efifb.c | 3 +-- drivers/video/fbdev/ffb.c | 2 +- drivers/video/fbdev/gbefb.c | 4 +--- drivers/video/fbdev/goldfishfb.c | 2 ++ drivers/video/fbdev/hgafb.c | 10 +++++----- drivers/video/fbdev/leo.c | 2 +- drivers/video/fbdev/mmp/hw/mmp_spi.c | 2 +- drivers/video/fbdev/omap2/omapfb/dss/hdmi4_core.c | 4 ++-- drivers/video/fbdev/omap2/omapfb/dss/hdmi5_core.c | 4 ++-- drivers/video/fbdev/p9100.c | 2 +- drivers/video/fbdev/sis/init.c | 1 - drivers/video/fbdev/tcx.c | 2 +- drivers/video/fbdev/uvesafb.c | 2 ++ drivers/video/fbdev/wmt_ge_rops.c | 1 + 21 files changed, 38 insertions(+), 27 deletions(-)