From patchwork Fri Dec 11 22:24:44 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Doug Anderson X-Patchwork-Id: 11969577 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 58CC5C433FE for ; Fri, 11 Dec 2020 22:26:18 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EE82323A33 for ; Fri, 11 Dec 2020 22:26:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EE82323A33 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To:From: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=91X1fHKJp0hSoW0RsTDzpzIZ4xmaLPUnoI1wpvMBLao=; b=1NMy1I1YUx53oul6R6a8cTEZoM juLja6wX0MV+mO9MkJ4OGZHqpiAylOlg4O/pmp0wzuunq+a98qtCtioryDrFS4WDGKwW5YagPpuvw dwNndM9zQ9QG2Br1aMTx1Ga1+fA743IQPoYlMt9iXuGvmlq4QKercBz6mFc1LcO3i//Ki4ox4KH/X 85ju712spvqDldSbF/IiraD5gaN75X6DZb4XoBlMWIPp2thmRN5NYHV5q87pZMNUrkLaNnz2xE05m 5wn/FRCaP0ql82m56LF9E0MvABpg1klY2BjB1rePtVJ4foKTLX3uIpqRQrJ9Iw66fEX+f2+I3SUPJ UJQoTX7g==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1knqqU-0002W9-BG; Fri, 11 Dec 2020 22:25:02 +0000 Received: from mail-pg1-x543.google.com ([2607:f8b0:4864:20::543]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1knqqQ-0002Ud-QW for linux-arm-kernel@lists.infradead.org; Fri, 11 Dec 2020 22:25:00 +0000 Received: by mail-pg1-x543.google.com with SMTP id x24so2257526pgf.0 for ; Fri, 11 Dec 2020 14:24:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=aaHpOzVSojvNq1kaEb21BgS4v/5tZv/oDYr1cb6/VYk=; b=PhAxpjO7rK1sY5ytSqCdYeLOL3eWACAxxVNb1nqAgNJoJxcYWb7WuVVsYdnlHmrkpf NBgTpZUOi+Oii/3ttxBXHCXSrXCah0oi8h6GoJzkLd83rIi+KOgFdivgXx/Xvv0MSF2I A75z9xmBm8BrTDDeAl0U3fz0T9WKaY2gI4M6U= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=aaHpOzVSojvNq1kaEb21BgS4v/5tZv/oDYr1cb6/VYk=; b=QdVuualtSqPL57wSEjyJvvnQR/OW2w/QSqWUL4b4PG/cKAE0+To6cB2Ji7DD0Kdlsp fYGgU+zkcUSxL8mEhngg4GI3kKaKILdN3x7s2OlvCmCrTHalG3v0ShCBrmmLBFGxi3yH TS2FSuX/vznD7Mpa+SuNco6YluvTyA/GimZp6sCKifsFP03Y88XiY+p2gSvpMHEUByXK CMMjREJjJoCrX8MFFVaBw+0bTl897OfaV8/4wCM8YWoldDOduwF9b6/ZWnKpREWsC52S aGwVKfidWR+g+hq3OsPxliStHIfzqeKKdc1bWx46bSQgAPDtZ6Sqxz4nZ+tZZgtfMB4D JOAw== X-Gm-Message-State: AOAM532kBIRRBF+DD7MhVOV2FjNeHKQYM4OoyzGJMKXQmaivubAf69dI dZiH+EHmJk32uCQazPlb/SeKBw== X-Google-Smtp-Source: ABdhPJzaxyslnWOzuXRc4oTI5Ifx2lqquL+FqgB54QdHqRj5jfeI8LVI2K2roZLWzVWTOWpRtMjq2w== X-Received: by 2002:a63:f201:: with SMTP id v1mr14034360pgh.267.1607725496533; Fri, 11 Dec 2020 14:24:56 -0800 (PST) Received: from tictac2.mtv.corp.google.com ([2620:15c:202:1:42b0:34ff:fe3d:58e6]) by smtp.gmail.com with ESMTPSA id w70sm11669969pfd.65.2020.12.11.14.24.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Dec 2020 14:24:55 -0800 (PST) From: Douglas Anderson To: jkosina@suse.cz, benjamin.tissoires@redhat.com, gregkh@linuxfoundation.org, Dmitry Torokhov Subject: [PATCH v8 0/4] HID: i2c-hid: Reorganize to allow supporting goodix, gt7375p Date: Fri, 11 Dec 2020 14:24:44 -0800 Message-Id: <20201211222448.2115188-1-dianders@chromium.org> X-Mailer: git-send-email 2.29.2.576.ga3fc446d84-goog MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201211_172458_989270_58023BC8 X-CRM114-Status: GOOD ( 18.33 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Geert Uytterhoeven , Catalin Marinas , =?utf-8?q?Guido_G=C3=BCnther?= , Bjorn Andersson , kai.heng.feng@canonical.com, Will Deacon , Anson Huang , Masahiro Yamada , Michael Walle , linux-arm-kernel@lists.infradead.org, linux-input@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Jiri Kosina , swboyd@chromium.org, hdegoede@redhat.com, robh+dt@kernel.org, Daniel Playfair Cal , andrea@borgia.bo.it, Max Krummenacher , Douglas Anderson , Li Yang , Vinod Koul , Xiaofei Tan , Shawn Guo , Pavel Balan Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The goal of this series is to support the Goodix GT7375P touchscreen. This touchscreen is special because it has power sequencing requirements that necessitate driving a reset GPIO. To do this, we totally rejigger the way i2c-hid is organized so that it's easier to jam the Goodix support in there. This series was: - Tested on a device that uses normal i2c-hid. - Tested on a device that has a Goodix i2c-hid device. - Tested on an ACPI device, but an earlier version of the series. I believe the plan is for Benjamin to land the whole series. Will said this about the arm64 defconfig change (and provided his Ack): > ...there are a few things I really care about > in defconfig (e.g. things like page size!), generally speaking we don't > need to Ack everything that changes in there. > > That said, might be worth checking whether arm-soc have any defconfig > changes queued in -next so you don't end up with conflicts. Changes in v8: - Mark suspend/resume as static as per patches robot. Changes in v7: - Rebase atop commit afdd34c5fa40 ("HID: i2c-hid: show the error ...") Changes in v6: - ACPI probe function should have been "static" - Don't export suspend/resume, just export dev_pm_ops from core. - Fixed crash in ACPI module (missing init of "client") - No need for regulator include in the core. - Removed i2c_device_id table from ACPI module. - Suspend/resume are no longer exported from the core. Changes in v5: - Add shutdown_tail op and use it in ACPI. - Added mention of i2c-hid in the yaml itself as per Rob. - Adjusted subject as per Rob. - i2chid_subclass_data => i2chid_ops. - power_up_device => power_up (same with power_down). - subclass => ops. Changes in v4: - ("arm64: defconfig: Update config names for i2c-hid rejigger") new for v4. - Fully rejigger so ACPI and OF are full subclasses. - Totally redid based on the new subclass system. Changes in v3: - Fixed compatible in example. - Removed Benjamin as a maintainer. - Rework to use subclassing. - Updated description. Changes in v2: - ("dt-bindings: HID: i2c-hid: Introduce bindings for the Goodix GT7375P") new in v2. - Get timings based on the compatible string. - Use a separate compatible string for this new touchscreen. Douglas Anderson (4): HID: i2c-hid: Reorganize so ACPI and OF are separate modules arm64: defconfig: Update config names for i2c-hid rejigger dt-bindings: input: HID: i2c-hid: Introduce bindings for the Goodix GT7375P HID: i2c-hid: Introduce goodix-i2c-hid using i2c-hid core .../bindings/input/goodix,gt7375p.yaml | 65 +++++ arch/arm64/configs/defconfig | 3 +- drivers/hid/Makefile | 2 +- drivers/hid/i2c-hid/Kconfig | 47 +++- drivers/hid/i2c-hid/Makefile | 6 +- drivers/hid/i2c-hid/i2c-hid-acpi.c | 159 +++++++++++ drivers/hid/i2c-hid/i2c-hid-core.c | 252 +++--------------- drivers/hid/i2c-hid/i2c-hid-of-goodix.c | 116 ++++++++ drivers/hid/i2c-hid/i2c-hid-of.c | 143 ++++++++++ drivers/hid/i2c-hid/i2c-hid.h | 22 ++ include/linux/platform_data/i2c-hid.h | 41 --- 11 files changed, 594 insertions(+), 262 deletions(-) create mode 100644 Documentation/devicetree/bindings/input/goodix,gt7375p.yaml create mode 100644 drivers/hid/i2c-hid/i2c-hid-acpi.c create mode 100644 drivers/hid/i2c-hid/i2c-hid-of-goodix.c create mode 100644 drivers/hid/i2c-hid/i2c-hid-of.c delete mode 100644 include/linux/platform_data/i2c-hid.h