From patchwork Thu Jan 14 15:23:18 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12019887 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 636D2C433E0 for ; Thu, 14 Jan 2021 15:24:46 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1D44323A5F for ; Thu, 14 Jan 2021 15:24:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1D44323A5F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To:From: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=7qR1QoqAGKjH8IjAim/xME0syJn6eWvAe/qJ4HgRFL0=; b=bl1yuK94YkelKA79LoOju6gvWj 9ElYfk8+GHpZxK9iJZKRSEyTqbIq/M3pxY0Awad/9zN+jAyw+x6dM3cRUsVuwHqqLlRAPeSa1ThQg Ip7Vq90KLXilOmK3BHpJlaBkS2ivUFBTUPBueYCPsLSswz1qfdD2+p73Lpj4yWfZr1ftrYwOfQGbX X3hKfswW3exjvMYeffOoR4J5MVP1EIZlJVrSVA0LHRs5eYvbuJ2cLlhcdGpn9M25OWK9maRrd2GGS ZBRv+fdpAIpOyylNjojwL4aqvX2hV1saebkkrnTUVn7okjbsHCHC5CVDzftBu9syjJiePQ++yGkbU Gx8qltsg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l04TI-0000tB-U7; Thu, 14 Jan 2021 15:23:36 +0000 Received: from mail-wm1-x32e.google.com ([2a00:1450:4864:20::32e]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l04TF-0000sg-MZ for linux-arm-kernel@lists.infradead.org; Thu, 14 Jan 2021 15:23:34 +0000 Received: by mail-wm1-x32e.google.com with SMTP id g10so5032621wmh.2 for ; Thu, 14 Jan 2021 07:23:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=LUR3ZC5J+1hLkR7qz5X75neLOSs5yFqeDGs5AO9qOw4=; b=LWGlRpsZ+c5J5N8fxZQxQAtRsePbal/MHQsI00818w2JQRVWkSwZfq4KGRZpl5qQkS cmUin/BmDApKu0+yaK/yZKP+4GpIg+m1J3cUGHIGmhy7zBQf6lDT7cHaPzXUx3m5d7nh hsfV+fAjLuZlK4DVOrbY53QYJFJBfyzJ4eJ89TVmoD5Gex4jCGr5mEIT3l4Wx2xS+ub6 crLMVAZao1Bt1oxaQ9kFAonzeBN+svgQ1kpFWLKQxM8WWiD2PWL8jXWhM0OhQZ3ypx37 H4rO9JO7eNksW+7X3SvoCCDcdb3xvdwD3ZuNvEkxQLqeTWXAzIgdMJpUlE4jJc6y2b0a Flsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=LUR3ZC5J+1hLkR7qz5X75neLOSs5yFqeDGs5AO9qOw4=; b=WHOELpqFX9cXuSvkHBhvk/VZJ7MojVIJ5wt0ICqF2AD5XhoLQcNv+8O59CIvwAwYu6 Rlne9zsQC54mjmOhwKQZTdQ8mhEU2yxd7MzeyvHBigX6Cf5s2V+FfX85whiDIDgzAeeC pIWD/I1QSHMp2fRUooSJtzs+ZEwGNlMn/FBnghPXjY8HmhzAkdTqz/ZKvghhlFu8sgWy jgxmzrX05iszBLD6NjYN1the25m7YF0w+3OiINjEOqIVCAB5S1X1cDCa3KOJvH4er+Om o09PKBjBCPQZmkQQrvpFvRk+iqWWrjcdslJhEd7PTlH1Zwbx7bJAZBiv4Qh2gK/aFThK gfqw== X-Gm-Message-State: AOAM530BFMvrOASURFHDUuI8QBxf5niBslUKS4qvze4yAx091rYgRxzn QCsaelPeSTltnIkvUO7KZ7gcXA== X-Google-Smtp-Source: ABdhPJyDPR5SpV4A1P0OFN9rFKTQ2+PGovbF0AbXTJxJljKfJFFIiV44I8Zw/NaDinFku3qBrxZwkQ== X-Received: by 2002:a05:600c:313:: with SMTP id q19mr4402221wmd.126.1610637812260; Thu, 14 Jan 2021 07:23:32 -0800 (PST) Received: from dell.default ([91.110.221.178]) by smtp.gmail.com with ESMTPSA id e15sm10777713wrx.86.2021.01.14.07.23.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Jan 2021 07:23:31 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH v3 0/5] (Set 2/2) Rid W=1 issues from Input Date: Thu, 14 Jan 2021 15:23:18 +0000 Message-Id: <20210114152323.2382283-1-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210114_102334_014353_5A32DDB9 X-CRM114-Status: GOOD ( 12.43 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Henrik Rydberg , "C. Scott Ananian" , Luotao Fu , Peter Osterlund , Bruce Kalk , Dmitry Torokhov , Stefan Riedmueller , linux-kernel@vger.kernel.org, Stefan Gmeiner , Alexandre Torgue , Sangwon Jee , linux-arm-kernel@lists.infradead.org, Maxime Coquelin , linux-input@vger.kernel.org, James Hilliard , linux-stm32@st-md-mailman.stormreply.com, Benjamin Tissoires , Daniel Ritz Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org This set is part of a larger effort attempting to clean-up W=1 kernel builds, which are currently overwhelmingly riddled with niggly little warnings. This is the second (and last) of 2 sets. v3: - Make use of 'ret' instead of removing it - Use __always_unused instead of removing unused variables - Fix recent/new warning regarding undocumented 'prop' param v2: - Replace empty if() with commentary - Suggested-by: Joe Perches Lee Jones (5): input: mouse: synaptics: Replace NOOP with suitable commentary input: touchscreen: melfas_mip4: Mark a bunch of variables as __always_unused input: touchscreen: usbtouchscreen: Actually check return value of usb_submit_urb() input: touchscreen: surface3_spi: Remove set but unused variable 'timestamp' input: touchscreen: stmpe-ts: Add description for 'prop' struct member drivers/input/mouse/synaptics.c | 7 +++++-- drivers/input/touchscreen/melfas_mip4.c | 8 ++++---- drivers/input/touchscreen/stmpe-ts.c | 1 + drivers/input/touchscreen/surface3_spi.c | 2 -- drivers/input/touchscreen/usbtouchscreen.c | 3 +++ 5 files changed, 13 insertions(+), 8 deletions(-) Cc: Alexandre Torgue Cc: Benjamin Tissoires Cc: Bruce Kalk Cc: "C. Scott Ananian" Cc: Daniel Ritz Cc: Dmitry Torokhov Cc: Henrik Rydberg Cc: James Hilliard Cc: linux-arm-kernel@lists.infradead.org Cc: linux-input@vger.kernel.org Cc: linux-stm32@st-md-mailman.stormreply.com Cc: Luotao Fu Cc: Maxime Coquelin Cc: Peter Osterlund Cc: Sangwon Jee Cc: Stefan Gmeiner Cc: Stefan Riedmueller Cc: this to