From patchwork Thu Feb 4 18:47:05 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?Jernej_=C5=A0krabec?= X-Patchwork-Id: 12068383 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9CBBFC433E0 for ; Thu, 4 Feb 2021 18:49:44 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5023964DD6 for ; Thu, 4 Feb 2021 18:49:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5023964DD6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=siol.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To:From: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=W9CnSFX0ZA+csHzcma0ES1QZV/AM40Vw53cPM5P0lTA=; b=YuTfhczts4E0AcWInwsDFxobID k+4/qmx5yVpJl+D0mKMFdQ/dnkuXj44V7sMl0U8Tedc3VvfbnRweg6YpKMDykhxgaJ0/KIR95kjp0 4Z3fGEJ3kTjREDuOBDn3debHpKpTGzTiQ9cilag4KwtsxtafnSPD9MuWT3A0gTl/SekBb1/JAl/+V IRTpn02/zVrBKJJ4rVWiUB3uiFzqpz3CEcR3ngrkVITXsJSUAsBBhKNH6d5HWOUmgt5ksN7vfe5+R eUYEXmkDRZCcN8htOFV8b/gK35RiJj1vqvqN4Z68opl3KMP1H0AIIIBdCSNMteoJW6QnDD/l3fHS4 //CwXNOA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l7jg5-0004Q1-7U; Thu, 04 Feb 2021 18:48:29 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l7jg2-0004PM-QN for linux-arm-kernel@merlin.infradead.org; Thu, 04 Feb 2021 18:48:26 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:MIME-Version: Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:In-Reply-To:References; bh=Gak1fHyFP8eBDj1H5ooHi1nufpwIs8RioUJ6J9YokuE=; b=tZq0BAlbaQnuaO8Cdghu8rv1TU qLzIM71lv4OWw3BffW4qJGosD/UGODDYpgtc3RWcd66h6nwC5wAywBkv2EKtuzOUhtQ2AjS/I1A2z UGnBUp5ewss5Ic1v8kMKbPsbYXeVYDXkpFjIN0Yy1NmMOa8MvUcA/6ReV9EcZ4mHKDoIOUKnBI98D PDLK9PJBSBMAqEPyknxRe7sr8+K40pxeoW+wSsYqcDF6VmXbhB1ydnASMC4yQWCSgCvpcebuYomeR +YRzFhtTSXlVueRub06eb4NggNdW5d829oZPNbS/Le+HUh5VKg9c0kAu77hVekwIG4L77KQOU4v0B 9ZTpY6LQ==; Received: from mailoutvs2.siol.net ([185.57.226.193] helo=mail.siol.net) by casper.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1l7jg0-001Gux-JY for linux-arm-kernel@lists.infradead.org; Thu, 04 Feb 2021 18:48:25 +0000 Received: from localhost (localhost [127.0.0.1]) by mail.siol.net (Postfix) with ESMTP id E017F523FAF; Thu, 4 Feb 2021 19:48:11 +0100 (CET) X-Virus-Scanned: amavisd-new at psrvmta11.zcs-production.pri Received: from mail.siol.net ([127.0.0.1]) by localhost (psrvmta11.zcs-production.pri [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id Jkndiio0b4pd; Thu, 4 Feb 2021 19:48:11 +0100 (CET) Received: from mail.siol.net (localhost [127.0.0.1]) by mail.siol.net (Postfix) with ESMTPS id 97FE0523FBF; Thu, 4 Feb 2021 19:48:11 +0100 (CET) Received: from kista.localdomain (cpe-86-58-58-53.static.triera.net [86.58.58.53]) (Authenticated sender: 031275009) by mail.siol.net (Postfix) with ESMTPSA id 9F790523FAF; Thu, 4 Feb 2021 19:48:10 +0100 (CET) From: Jernej Skrabec To: mripard@kernel.org, wens@csie.org Subject: [PATCH 0/5] sunxi: fix H6 HDMI related issues Date: Thu, 4 Feb 2021 19:47:05 +0100 Message-Id: <20210204184710.1880895-1-jernej.skrabec@siol.net> X-Mailer: git-send-email 2.30.0 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210204_184825_233102_B6505B34 X-CRM114-Status: UNSURE ( 9.13 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: sboyd@kernel.org, mturquette@baylibre.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, airlied@linux.ie, linux-sunxi@googlegroups.com, daniel@ffwll.ch, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Over the year I got plenty of reports of troubles with H6 HDMI signal. Sometimes monitor flickers, sometimes there was no image at all and sometimes it didn't play well with AVR. It turns out there are multiple issues. Patch 1 fixes clock issue, which didn't adjust parent rate, even if it is allowed to do so. Patch 2 adds polarity config in tcon1. This is seemingly not needed for pre-HDMI2 controllers, although BSP drivers set it accordingly every time. It turns out that HDMI2 controllers often don't work with monitors if polarity is not set correctly. Patch 3 always set clock rate for HDMI controller. Patch 4 fixes cpce PHY setting for 594 MHz. Patch 5 fixes comment and clock rate limit (wrong reasoning). Please take a look. Best regards, Jernej Jernej Skrabec (5): clk: sunxi-ng: mp: fix parent rate change flag check drm/sun4i: tcon: set sync polarity for tcon1 channel drm/sun4i: dw-hdmi: always set clock rate drm/sun4i: Fix H6 HDMI PHY configuration drm/sun4i: dw-hdmi: Fix max. frequency for H6 drivers/clk/sunxi-ng/ccu_mp.c | 2 +- drivers/gpu/drm/sun4i/sun4i_tcon.c | 24 ++++++++++++++++++++++++ drivers/gpu/drm/sun4i/sun4i_tcon.h | 5 +++++ drivers/gpu/drm/sun4i/sun8i_dw_hdmi.c | 10 +++------- drivers/gpu/drm/sun4i/sun8i_dw_hdmi.h | 1 - drivers/gpu/drm/sun4i/sun8i_hdmi_phy.c | 2 +- 6 files changed, 34 insertions(+), 10 deletions(-)