| Message ID | 20210210111020.2476369-1-heiko@sntech.de (mailing list archive) |
|---|---|
| Headers | show |
| Series | Support second Image Signal Processor on rk3399 | expand |
Am Mittwoch, 10. Februar 2021, 12:10:14 CET schrieb Heiko Stuebner: > The rk3399 has two ISPs and right now only the first one is usable. > The second ISP is connected to the TXRX dphy on the soc. > > The phy of ISP1 is only accessible through the DSI controller's > io-memory, so this series adds support for simply using the dsi > controller is a phy if needed. > > That solution is needed at least on rk3399 and rk3288 but no-one > has looked at camera support on rk3288 at all, so right now > only implement the rk3399 specifics. > > changes in v2: > - enable grf-clock also for init callback > to not break if for example hdmi is connected on boot > and disabled the grf clock during its probe > - add Sebastian's Tested-by > - add Rob's Ack for the phy-cells property > > Heiko Stuebner (6): > drm/rockchip: dsi: add own additional pclk handling > dt-bindings: display: rockchip-dsi: add optional #phy-cells property > drm/rockchip: dsi: add ability to work as a phy instead of full dsi > arm64: dts: rockchip: add #phy-cells to mipi-dsi1 > arm64: dts: rockchip: add cif clk-control pinctrl for rk3399 > arm64: dts: rockchip: add isp1 node on rk3399 of course everything was meant to be v2 in the subject. Heiko
Hey Heiko, I have tested your series and it successfully fixes the problem with the 2nd camera when HDMI is connected at boot. Besides that the patch looks good and my tests have confirmed that both cameras have the same output quality when I exchange the connected ISP instances. Tested-by: Sebastian Fricke <sebastian.fricke@posteo.net> Greetings, Sebastian On 10.02.2021 12:10, Heiko Stuebner wrote: >The rk3399 has two ISPs and right now only the first one is usable. >The second ISP is connected to the TXRX dphy on the soc. > >The phy of ISP1 is only accessible through the DSI controller's >io-memory, so this series adds support for simply using the dsi >controller is a phy if needed. > >That solution is needed at least on rk3399 and rk3288 but no-one >has looked at camera support on rk3288 at all, so right now >only implement the rk3399 specifics. > >changes in v2: >- enable grf-clock also for init callback > to not break if for example hdmi is connected on boot > and disabled the grf clock during its probe >- add Sebastian's Tested-by >- add Rob's Ack for the phy-cells property > >Heiko Stuebner (6): > drm/rockchip: dsi: add own additional pclk handling > dt-bindings: display: rockchip-dsi: add optional #phy-cells property > drm/rockchip: dsi: add ability to work as a phy instead of full dsi > arm64: dts: rockchip: add #phy-cells to mipi-dsi1 > arm64: dts: rockchip: add cif clk-control pinctrl for rk3399 > arm64: dts: rockchip: add isp1 node on rk3399 > > .../display/rockchip/dw_mipi_dsi_rockchip.txt | 1 + > arch/arm64/boot/dts/rockchip/rk3399.dtsi | 39 ++ > drivers/gpu/drm/rockchip/Kconfig | 2 + > .../gpu/drm/rockchip/dw-mipi-dsi-rockchip.c | 349 ++++++++++++++++++ > 4 files changed, 391 insertions(+) > >-- >2.29.2 >
Am Mittwoch, 10. Februar 2021, 12:10:14 CEST schrieb Heiko Stuebner: > The rk3399 has two ISPs and right now only the first one is usable. > The second ISP is connected to the TXRX dphy on the soc. > > The phy of ISP1 is only accessible through the DSI controller's > io-memory, so this series adds support for simply using the dsi > controller is a phy if needed. > > That solution is needed at least on rk3399 and rk3288 but no-one > has looked at camera support on rk3288 at all, so right now > only implement the rk3399 specifics. > > changes in v2: > - enable grf-clock also for init callback > to not break if for example hdmi is connected on boot > and disabled the grf clock during its probe > - add Sebastian's Tested-by > - add Rob's Ack for the phy-cells property finally found the time and applied patches 1-3 to drmmisc-next after fixing the alphabetical kconfig ordering Helen pointed out and also applied patches 4-6 to my rockchip tree for 5.15 > > Heiko Stuebner (6): > drm/rockchip: dsi: add own additional pclk handling > dt-bindings: display: rockchip-dsi: add optional #phy-cells property > drm/rockchip: dsi: add ability to work as a phy instead of full dsi > arm64: dts: rockchip: add #phy-cells to mipi-dsi1 > arm64: dts: rockchip: add cif clk-control pinctrl for rk3399 > arm64: dts: rockchip: add isp1 node on rk3399 > > .../display/rockchip/dw_mipi_dsi_rockchip.txt | 1 + > arch/arm64/boot/dts/rockchip/rk3399.dtsi | 39 ++ > drivers/gpu/drm/rockchip/Kconfig | 2 + > .../gpu/drm/rockchip/dw-mipi-dsi-rockchip.c | 349 ++++++++++++++++++ > 4 files changed, 391 insertions(+) > >