From patchwork Wed Mar 24 02:04:31 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Boyd X-Patchwork-Id: 12160051 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA4F9C433E0 for ; Wed, 24 Mar 2021 02:06:44 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5B63C619FB for ; Wed, 24 Mar 2021 02:06:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5B63C619FB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc:To:From: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=84evpKJEa7HyBHWnumXa+jlCP/ClmMUYFGX7CcOpvWc=; b=q9PgEeGIl1ZWEaavuhkxzemZUr F+yPzCXxesiGtCjyYurY8LFFiIOatrBEH5uWBAiNvgzgADJVKTOqXYHByrn2dOGwohSsOU+Dh7Bum 6GQp9EqQnGFraEhIFWgYGKRLqDRCEWr9XGdGUx3TyW0qb6TF9ZraE8Jr7dpS+5bRv001igh0GOqQI 7YDhe8MlyEOaj+lOIAHqbrkQK/nzFBEqNqL/vHNB8Mki4/TTAhTXAkhju798HTxG4C3VAKMydSoPO thsgMtDkTu5bsbNHksGgwHgR2p9RCCrT18s+6Cl7zjr8xZnxAexibEx3kJC9MTkIjH3BkQUAIFlq+ oK0A4Jug==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lOstC-00G7KT-NI; Wed, 24 Mar 2021 02:04:54 +0000 Received: from mail-pl1-x629.google.com ([2607:f8b0:4864:20::629]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lOst6-00G7JP-W4 for linux-arm-kernel@lists.infradead.org; Wed, 24 Mar 2021 02:04:52 +0000 Received: by mail-pl1-x629.google.com with SMTP id f17so7103912plr.0 for ; Tue, 23 Mar 2021 19:04:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=Shg+pgFuqhjKojct4aONdGKbwTLLBsXFzdCZNx164CE=; b=JAJr9yVLg1fiPzovDztNPVAmjhjuii4QZhY89wWXGVQRdUTMAsHxXgZgCCTSQEsHav G0WyP+V3chnrD9yN08cb8Lu6MID1kBkac6fStR9+EPVyV7jNX50aKP+v2D0fSd5QK7nm IE3ugOM1VPSXUyZJu2eHyC5n9JPexlosu09cY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=Shg+pgFuqhjKojct4aONdGKbwTLLBsXFzdCZNx164CE=; b=CEg32CjcNazc5cfTmxy1zjA7jUwlzUIZHjTbeEEQexyFgemQgyIbP8ENPyfIDbuC8u 6eBSbU2WCvzStN5jYlRxMAAy3t0qSNABa174PY/fGWqmVIWLyUpZbUOKRjvv0wbBCadQ yzAouYC99e3HXxLN+hOdeX9lxFAIVAZL/S1Z9TSQskaHTzJ7kDsfgCllXZqohiVquFkA WwccRAVFNhJmwVBwr8UB/P8QXC362+6HRZRNEg3hMuDAVB95l6gFKcyY7VHWiMWSbaKZ qTjnBQJsm9+FcIU/95aDPSeb6xiXJ8CH1ImOPig4dJZHoTzuMs86XC0xYRkaFBEUDEHR X9gA== X-Gm-Message-State: AOAM533Fsrd3T4Z7vl9X9F2m+EuMY9OSL3RMpWXawU8kR7cRldL1a4i7 7i2zrJyTKYcUs0O1WlnIQ583uA== X-Google-Smtp-Source: ABdhPJw8dEnE2SAhUg10lugEgqBR+5D+RTT5DQxMWes32or039A/eCJK++QprrTJR/6Id5mfKJOW1A== X-Received: by 2002:a17:90a:9f8c:: with SMTP id o12mr906781pjp.215.1616551486577; Tue, 23 Mar 2021 19:04:46 -0700 (PDT) Received: from smtp.gmail.com ([2620:15c:202:201:84ac:62f7:16a8:ccc7]) by smtp.gmail.com with ESMTPSA id b3sm389441pjg.41.2021.03.23.19.04.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Mar 2021 19:04:46 -0700 (PDT) From: Stephen Boyd To: Andrew Morton Cc: linux-kernel@vger.kernel.org, Alexei Starovoitov , Andy Shevchenko , Baoquan He , Borislav Petkov , Catalin Marinas , Dave Young , Evan Green , Hsin-Yi Wang , Ingo Molnar , Jessica Yu , Jiri Olsa , kexec@lists.infradead.org, Konstantin Khlebnikov , linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, Matthew Wilcox , Petr Mladek , Rasmus Villemoes , Sasha Levin , Sergey Senozhatsky , Steven Rostedt , Thomas Gleixner , Vivek Goyal , Will Deacon , x86@kernel.org Subject: [PATCH v2 00/12] Add build ID to stacktraces Date: Tue, 23 Mar 2021 19:04:31 -0700 Message-Id: <20210324020443.1815557-1-swboyd@chromium.org> X-Mailer: git-send-email 2.31.0.291.g576ba9dcdaf-goog MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210324_020449_682976_FA5AC5C2 X-CRM114-Status: GOOD ( 22.50 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org This series adds the kernel's build ID[1] to the stacktrace header printed in oops messages, warnings, etc. and the build ID for any module that appears in the stacktrace after the module name. The goal is to make the stacktrace more self-contained and descriptive by including the relevant build IDs in the kernel logs when something goes wrong. This can be used by post processing tools like script/decode_stacktrace.sh and kernel developers to easily locate the debug info associated with a kernel crash and line up what line and file things started falling apart at. To show how this can be used I've included a patch to decode_stacktrace.sh that downloads the debuginfo from a debuginfod server. This also includes some patches to make the buildid.c file use more const arguments and consolidate logic into buildid.c from kdump. These are left to the end as they were mostly cleanup patches. I don't know who exactly maintains this so I guess Andrew is the best option to merge all this code. Here's an example lkdtm stacktrace on arm64. WARNING: CPU: 4 PID: 3255 at drivers/misc/lkdtm/bugs.c:83 lkdtm_WARNING+0x28/0x30 [lkdtm] Modules linked in: lkdtm rfcomm algif_hash algif_skcipher af_alg xt_cgroup uinput xt_MASQUERADE CPU: 4 PID: 3255 Comm: bash Not tainted 5.11 #3 aa23f7a1231c229de205662d5a9e0d4c580f19a1 Hardware name: Google Lazor (rev3+) with KB Backlight (DT) pstate: 00400009 (nzcv daif +PAN -UAO -TCO BTYPE=--) pc : lkdtm_WARNING+0x28/0x30 [lkdtm] lr : lkdtm_do_action+0x24/0x40 [lkdtm] sp : ffffffc0134fbca0 x29: ffffffc0134fbca0 x28: ffffff92d53ba240 x27: 0000000000000000 x26: 0000000000000000 x25: 0000000000000000 x24: ffffffe3622352c0 x23: 0000000000000020 x22: ffffffe362233366 x21: ffffffe3622352e0 x20: ffffffc0134fbde0 x19: 0000000000000008 x18: 0000000000000000 x17: ffffff929b6536fc x16: 0000000000000000 x15: 0000000000000000 x14: 0000000000000012 x13: ffffffe380ed892c x12: ffffffe381d05068 x11: 0000000000000000 x10: 0000000000000000 x9 : 0000000000000001 x8 : ffffffe362237000 x7 : aaaaaaaaaaaaaaaa x6 : 0000000000000000 x5 : 0000000000000000 x4 : 0000000000000001 x3 : 0000000000000008 x2 : ffffff93fef25a70 x1 : ffffff93fef15788 x0 : ffffffe3622352e0 Call trace: lkdtm_WARNING+0x28/0x30 [lkdtm ed5019fdf5e53be37cb1ba7899292d7e143b259e] direct_entry+0x16c/0x1b4 [lkdtm ed5019fdf5e53be37cb1ba7899292d7e143b259e] full_proxy_write+0x74/0xa4 vfs_write+0xec/0x2e8 ksys_write+0x84/0xf0 __arm64_sys_write+0x24/0x30 el0_svc_common+0xf4/0x1c0 do_el0_svc_compat+0x28/0x3c el0_svc_compat+0x10/0x1c el0_sync_compat_handler+0xa8/0xcc el0_sync_compat+0x178/0x180 ---[ end trace 3d95032303e59e68 ]--- Changes from v1 (https://lore.kernel.org/r/20210301174749.1269154-1-swboyd@chromium.org): * New printk format %pSb and %pSr * Return binary format instead of hex format string from build ID APIs * Some new patches to cleanup buildid/decode_stacktrace.sh * A new patch to decode_stacktrace.sh to parse output [1] https://fedoraproject.org/wiki/Releases/FeatureBuildId Cc: Alexei Starovoitov Cc: Andy Shevchenko Cc: Baoquan He Cc: Borislav Petkov Cc: Catalin Marinas Cc: Dave Young Cc: Evan Green Cc: Hsin-Yi Wang Cc: Ingo Molnar Cc: Jessica Yu Cc: Jiri Olsa Cc: Cc: Konstantin Khlebnikov Cc: Cc: Cc: Cc: Matthew Wilcox Cc: Petr Mladek Cc: Rasmus Villemoes Cc: Sasha Levin Cc: Sergey Senozhatsky Cc: Steven Rostedt Cc: Thomas Gleixner Cc: Vivek Goyal Cc: Will Deacon Cc: Stephen Boyd (12): buildid: Add API to parse build ID out of buffer buildid: Add method to get running kernel's build ID dump_stack: Add vmlinux build ID to stack traces module: Add printk format to add module build ID to stacktraces arm64: stacktrace: Use %pSb for backtrace printing x86/dumpstack: Use %pSb for backtrace printing scripts/decode_stacktrace.sh: Support debuginfod scripts/decode_stacktrace.sh: Silence stderr messages from addr2line/nm scripts/decode_stacktrace.sh: Indicate 'auto' can be used for base path buildid: Mark some arguments const buildid: Fix kernel-doc notation kdump: Use vmlinux_build_id() to simplify Documentation/core-api/printk-formats.rst | 9 +++ arch/arm64/kernel/stacktrace.c | 2 +- arch/x86/kernel/dumpstack.c | 4 +- include/linux/buildid.h | 3 + include/linux/crash_core.h | 6 +- include/linux/kallsyms.h | 13 +++- include/linux/module.h | 6 +- kernel/crash_core.c | 41 +---------- kernel/kallsyms.c | 73 ++++++++++++++----- kernel/module.c | 24 +++++- lib/buildid.c | 75 +++++++++++++++---- lib/dump_stack.c | 5 +- lib/vsprintf.c | 6 +- scripts/decode_stacktrace.sh | 89 +++++++++++++++++++---- 14 files changed, 251 insertions(+), 105 deletions(-) base-commit: a38fd8748464831584a19438cbb3082b5a2dab15