From patchwork Tue Mar 30 17:43:15 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Bjorn Helgaas X-Patchwork-Id: 12173435 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EEB4FC433C1 for ; Tue, 30 Mar 2021 17:44:59 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 748336198A for ; Tue, 30 Mar 2021 17:44:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 748336198A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc:To:From: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=nNycciocjvYNGe1WZUIihzFqkbO2qkAt79V4UauB7xs=; b=pKTIz7kycRCBtpVrsiS9nY4die 8eggWFP+dnMk6CdB6oqPzmH7qrDTCnZWYVnuuWbiv54Qhp8MxbH+438LnPAZPkM82Y//o/Y7eANxW vHklj+5webJHGBeglGfET8mbXLZK8ewLqmBMwrudGMBFG01n2MP7xz6ac3Z62ho6YKSRz99GzgY7X AGnFbPk22G1koEmaKu0onDxh5K3mzPcVQ9Xytzg9tP2eGge6nhejLOvI/rMIE6fzXfyxKQ87It9Ba qFU4HFIiQrpjItDHwKNiwxTijMD3BWwhnPfQt/PGJ8kMKpsqNia66tO2df/fFqKNxPgkiJd0U+v3M tD5x+6FA==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lRIOq-004U6R-5L; Tue, 30 Mar 2021 17:43:33 +0000 Received: from mail.kernel.org ([198.145.29.99]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lRIOj-004U41-Nv for linux-arm-kernel@lists.infradead.org; Tue, 30 Mar 2021 17:43:27 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 5B02461864; Tue, 30 Mar 2021 17:43:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1617126202; bh=uYaW/QH+iAL6DZPnWmQKFiyh6Yn3jj88Y9rk5M4PDI8=; h=From:To:Cc:Subject:Date:From; b=KY4NiuirAgvvcw9rU/I4HctuKyILN0nc84NHEluvNhqgbaJdqtC8zmqpUdBHOSEW0 0Zvxpr5oFYZJNlqLJB9IkCEoTfRLKnd4LPFFvM1GyD3eRCMrbZunZyPkMx9xr+uG/u FN+it0rz/R6PKJOch/GPzIOrF322E/MjpSy9T3sd+XN6kn8i5TVSyN5MupoTnEsmos oGKG5TgemCns8Y0bcJAGNmt7aO/JFCJT7vPBUIkoOhRDpndlwL4N2KvzgEjrAOHBMp jrcCb/o/5sXqMGJ5XpB8tXWQDbE3Ioc+byun+ZzuvxRDrNEFsHVPp5EjNKEfUKjFaL CxuREO80YaIGw== From: Bjorn Helgaas To: Heiner Kallweit Cc: Leon Romanovsky , Russell King - ARM Linux , David Miller , Jakub Kicinski , nic_swsd@realtek.com, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org, Bjorn Helgaas Subject: [PATCH v4 0/3] PCI: Disable parity checking Date: Tue, 30 Mar 2021 12:43:15 -0500 Message-Id: <20210330174318.1289680-1-helgaas@kernel.org> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210330_184326_069241_80618EE3 X-CRM114-Status: GOOD ( 11.06 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Bjorn Helgaas I think this is essentially the same as Heiner's v3 posting, with these changes: - Added a pci_disable_parity() interface in pci.c instead of making a public pci_quirk_broken_parity() because quirks.c is only compiled when CONFIG_PCI_QUIRKS=y. - Removed the setting of dev->broken_parity_status because it's really only used by EDAC error reporting, and if we disable parity error reporting, we shouldn't get there. This change will be visible in the sysfs "broken_parity_status" file, but I doubt that's important. I dropped Leon's reviewed-by because I fiddled with the code. Similarly I haven't added your signed-off-by, Heiner, because I don't want you blamed for my errors. But if this looks OK to you I'll add it. v1: https://lore.kernel.org/r/a6f09e1b-4076-59d1-a4e3-05c5955bfff2@gmail.com v2: https://lore.kernel.org/r/bbc33d9b-af7c-8910-cdb3-fa3e3b2e3266@gmail.com - reduce scope of N2100 change to using the new PCI core quirk v3: https://lore.kernel.org/r/992c800e-2e12-16b0-4845-6311b295d932@gmail.com/ - improve commit message of patch 2 v4: - add pci_disable_parity() (not conditional on CONFIG_PCI_QUIRKS) - remove setting of dev->broken_parity_status Bjorn Helgaas (1): PCI: Add pci_disable_parity() Heiner Kallweit (2): IB/mthca: Disable parity reporting ARM: iop32x: disable N2100 PCI parity reporting arch/arm/mach-iop32x/n2100.c | 8 ++++---- drivers/net/ethernet/realtek/r8169_main.c | 14 -------------- drivers/pci/pci.c | 17 +++++++++++++++++ drivers/pci/quirks.c | 13 ++++--------- include/linux/pci.h | 1 + 5 files changed, 26 insertions(+), 27 deletions(-) Reviewed-by: Krzysztof Wilczyński