From patchwork Tue Apr 6 10:47:59 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nicolas Saenz Julienne X-Patchwork-Id: 12184823 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0FED4C433B4 for ; Tue, 6 Apr 2021 10:50:49 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id ACB68610C8 for ; Tue, 6 Apr 2021 10:50:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org ACB68610C8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc:To:From: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=dzTe8sIwFH2H6sInWIzV9PwdDuKrDv+d5xaYsgj/t80=; b=p2wudQx6u12f+8uav7GNCQoSxq HdcmGTtFh+l1baJIl/4Em2dNUGJgJalmAO7PPNqCESHnGzH8NJ8rwyJR8KORRHUGStEqvSM+i3IzW 8SymEZYTqjqHz5p+xZQ+GGIdV6U02vxJFjW6pu770eFafgZfLbk5YwpiaXMymsxKd20ZyEoin0OSY W7A+EaD280Isk1GE/E6KRZfPl9QZlQ1vBM5IrDWeLa6b2DxuJsi9EyHENQSnwgXOY0H/eVh+3hMnY 04LYOugqXtyr+cfMH3cFdBgJW89Qg0QnLMpo1jsEijs2jBFROt7AABREcd+esV62cMQYS5dglecdC sLkP0Zkw==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lTjGA-002DMC-7H; Tue, 06 Apr 2021 10:48:38 +0000 Received: from mail.kernel.org ([198.145.29.99]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lTjG6-002DLQ-78; Tue, 06 Apr 2021 10:48:36 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id C1462610C8; Tue, 6 Apr 2021 10:48:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1617706111; bh=vlNBewdohdDRf3gdIEX3K46W8EM1S5JbaoVBGjDPwWE=; h=From:To:Cc:Subject:Date:From; b=i1qH07UyELWf92Khy38ECphN7Zmcx/9KhplNkkhghDmpSTkHlhnyiNSDaQW/zZ/ZP 1EhV7vvqpn41B547r71kQtdO5YvBIajmxKNYerHRXdzmGwEIm1i/3ioDqkMw9weUid NLUnf3/YjwuKq1AC7ZgZgf35E0QJcsE4z1hAA+TuzjZ8FI05PQGAjxVhJMb9z4TfFK IbTxq5I7K65MzzEyzjF3GOBW0Nr5v5NBLckWg6RDNXdG1GaL/wsMZlYVseSpy95+IC I6jBhH0ICj1wQ4bzIXwTFBe03anlgSwKap+Z3gKdFyBaldWvAxbxLxKsLQv/522/dU u20V5KphTgm+w== From: Nicolas Saenz Julienne To: linux-arm-kernel@lists.infradead.org, linux-mmc@vger.kernel.org, devicetree@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, linux-rpi-kernel@lists.infradead.org, Ray Jui , Scott Branden , Saenz Julienne , Ulf Hansson , Stefan Wahren , Matthias Brugger Cc: f.fainelli@gmail.com, phil@raspberrypi.com, tim.gover@raspberrypi.com, adrian.hunter@intel.com, sbranden@broadcom.com, alcooperx@gmail.com, nsaenzjulienne@suse.de, linux-kernel@vger.kernel.org, robh@kernel.org, stefan.wahren@i2se.com Subject: [PATCH 0/3] BCM2711 sdhci-iproc improvements Date: Tue, 6 Apr 2021 12:47:59 +0200 Message-Id: <20210406104802.20898-1-nsaenz@kernel.org> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210406_114834_517570_F36906F0 X-CRM114-Status: UNSURE ( 7.75 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org This is a follow-up series to "BCM2711's sdhci-iproc CMD timeouts"[1], but since much most of the patches changed I decided to start counting patch revisions from scratch. This series tries to address rather odd behavior from BCM2711's integration of sdhci-iproc (Raspberry Pi 4's SoC). The controller will timeout on SDHCI CMDs under the following conditions: - No SD card plugged in (the card polling thread is running, CD irq disabled). - BCM2711's VPU clock configured at 500MHz or more, lower clocks are OK. There is no specific command that will time out, it seems random. As an extra to this I also include a small fix, and convert the controller's bindings to yaml. Regards, Nicolas [1] https://lore.kernel.org/linux-mmc/20210322185816.27582-1-nsaenz@kernel.org/ --- Nicolas Saenz Julienne (3): dt-bindings: mmc: iproc-sdhci: Convert to json-schema mmc: sdhci-iproc: Cap min clock frequency on BCM2711 mmc: sdhci-iproc: Set SDHCI_QUIRK_CAP_CLOCK_BASE_BROKEN on BCM2711 .../bindings/mmc/brcm,iproc-sdhci.yaml | 63 +++++++++++++++++++ .../bindings/mmc/brcm,sdhci-iproc.txt | 37 ----------- drivers/mmc/host/sdhci-iproc.c | 21 ++++++- 3 files changed, 83 insertions(+), 38 deletions(-) create mode 100644 Documentation/devicetree/bindings/mmc/brcm,iproc-sdhci.yaml delete mode 100644 Documentation/devicetree/bindings/mmc/brcm,sdhci-iproc.txt