mbox series

[PATCHv5,0/6] PCI: layerscape: Add power management support

Message ID 20210407030948.3845-1-Zhiqiang.Hou@nxp.com (mailing list archive)
Headers show
Series PCI: layerscape: Add power management support | expand

Message

Z.Q. Hou April 7, 2021, 3:09 a.m. UTC
From: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>

This patch series is to add PCIe power management support for NXP
Layerscape platforms.

Hou Zhiqiang (6):
  PCI: layerscape: Change to use the DWC common link-up check function
  dt-bindings: pci: layerscape-pci: Add a optional property big-endian
  arm64: dts: layerscape: Add big-endian property for PCIe nodes
  dt-bindings: pci: layerscape-pci: Update the description of SCFG
    property
  arm64: dts: ls1043a: Add SCFG phandle for PCIe nodes
  PCI: layerscape: Add power management support

 .../bindings/pci/layerscape-pci.txt           |   6 +-
 .../arm64/boot/dts/freescale/fsl-ls1012a.dtsi |   1 +
 .../arm64/boot/dts/freescale/fsl-ls1043a.dtsi |   6 +
 .../arm64/boot/dts/freescale/fsl-ls1046a.dtsi |   3 +
 drivers/pci/controller/dwc/pci-layerscape.c   | 450 ++++++++++++++----
 drivers/pci/controller/dwc/pcie-designware.h  |   1 +
 6 files changed, 370 insertions(+), 97 deletions(-)

Comments

Leo Li Nov. 11, 2021, 9:21 p.m. UTC | #1
On Wed, Apr 7, 2021 at 9:13 AM Zhiqiang Hou <Zhiqiang.Hou@nxp.com> wrote:
>
> From: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>
>
> This patch series is to add PCIe power management support for NXP
> Layerscape platforms.
>
> Hou Zhiqiang (6):
>   PCI: layerscape: Change to use the DWC common link-up check function
>   dt-bindings: pci: layerscape-pci: Add a optional property big-endian
>   arm64: dts: layerscape: Add big-endian property for PCIe nodes
>   dt-bindings: pci: layerscape-pci: Update the description of SCFG
>     property
>   arm64: dts: ls1043a: Add SCFG phandle for PCIe nodes
>   PCI: layerscape: Add power management support
>
>  .../bindings/pci/layerscape-pci.txt           |   6 +-
>  .../arm64/boot/dts/freescale/fsl-ls1012a.dtsi |   1 +
>  .../arm64/boot/dts/freescale/fsl-ls1043a.dtsi |   6 +
>  .../arm64/boot/dts/freescale/fsl-ls1046a.dtsi |   3 +
>  drivers/pci/controller/dwc/pci-layerscape.c   | 450 ++++++++++++++----
>  drivers/pci/controller/dwc/pcie-designware.h  |   1 +
>  6 files changed, 370 insertions(+), 97 deletions(-)

Hi Bjorn,

I don't see any feedback on this version.  Is there any chance that
the binding/driver changes can be picked up?

Regards,
Leo
Bjorn Helgaas Nov. 11, 2021, 9:44 p.m. UTC | #2
On Thu, Nov 11, 2021 at 03:21:37PM -0600, Li Yang wrote:
> On Wed, Apr 7, 2021 at 9:13 AM Zhiqiang Hou <Zhiqiang.Hou@nxp.com> wrote:
> >
> > From: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>
> >
> > This patch series is to add PCIe power management support for NXP
> > Layerscape platforms.
> >
> > Hou Zhiqiang (6):
> >   PCI: layerscape: Change to use the DWC common link-up check function
> >   dt-bindings: pci: layerscape-pci: Add a optional property big-endian
> >   arm64: dts: layerscape: Add big-endian property for PCIe nodes
> >   dt-bindings: pci: layerscape-pci: Update the description of SCFG
> >     property
> >   arm64: dts: ls1043a: Add SCFG phandle for PCIe nodes
> >   PCI: layerscape: Add power management support
> >
> >  .../bindings/pci/layerscape-pci.txt           |   6 +-
> >  .../arm64/boot/dts/freescale/fsl-ls1012a.dtsi |   1 +
> >  .../arm64/boot/dts/freescale/fsl-ls1043a.dtsi |   6 +
> >  .../arm64/boot/dts/freescale/fsl-ls1046a.dtsi |   3 +
> >  drivers/pci/controller/dwc/pci-layerscape.c   | 450 ++++++++++++++----
> >  drivers/pci/controller/dwc/pcie-designware.h  |   1 +
> >  6 files changed, 370 insertions(+), 97 deletions(-)
> 
> Hi Bjorn,
> 
> I don't see any feedback on this version.  Is there any chance that
> the binding/driver changes can be picked up?

Probably slipped through the cracks.  We're in the middle of the v5.16
merge window right now.  After v5.16-rc1 is tagged (probably Nov 14),
rebase your series on top of that, incorporate Rob's reviewed-by, and
repost it.  Then Lorenzo will see it and take a look.

Bjorn
Leo Li Nov. 16, 2021, 11:52 p.m. UTC | #3
> -----Original Message-----
> From: Bjorn Helgaas <helgaas@kernel.org>
> Sent: Thursday, November 11, 2021 3:45 PM
> To: Leo Li <leoyang.li@nxp.com>
> Cc: Z.Q. Hou <zhiqiang.hou@nxp.com>; linux-pci@vger.kernel.org; open
> list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS
> <devicetree@vger.kernel.org>; lkml <linux-kernel@vger.kernel.org>;
> moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE <linux-arm-
> kernel@lists.infradead.org>; Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>;
> Rob Herring <robh+dt@kernel.org>; Bjorn Helgaas <bhelgaas@google.com>;
> Shawn Guo <shawnguo@kernel.org>; gustavo.pimentel@synopsys.com;
> M.H. Lian <minghuan.lian@nxp.com>; Mingkai Hu <mingkai.hu@nxp.com>;
> Roy Zang <roy.zang@nxp.com>
> Subject: Re: [PATCHv5 0/6] PCI: layerscape: Add power management support
> 
> On Thu, Nov 11, 2021 at 03:21:37PM -0600, Li Yang wrote:
> > On Wed, Apr 7, 2021 at 9:13 AM Zhiqiang Hou <Zhiqiang.Hou@nxp.com>
> wrote:
> > >
> > > From: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>
> > >
> > > This patch series is to add PCIe power management support for NXP
> > > Layerscape platforms.
> > >
> > > Hou Zhiqiang (6):
> > >   PCI: layerscape: Change to use the DWC common link-up check function
> > >   dt-bindings: pci: layerscape-pci: Add a optional property big-endian
> > >   arm64: dts: layerscape: Add big-endian property for PCIe nodes
> > >   dt-bindings: pci: layerscape-pci: Update the description of SCFG
> > >     property
> > >   arm64: dts: ls1043a: Add SCFG phandle for PCIe nodes
> > >   PCI: layerscape: Add power management support
> > >
> > >  .../bindings/pci/layerscape-pci.txt           |   6 +-
> > >  .../arm64/boot/dts/freescale/fsl-ls1012a.dtsi |   1 +
> > >  .../arm64/boot/dts/freescale/fsl-ls1043a.dtsi |   6 +
> > >  .../arm64/boot/dts/freescale/fsl-ls1046a.dtsi |   3 +
> > >  drivers/pci/controller/dwc/pci-layerscape.c   | 450 ++++++++++++++----
> > >  drivers/pci/controller/dwc/pcie-designware.h  |   1 +
> > >  6 files changed, 370 insertions(+), 97 deletions(-)
> >
> > Hi Bjorn,
> >
> > I don't see any feedback on this version.  Is there any chance that
> > the binding/driver changes can be picked up?
> 
> Probably slipped through the cracks.  We're in the middle of the v5.16 merge
> window right now.  After v5.16-rc1 is tagged (probably Nov 14), rebase your
> series on top of that, incorporate Rob's reviewed-by, and repost it.  Then
> Lorenzo will see it and take a look.

Thanks Bjorn,

While we waiting for the repost and review for the driver change, the dt-binding
updates seems to be unrelated to the driver changes.  So probably they can be
applied separately to make the dts changes mergeable?

Regards,
Leo