From patchwork Thu Apr 8 18:28:25 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sami Tolvanen X-Patchwork-Id: 12192085 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D81DBC433ED for ; Thu, 8 Apr 2021 18:31:16 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0DFC1610FC for ; Thu, 8 Apr 2021 18:31:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0DFC1610FC Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Cc:To:From:Subject:Mime-Version:Message-Id:Date: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=KsOy3gdntUl5FIZgWVVpjQJL5g/DhuS31wJpQ7fh298=; b=ZhEuwu9s0qSgPZkWnzBTgsyBQy HYHcY9lXutvy2fLwcxxY42i4XPaXgVKMRMzOFT/xJO/IE61IXfkAQcAIrn/Fuy+G1AaY711RNGL8o rkEY4VBsWOU5Uy2pfSrjBmBaS7nk1oMQJNpt8rGmEd8ARfhC7ePd4kvsIq+d84aUJqGEqXli7YgLd TMMB7j0qgr8CDHYH0CrA7zj2Wuqr35+CKyTKDwwHOZ1wESHiq9xmaOnZDPs4Xj3BDKvfh/ldyeDBb FiIC6QpJhanzJLlaiqTl0SPHEJUbFTAiAmkr4v7iD5oOtdgIgNgai+DQ08KgTvDW7Zm23Ndf24SWr o6LzTf8g==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lUZOg-008uh7-Jw; Thu, 08 Apr 2021 18:28:54 +0000 Received: from mail-yb1-xb49.google.com ([2607:f8b0:4864:20::b49]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lUZOb-008ueX-5C for linux-arm-kernel@lists.infradead.org; Thu, 08 Apr 2021 18:28:51 +0000 Received: by mail-yb1-xb49.google.com with SMTP id z39so2799366ybh.23 for ; Thu, 08 Apr 2021 11:28:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:message-id:mime-version:subject:from:to:cc; bh=hFbfrV6NLQcaUFBI7qoKubPMd6hwVRmqL95jk4+jyxc=; b=JBj3h6xqwlztdZoD9Dqpfp7Alwo8u054FoOK8zma9pkGeWTeuATHhjoaZNawNS9+V6 Tb0dfg5qd67tmw3R8nLEKrnIYOWChn0hf/JHJSKf1HDGlH5u4FFW0wRgpWmyLSvt4ajs 5NMl9F0QfJzNd/l72+LsejYvM3DXrFq4dHIUFzx2BzuMfxcENkc+lXht5+iKIHiJQ9jO 5Hv8ezegeHjGE0ZRU2sZBv0I3I9xLvPzXRtinDBJ/SSxL2hsoHBwdVVGqnvIdCCslKLV FjLUh4sBAuzykaGDJG7ZoK2ZyXcz8dON+CCNISz/BBMbMLgM2CAMTit3atSJCz7eDK7b N/3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:message-id:mime-version:subject:from:to:cc; bh=hFbfrV6NLQcaUFBI7qoKubPMd6hwVRmqL95jk4+jyxc=; b=MxEOiLxnnYdW/tX+Cf5U4Adzidl90YGpXswpy/g2ftUSHnHOyYUjdEqRDx4qTXTYdU 6ETplNsdaerdEnjrwhEI6BhgZvDDGLNromgCMMo9vNn+ZkW1YOEMSJyKt2xzBhrveFjh jOWIEIQjOCyiMGdEz8lAg6bUTPPNuipZqVK2UHgIS1B1SJ1/9I4tl++LK26EU6f5U3yF 077mAxLldeFVS1jX1vSN9orvoJA3Y/4N4oAR7db0EcYFlwlaDWVTkaGc2peadeOnRJ54 tHpklndUNG5wd8itGFa6wvcv32HTvjUczUh9JEbhqv8IAK9r+NgIM+gOwY883uZPfXFS OrUw== X-Gm-Message-State: AOAM533eXvrrOd+c8260RXmJe6s2Giji4sKknaMJKkJlj4kDId1bsKJS kSe2irIEQE60xnEt3wphWcV+7zdoqnSy02F4yME= X-Google-Smtp-Source: ABdhPJzp417bGfyY56r6I/HGmGdmkcvMSkgwww5nAXRa8l4TGBMnYYcrRloFTGcs6uh2r5JE+hqZHf9jDTXST4AD3dM= X-Received: from samitolvanen1.mtv.corp.google.com ([2620:15c:201:2:3560:8505:40a2:e021]) (user=samitolvanen job=sendgmr) by 2002:a25:31d5:: with SMTP id x204mr13666827ybx.3.1617906525373; Thu, 08 Apr 2021 11:28:45 -0700 (PDT) Date: Thu, 8 Apr 2021 11:28:25 -0700 Message-Id: <20210408182843.1754385-1-samitolvanen@google.com> Mime-Version: 1.0 X-Mailer: git-send-email 2.31.1.295.g9ea45b61b8-goog Subject: [PATCH v6 00/18] Add support for Clang CFI From: Sami Tolvanen To: Kees Cook Cc: Nathan Chancellor , Nick Desaulniers , Masahiro Yamada , Will Deacon , Jessica Yu , Arnd Bergmann , Tejun Heo , "Paul E. McKenney" , Christoph Hellwig , Peter Zijlstra , Sedat Dilek , Mark Rutland , Catalin Marinas , bpf@vger.kernel.org, linux-hardening@vger.kernel.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kbuild@vger.kernel.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com, Sami Tolvanen X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210408_192849_257998_903BBD96 X-CRM114-Status: GOOD ( 21.03 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org This series adds support for Clang's Control-Flow Integrity (CFI) checking. With CFI, the compiler injects a runtime check before each indirect function call to ensure the target is a valid function with the correct static type. This restricts possible call targets and makes it more difficult for an attacker to exploit bugs that allow the modification of stored function pointers. For more details, see: https://clang.llvm.org/docs/ControlFlowIntegrity.html The first patch contains build system changes and error handling, and implements support for cross-module indirect call checking. The remaining patches address issues caused by the compiler instrumentation. These include fixing known type mismatches, as well as issues with address space confusion and cross-module function address equality. These patches add support only for arm64, but I'll post patches also for x86_64 after we address the remaining issues there, including objtool support. You can also pull this series from https://github.com/samitolvanen/linux.git cfi-v6 --- Changes in v6: - Added temporary variables and moved assembly constraints to a separate line based on Mark's suggestions. Changes in v5: - Changed module.lds.S to only include when CFI is enabled to fix the MIPS build. - Added a patch that fixes dynamic ftrace with CFI on arm64. Changes in v4: - Per Mark's suggestion, dropped __pa_function() and renamed __va_function() to function_nocfi(). - Added a comment to function_nocfi() to explain what it does. - Updated the psci patch to use an intermediate variable for the physical address for clarity. Changes in v3: - Added a patch to change list_sort() callers treewide to use const pointers instead of simply removing the internal casts. - Changed cleanup_symbol_name() to return bool. - Changed module.lds.S to drop the .eh_frame section only with CONFIG_CFI_CLANG. - Switched to synchronize_rcu() in update_shadow(). Changes in v2: - Fixed .text merging in module.lds.S. - Added WARN_ON_FUNCTION_MISMATCH() and changed kernel/thread.c and kernel/workqueue.c to use the macro instead. Sami Tolvanen (18): add support for Clang CFI cfi: add __cficanonical mm: add generic function_nocfi macro module: ensure __cfi_check alignment workqueue: use WARN_ON_FUNCTION_MISMATCH kthread: use WARN_ON_FUNCTION_MISMATCH kallsyms: strip ThinLTO hashes from static functions bpf: disable CFI in dispatcher functions treewide: Change list_sort to use const pointers lkdtm: use function_nocfi psci: use function_nocfi for cpu_resume arm64: implement function_nocfi arm64: use function_nocfi with __pa_symbol arm64: add __nocfi to functions that jump to a physical address arm64: add __nocfi to __apply_alternatives arm64: ftrace: use function_nocfi for ftrace_call KVM: arm64: Disable CFI for nVHE arm64: allow CONFIG_CFI_CLANG to be selected Makefile | 17 + arch/Kconfig | 45 +++ arch/arm64/Kconfig | 1 + arch/arm64/include/asm/memory.h | 16 + arch/arm64/include/asm/mmu_context.h | 4 +- arch/arm64/kernel/acpi_parking_protocol.c | 3 +- arch/arm64/kernel/alternative.c | 4 +- arch/arm64/kernel/cpu-reset.h | 10 +- arch/arm64/kernel/cpufeature.c | 4 +- arch/arm64/kernel/ftrace.c | 2 +- arch/arm64/kernel/psci.c | 3 +- arch/arm64/kernel/smp_spin_table.c | 3 +- arch/arm64/kvm/hyp/nvhe/Makefile | 6 +- arch/arm64/kvm/vgic/vgic-its.c | 8 +- arch/arm64/kvm/vgic/vgic.c | 3 +- block/blk-mq-sched.c | 3 +- block/blk-mq.c | 3 +- drivers/acpi/nfit/core.c | 3 +- drivers/acpi/numa/hmat.c | 3 +- drivers/clk/keystone/sci-clk.c | 4 +- drivers/firmware/psci/psci.c | 7 +- drivers/gpu/drm/drm_modes.c | 3 +- drivers/gpu/drm/i915/gt/intel_engine_user.c | 3 +- drivers/gpu/drm/i915/gvt/debugfs.c | 2 +- drivers/gpu/drm/i915/selftests/i915_gem_gtt.c | 3 +- drivers/gpu/drm/radeon/radeon_cs.c | 4 +- .../hw/usnic/usnic_uiom_interval_tree.c | 3 +- drivers/interconnect/qcom/bcm-voter.c | 2 +- drivers/md/raid5.c | 3 +- drivers/misc/lkdtm/usercopy.c | 2 +- drivers/misc/sram.c | 4 +- drivers/nvme/host/core.c | 3 +- .../controller/cadence/pcie-cadence-host.c | 3 +- drivers/spi/spi-loopback-test.c | 3 +- fs/btrfs/raid56.c | 3 +- fs/btrfs/tree-log.c | 3 +- fs/btrfs/volumes.c | 3 +- fs/ext4/fsmap.c | 4 +- fs/gfs2/glock.c | 3 +- fs/gfs2/log.c | 2 +- fs/gfs2/lops.c | 3 +- fs/iomap/buffered-io.c | 3 +- fs/ubifs/gc.c | 7 +- fs/ubifs/replay.c | 4 +- fs/xfs/scrub/bitmap.c | 4 +- fs/xfs/xfs_bmap_item.c | 4 +- fs/xfs/xfs_buf.c | 6 +- fs/xfs/xfs_extent_busy.c | 4 +- fs/xfs/xfs_extent_busy.h | 3 +- fs/xfs/xfs_extfree_item.c | 4 +- fs/xfs/xfs_refcount_item.c | 4 +- fs/xfs/xfs_rmap_item.c | 4 +- include/asm-generic/bug.h | 16 + include/asm-generic/vmlinux.lds.h | 20 +- include/linux/bpf.h | 4 +- include/linux/cfi.h | 41 +++ include/linux/compiler-clang.h | 3 + include/linux/compiler_types.h | 8 + include/linux/init.h | 6 +- include/linux/list_sort.h | 7 +- include/linux/mm.h | 10 + include/linux/module.h | 13 +- include/linux/pci.h | 4 +- init/Kconfig | 2 +- kernel/Makefile | 4 + kernel/cfi.c | 329 ++++++++++++++++++ kernel/kallsyms.c | 55 ++- kernel/kthread.c | 3 +- kernel/module.c | 43 +++ kernel/workqueue.c | 2 +- lib/list_sort.c | 17 +- lib/test_list_sort.c | 3 +- net/tipc/name_table.c | 4 +- scripts/Makefile.modfinal | 2 +- scripts/module.lds.S | 19 +- 75 files changed, 760 insertions(+), 113 deletions(-) create mode 100644 include/linux/cfi.h create mode 100644 kernel/cfi.c base-commit: e0a472fffe435af52ea4e21e1e0001c5c8ffc6c7