From patchwork Tue Apr 20 21:49:50 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Boyd X-Patchwork-Id: 12215081 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5FDC9C433B4 for ; Tue, 20 Apr 2021 21:52:39 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AE2C461413 for ; Tue, 20 Apr 2021 21:52:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AE2C461413 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc:To:From: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=UU9qqifyBu/u4OO32EBRkfvVitwypI2x746BpeUYe3g=; b=arJhBmck9eb81EZ9TTL1Z2ZyWW st5orOb1pZpJADWzH4s/pWwOpI1S6P7LYzL/bCjIMltB/2JCH681rlx/gjg8UP4bPrSnfrBweMYjb Vcq/etBrHNCRyD4iv8mFi+h6xQAn3VnX7AnHvcvQ9iXoRhcGZKXMVga4LkG9GTRsRGakskW8W7ENX lBtIaQfNiKR5kYJHMZJsJJdntbhP826zUUsZiaEOtOF5ApgFIHFCr7VuUPytqeVjOAFkR+PMjpHPz QGhOFzqPYDwjJP8AhehQbIn71d44V9c/DweAdOV/t4zA9rghK1nv0UHuyhwjcNBrYX4BLCmbc/tL8 ZTwVCBIQ==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lYyG8-00D7CX-V2; Tue, 20 Apr 2021 21:50:17 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lYyG0-00D7Au-SJ for linux-arm-kernel@desiato.infradead.org; Tue, 20 Apr 2021 21:50:09 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type: Content-ID:Content-Description:In-Reply-To:References; bh=v+Jw8/YJuN/18rAKwd1h571a5vSl/5Yqn8D9Rp7AdFs=; b=FGrZFVlSyqsy0l6YikychryYmg nus25MyYtHSVhnVUBwxbyoyjs1fMKsJR1G+9MTyA82Ox8Z42qLqcPzsCnOxLcCCShnBgG8Z6CC2AT IrIyv4yESxIw4l6x6kP9ZYFA+LtHISVtyvw0MDfsSMYPRtZSZKaOmFxEpFAybcBsoCHSD7v26Gqsg 3t+xII0HegeXM4IjJGjWERzgu0C1EcKdrL7ZoHQuApdVZsedCQNJkn+SAH9r22Dap36JKyKrbx1Tq 272llRdfHGBuZ+nd656hJPJ/TFCTf/DB7zYZmWVdSPGruUIwIz/fW9qxvYOc4zctjwCS3J2DN8BBO zIvYLmtA==; Received: from mail-pg1-x531.google.com ([2607:f8b0:4864:20::531]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lYyFx-00CRNt-P7 for linux-arm-kernel@lists.infradead.org; Tue, 20 Apr 2021 21:50:07 +0000 Received: by mail-pg1-x531.google.com with SMTP id t22so27762445pgu.0 for ; Tue, 20 Apr 2021 14:50:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=v+Jw8/YJuN/18rAKwd1h571a5vSl/5Yqn8D9Rp7AdFs=; b=U6lfFHNXlzomrCttIz8184NKddn9fWyExpC2yEutTyrXHNwTXzHvh3I7GOJC+wZIvl UDZeAjyTDXbvkJZWBPx6VqG5ac6Ko96dNOGvDkQ/VLzxbRYqtmZL4L+7ziYsxbZuDgKW CVPHz6WVcXE/36txOzyRxhknQXW3oy3KSqWAk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=v+Jw8/YJuN/18rAKwd1h571a5vSl/5Yqn8D9Rp7AdFs=; b=Mw82f4X70/XhY/Wd6QR/oI+hy1WdxT7h9E7eJTYgZA/tX7cjrRJA+CXofiAdVwv8Ro y9snBaXlKbeR96+U7RSKuBDjzwoYgiMKtaK6meTD6Ce3k2+aQx0oeSVobycsq7MBr9lu H1fiW3twqQeNoIzeGuNgeXSM6ePu+xC+PheAf/OUBBiymOxO6SpbonVo9t3u3worgiuQ J5nfOEKvk6VAlVkK5sTZpDzuyG/YZ9B5j+UKZLCdFjTUEgD8hQT9LsVu4NyAo4nCOEFJ PPHj3WGYtynp/ybdO3XQafcOcEZywI3Fpw3hULiqTt/35mMFHIDYinqezY6e4dz7ql8V JEiA== X-Gm-Message-State: AOAM531KZCfyYEdJeyxMVgAzQ2y4YwhGBXH2/wFVmz7tceP/DRAEt3pe YSHT09as8ALAjnJ5EefKC0EMkA== X-Google-Smtp-Source: ABdhPJx90W7A/PREnebtT3MHLcjeID5s+aAnkWqnCsoQz8AAxXX408qvmrPy92Zb4/TpeA3daetqdA== X-Received: by 2002:a17:90b:3681:: with SMTP id mj1mr7640962pjb.122.1618955404847; Tue, 20 Apr 2021 14:50:04 -0700 (PDT) Received: from smtp.gmail.com ([2620:15c:202:201:bf8b:4b8b:2315:3719]) by smtp.gmail.com with ESMTPSA id c21sm31481pfo.91.2021.04.20.14.50.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Apr 2021 14:50:04 -0700 (PDT) From: Stephen Boyd To: Andrew Morton Cc: linux-kernel@vger.kernel.org, Alexei Starovoitov , Andy Shevchenko , Baoquan He , Borislav Petkov , Catalin Marinas , Dave Young , Evan Green , Hsin-Yi Wang , Ingo Molnar , Jessica Yu , Jiri Olsa , kexec@lists.infradead.org, Konstantin Khlebnikov , linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, Matthew Wilcox , Petr Mladek , Rasmus Villemoes , Sasha Levin , Sergey Senozhatsky , Steven Rostedt , Thomas Gleixner , Vivek Goyal , Will Deacon , x86@kernel.org, Christoph Hellwig Subject: [PATCH v5 00/13] Add build ID to stacktraces Date: Tue, 20 Apr 2021 14:49:50 -0700 Message-Id: <20210420215003.3510247-1-swboyd@chromium.org> X-Mailer: git-send-email 2.31.1.368.gbe11c130af-goog MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210420_145005_887011_578E046C X-CRM114-Status: GOOD ( 24.83 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org This series adds the kernel's build ID[1] to the stacktrace header printed in oops messages, warnings, etc. and the build ID for any module that appears in the stacktrace after the module name. The goal is to make the stacktrace more self-contained and descriptive by including the relevant build IDs in the kernel logs when something goes wrong. This can be used by post processing tools like script/decode_stacktrace.sh and kernel developers to easily locate the debug info associated with a kernel crash and line up what line and file things started falling apart at. To show how this can be used I've included a patch to decode_stacktrace.sh that downloads the debuginfo from a debuginfod server. This also includes some patches to make the buildid.c file use more const arguments and consolidate logic into buildid.c from kdump. These are left to the end as they were mostly cleanup patches. I don't know who exactly maintains this so I guess Andrew is the best option to merge all this code. Here's an example lkdtm stacktrace on arm64. WARNING: CPU: 4 PID: 3255 at drivers/misc/lkdtm/bugs.c:83 lkdtm_WARNING+0x28/0x30 [lkdtm] Modules linked in: lkdtm rfcomm algif_hash algif_skcipher af_alg xt_cgroup uinput xt_MASQUERADE CPU: 4 PID: 3255 Comm: bash Not tainted 5.11 #3 aa23f7a1231c229de205662d5a9e0d4c580f19a1 Hardware name: Google Lazor (rev3+) with KB Backlight (DT) pstate: 00400009 (nzcv daif +PAN -UAO -TCO BTYPE=--) pc : lkdtm_WARNING+0x28/0x30 [lkdtm] lr : lkdtm_do_action+0x24/0x40 [lkdtm] sp : ffffffc0134fbca0 x29: ffffffc0134fbca0 x28: ffffff92d53ba240 x27: 0000000000000000 x26: 0000000000000000 x25: 0000000000000000 x24: ffffffe3622352c0 x23: 0000000000000020 x22: ffffffe362233366 x21: ffffffe3622352e0 x20: ffffffc0134fbde0 x19: 0000000000000008 x18: 0000000000000000 x17: ffffff929b6536fc x16: 0000000000000000 x15: 0000000000000000 x14: 0000000000000012 x13: ffffffe380ed892c x12: ffffffe381d05068 x11: 0000000000000000 x10: 0000000000000000 x9 : 0000000000000001 x8 : ffffffe362237000 x7 : aaaaaaaaaaaaaaaa x6 : 0000000000000000 x5 : 0000000000000000 x4 : 0000000000000001 x3 : 0000000000000008 x2 : ffffff93fef25a70 x1 : ffffff93fef15788 x0 : ffffffe3622352e0 Call trace: lkdtm_WARNING+0x28/0x30 [lkdtm ed5019fdf5e53be37cb1ba7899292d7e143b259e] direct_entry+0x16c/0x1b4 [lkdtm ed5019fdf5e53be37cb1ba7899292d7e143b259e] full_proxy_write+0x74/0xa4 vfs_write+0xec/0x2e8 ksys_write+0x84/0xf0 __arm64_sys_write+0x24/0x30 el0_svc_common+0xf4/0x1c0 do_el0_svc_compat+0x28/0x3c el0_svc_compat+0x10/0x1c el0_sync_compat_handler+0xa8/0xcc el0_sync_compat+0x178/0x180 ---[ end trace 3d95032303e59e68 ]--- Changes from v4 (https://lore.kernel.org/r/20210410015300.3764485-1-swboyd@chromium.org): * Stubbed out more code when CONFIG_STACKTRACE_BUILD_ID=n * Use static_assert instead of BUILD_BUG_ON() * Dropped bad printk change to IP on x86 Changes from v3 (https://lore.kernel.org/r/20210331030520.3816265-1-swboyd@chromium.org): * Fixed compilation warnings due to config changes * Fixed kernel-doc on init_vmlinx_build_id() * Totally removed add_build_id_vmcoreinfo() * Added another printk format %pBb to help x86 print backtraces * Some BUILD_BUG_ON() checks to make sure the buildid doesn't get bigger or smaller Changes from v2 (https://lore.kernel.org/r/20210324020443.1815557-1-swboyd@chromium.org): * Renamed symbol printing function to indicate build IDness * Put build ID information behind Kconfig knob * Build ID for vmlinux is calculated in early init instead of on demand * printk format is %pS[R]b Changes from v1 (https://lore.kernel.org/r/20210301174749.1269154-1-swboyd@chromium.org): * New printk format %pSb and %pSr * Return binary format instead of hex format string from build ID APIs * Some new patches to cleanup buildid/decode_stacktrace.sh * A new patch to decode_stacktrace.sh to parse output [1] https://fedoraproject.org/wiki/Releases/FeatureBuildId Cc: Alexei Starovoitov Cc: Andy Shevchenko Cc: Baoquan He Cc: Borislav Petkov Cc: Catalin Marinas Cc: Dave Young Cc: Evan Green Cc: Hsin-Yi Wang Cc: Ingo Molnar Cc: Jessica Yu Cc: Jiri Olsa Cc: Cc: Konstantin Khlebnikov Cc: Cc: Cc: Cc: Matthew Wilcox Cc: Petr Mladek Cc: Rasmus Villemoes Cc: Sasha Levin Cc: Sergey Senozhatsky Cc: Steven Rostedt Cc: Thomas Gleixner Cc: Vivek Goyal Cc: Will Deacon Cc: Cc: Christoph Hellwig Cc: peter enderborg