[v2,0/5] gpio: xilinx: convert to use bitmap API

Message

Andy Shevchenko May 10, 2021, 7:46 p.m. UTC

The change in the series has been inspired by [1], which, I think,
can be improved. Here I present the view how it may be done.

[1]: [e-mail]

In v2:
- folding followup fix into patch 4
- added Tested-by (Srinivas)
- added Ack (Yuri)
- added Rb (Michal)
- rebased on top of v5.13-rc1

Andy Shevchenko (5):
  bitmap: Make bitmap_remap() and bitmap_bitremap() available to users
  gpio: xilinx: Correct kernel doc for xgpio_probe()
  gpio: xilinx: Introduce xgpio_read_chan() / xgpio_write_chan()
  gpio: xilinx: Switch to use bitmap APIs
  gpio: xilinx: No need to disable IRQs in the handler

 drivers/gpio/gpio-xilinx.c | 385 +++++++++++++++++++------------------
 lib/bitmap.c               |   5 +-
 2 files changed, 198 insertions(+), 192 deletions(-)

Comments

Bartosz Golaszewski May 12, 2021, 11:55 a.m. UTC | #1

On Mon, May 10, 2021 at 9:46 PM Andy Shevchenko
<[e-mail]> wrote:
>
> The change in the series has been inspired by [1], which, I think,
> can be improved. Here I present the view how it may be done.
>
> [1]: [e-mail]
>
> In v2:
> - folding followup fix into patch 4
> - added Tested-by (Srinivas)
> - added Ack (Yuri)
> - added Rb (Michal)
> - rebased on top of v5.13-rc1
>
> Andy Shevchenko (5):
>   bitmap: Make bitmap_remap() and bitmap_bitremap() available to users
>   gpio: xilinx: Correct kernel doc for xgpio_probe()
>   gpio: xilinx: Introduce xgpio_read_chan() / xgpio_write_chan()
>   gpio: xilinx: Switch to use bitmap APIs
>   gpio: xilinx: No need to disable IRQs in the handler
>
>  drivers/gpio/gpio-xilinx.c | 385 +++++++++++++++++++------------------
>  lib/bitmap.c               |   5 +-
>  2 files changed, 198 insertions(+), 192 deletions(-)
>
> --
> 2.30.2
>

Series applied, thanks a lot!

Bartosz