mbox series

[0/2] Add ICSSG MDIO nodes on AM65x & J721E SoCs

Message ID 20210514224759.9987-1-s-anna@ti.com (mailing list archive)
Headers show
Series Add ICSSG MDIO nodes on AM65x & J721E SoCs | expand

Message

Suman Anna May 14, 2021, 10:47 p.m. UTC
Hi Nishanth,

The following series adds the base MDIO nodes representing the MDIO
sub-module present in each of the ICSSG subsystem. These build on
top of the foundation ICSSG nodes added in v5.13-rc1. Please see
the previous ICSSG foundation series for more details [1]. 

The MDIO nodes would only be used on boards wired for supporting
the ICSSG Ethernet, so in general are expected to be disabled in
all boards where they are not pinned out.

I have added these as "enabled" by default in the base dtsi files,
and have marked it disabled in all the existing board dts files
until we are ready to add in the ICSSG Ethernet functionality.

Note that the bus_freq property throws a warning with W=2, but this
had been a legacy property defined a long back. The davinci-mdio
binding continues to use this.

regards
Suman

[1] https://patchwork.kernel.org/project/linux-arm-kernel/cover/20210114194805.8231-1-s-anna@ti.com/

Roger Quadros (1):
  arm64: dts: ti: k3-am65-main: Add ICSSG MDIO nodes

Suman Anna (1):
  arm64: dts: ti: k3-j721e-main: Add ICSSG MDIO nodes

 .../boot/dts/ti/k3-am65-iot2050-common.dtsi   | 12 ++++++++
 arch/arm64/boot/dts/ti/k3-am65-main.dtsi      | 30 +++++++++++++++++++
 .../arm64/boot/dts/ti/k3-am654-base-board.dts | 12 ++++++++
 .../dts/ti/k3-j721e-common-proc-board.dts     |  8 +++++
 arch/arm64/boot/dts/ti/k3-j721e-main.dtsi     | 20 +++++++++++++
 5 files changed, 82 insertions(+)

Comments

Grygorii Strashko May 14, 2021, 10:58 p.m. UTC | #1
On 15/05/2021 01:47, Suman Anna wrote:
> Hi Nishanth,
> 
> The following series adds the base MDIO nodes representing the MDIO
> sub-module present in each of the ICSSG subsystem. These build on
> top of the foundation ICSSG nodes added in v5.13-rc1. Please see
> the previous ICSSG foundation series for more details [1].
> 
> The MDIO nodes would only be used on boards wired for supporting
> the ICSSG Ethernet, so in general are expected to be disabled in
> all boards where they are not pinned out.
> 
> I have added these as "enabled" by default in the base dtsi files,
> and have marked it disabled in all the existing board dts files
> until we are ready to add in the ICSSG Ethernet functionality.
> 
> Note that the bus_freq property throws a warning with W=2, but this
> had been a legacy property defined a long back. The davinci-mdio
> binding continues to use this.
> 
> regards
> Suman
> 
> [1] https://patchwork.kernel.org/project/linux-arm-kernel/cover/20210114194805.8231-1-s-anna@ti.com/
> 
> Roger Quadros (1):
>    arm64: dts: ti: k3-am65-main: Add ICSSG MDIO nodes
> 
> Suman Anna (1):
>    arm64: dts: ti: k3-j721e-main: Add ICSSG MDIO nodes
> 
>   .../boot/dts/ti/k3-am65-iot2050-common.dtsi   | 12 ++++++++
>   arch/arm64/boot/dts/ti/k3-am65-main.dtsi      | 30 +++++++++++++++++++
>   .../arm64/boot/dts/ti/k3-am654-base-board.dts | 12 ++++++++
>   .../dts/ti/k3-j721e-common-proc-board.dts     |  8 +++++
>   arch/arm64/boot/dts/ti/k3-j721e-main.dtsi     | 20 +++++++++++++
>   5 files changed, 82 insertions(+)
> 

Thank you.
Reviewed-by: Grygorii Strashko <grygorii.strashko@ti.com>
Nishanth Menon May 28, 2021, 6:24 p.m. UTC | #2
On 17:47-20210514, Suman Anna wrote:
> Hi Nishanth,
> 
> The following series adds the base MDIO nodes representing the MDIO
> sub-module present in each of the ICSSG subsystem. These build on
> top of the foundation ICSSG nodes added in v5.13-rc1. Please see
> the previous ICSSG foundation series for more details [1]. 
> 
> The MDIO nodes would only be used on boards wired for supporting
> the ICSSG Ethernet, so in general are expected to be disabled in
> all boards where they are not pinned out.
> 
> I have added these as "enabled" by default in the base dtsi files,
> and have marked it disabled in all the existing board dts files
> until we are ready to add in the ICSSG Ethernet functionality.
> 
> Note that the bus_freq property throws a warning with W=2, but this
> had been a legacy property defined a long back. The davinci-mdio
> binding continues to use this.
> 
> regards
> Suman
> 
> [1] https://patchwork.kernel.org/project/linux-arm-kernel/cover/20210114194805.8231-1-s-anna@ti.com/

Did you mean https://lore.kernel.org/linux-arm-kernel/20210304160712.8452-1-s-anna@ti.com/
the series we actually did pick up?

> 
> Roger Quadros (1):
>   arm64: dts: ti: k3-am65-main: Add ICSSG MDIO nodes
> 
> Suman Anna (1):
>   arm64: dts: ti: k3-j721e-main: Add ICSSG MDIO nodes
> 

OK, does'nt apply on my tree as I am picking up patches.. There are
new cleanups and nodes I have picked up, so could be conflicting with
those.

Please rebase and post based on:
https://git.kernel.org/pub/scm/linux/kernel/git/nmenon/linux.git/log/?h=ti-k3-dts-next

I'd suggest you do that on monday OR base on monday's linux-next tag for
the next post.
Suman Anna May 28, 2021, 6:29 p.m. UTC | #3
On 5/28/21 1:24 PM, Nishanth Menon wrote:
> On 17:47-20210514, Suman Anna wrote:
>> Hi Nishanth,
>>
>> The following series adds the base MDIO nodes representing the MDIO
>> sub-module present in each of the ICSSG subsystem. These build on
>> top of the foundation ICSSG nodes added in v5.13-rc1. Please see
>> the previous ICSSG foundation series for more details [1]. 
>>
>> The MDIO nodes would only be used on boards wired for supporting
>> the ICSSG Ethernet, so in general are expected to be disabled in
>> all boards where they are not pinned out.
>>
>> I have added these as "enabled" by default in the base dtsi files,
>> and have marked it disabled in all the existing board dts files
>> until we are ready to add in the ICSSG Ethernet functionality.
>>
>> Note that the bus_freq property throws a warning with W=2, but this
>> had been a legacy property defined a long back. The davinci-mdio
>> binding continues to use this.
>>
>> regards
>> Suman
>>
>> [1] https://patchwork.kernel.org/project/linux-arm-kernel/cover/20210114194805.8231-1-s-anna@ti.com/
> 
> Did you mean https://lore.kernel.org/linux-arm-kernel/20210304160712.8452-1-s-anna@ti.com/
> the series we actually did pick up?
> 

v2 is the series we picked up, but I meant to give the v1 cover-letter only for
the details portion. v2 cover-letter didn't have much details.


>>
>> Roger Quadros (1):
>>   arm64: dts: ti: k3-am65-main: Add ICSSG MDIO nodes
>>
>> Suman Anna (1):
>>   arm64: dts: ti: k3-j721e-main: Add ICSSG MDIO nodes
>>
> 
> OK, does'nt apply on my tree as I am picking up patches.. There are
> new cleanups and nodes I have picked up, so could be conflicting with
> those.
> 
> Please rebase and post based on:
> https://git.kernel.org/pub/scm/linux/kernel/git/nmenon/linux.git/log/?h=ti-k3-dts-next
> 
> I'd suggest you do that on monday OR base on monday's linux-next tag for
> the next post.
> 

Yeah ok.

regards
Suman