mbox series

[v4,0/7] wrappers for fpga_manager_ops

Message ID 20210625195148.837230-1-trix@redhat.com (mailing list archive)
Headers show
Series wrappers for fpga_manager_ops | expand

Message

Tom Rix June 25, 2021, 7:51 p.m. UTC
From: Tom Rix <trix@redhat.com>

As followup from
https://lore.kernel.org/linux-fpga/06301910-10a1-0e62-45a0-d28ab5a787ed@redhat.com/

Boards should not be required to have noop functions.
So improve or create fpga-mgr wrappers for the fpga_manager_ops.  
Remove the noop functions.
Refactor fpga-mgr to use the wrappers.

Changes from

v1:
  commit subject,log

v2:
  rebase to next-20210623

v3:
  remove mops check
  add write_sg wrapper
  drop 'fpga-mgr: collect wappers and change to inline'

Tom Rix (7):
  fpga-mgr: wrap the write_init() op
  fpga-mgr: make write_complete() op optional
  fpga-mgr: wrap the write() op
  fpga-mgr: wrap the status() op
  fpga-mgr: wrap the state() op
  fpga-mgr: wrap the fpga_remove() op
  fpga-mgr: wrap the write_sg() op

 drivers/fpga/dfl-fme-mgr.c   |   6 --
 drivers/fpga/fpga-mgr.c      | 111 +++++++++++++++++++++++------------
 drivers/fpga/stratix10-soc.c |   6 --
 drivers/fpga/ts73xx-fpga.c   |   6 --
 drivers/fpga/zynqmp-fpga.c   |   7 ---
 5 files changed, 75 insertions(+), 61 deletions(-)

Comments

Moritz Fischer July 18, 2021, 3:08 p.m. UTC | #1
On Fri, Jun 25, 2021 at 12:51:40PM -0700, trix@redhat.com wrote:
> From: Tom Rix <trix@redhat.com>
> 
> As followup from
> https://lore.kernel.org/linux-fpga/06301910-10a1-0e62-45a0-d28ab5a787ed@redhat.com/
> 
> Boards should not be required to have noop functions.
> So improve or create fpga-mgr wrappers for the fpga_manager_ops.  
> Remove the noop functions.
> Refactor fpga-mgr to use the wrappers.
> 
> Changes from
> 
> v1:
>   commit subject,log
> 
> v2:
>   rebase to next-20210623
> 
> v3:
>   remove mops check
>   add write_sg wrapper
>   drop 'fpga-mgr: collect wappers and change to inline'
> 
> Tom Rix (7):
>   fpga-mgr: wrap the write_init() op
>   fpga-mgr: make write_complete() op optional
>   fpga-mgr: wrap the write() op
>   fpga-mgr: wrap the status() op
>   fpga-mgr: wrap the state() op
>   fpga-mgr: wrap the fpga_remove() op
>   fpga-mgr: wrap the write_sg() op
> 
>  drivers/fpga/dfl-fme-mgr.c   |   6 --
>  drivers/fpga/fpga-mgr.c      | 111 +++++++++++++++++++++++------------
>  drivers/fpga/stratix10-soc.c |   6 --
>  drivers/fpga/ts73xx-fpga.c   |   6 --
>  drivers/fpga/zynqmp-fpga.c   |   7 ---
>  5 files changed, 75 insertions(+), 61 deletions(-)
> 
> -- 
> 2.26.3
> 

Appled to for-next,

Thanks