Message ID | 20210726101012.26983-1-a-govindraju@ti.com (mailing list archive) |
---|---|
Headers | show |
Series | CAN: Add support for CAN in AM65,J721e and AM64 | expand |
Hi Nishanth, On 26/07/21 3:40 pm, Aswath Govindraju wrote: > The following series of patches add support for CAN in SoC's AM65, J721e > and AM64. > > This patch series is dependent on [1] and [2] and I have requested for an > immutable tag from the Marc Kleine-Budde(maintainer of net tree). Here is the tag in [0] shared by Marc after applying patches [1] and [2], linux-can-next-for-5.15-20210725, [0] - https://git.kernel.org/pub/scm/linux/kernel/git/mkl/linux-can-next.git/log/?h=linux-can-next-for-5.15-20210725 Thanks, Aswath > > [1] - https://lore.kernel.org/patchwork/patch/1423048/ > [2] - https://www.spinics.net/lists/linux-can/msg08108.html > > changes since v1 - > - changed the message ram configuration to use the maximum value > in each field, for better performance. > > Aswath Govindraju (3): > arm64: dts: ti: am654-base-board: Disable mcan nodes > arm64: dts: ti: k3-am64-main: Add support for MCAN > arm64: dts: ti: k3-am642-evm/sk: Add support for main domain mcan > nodes in EVM and disable them on SK > > Faiz Abbas (3): > arm64: dts: ti: k3-am65-mcu: Add Support for MCAN > arm64: dts: ti: k3-j721e: Add support for MCAN nodes > arm64: dts: ti: k3-j721e-common-proc-board: Add support for mcu_mcan > nodes > > arch/arm64/boot/dts/ti/k3-am64-main.dtsi | 28 +++ > arch/arm64/boot/dts/ti/k3-am642-evm.dts | 40 ++++ > arch/arm64/boot/dts/ti/k3-am642-sk.dts | 8 + > arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi | 30 +++ > .../arm64/boot/dts/ti/k3-am654-base-board.dts | 8 + > .../dts/ti/k3-j721e-common-proc-board.dts | 116 +++++++++++ > arch/arm64/boot/dts/ti/k3-j721e-main.dtsi | 196 ++++++++++++++++++ > .../boot/dts/ti/k3-j721e-mcu-wakeup.dtsi | 28 +++ > 8 files changed, 454 insertions(+) >
On 28.07.2021 10:49:58, Aswath Govindraju wrote: > > The following series of patches add support for CAN in SoC's AM65, J721e > > and AM64. > > > > This patch series is dependent on [1] and [2] and I have requested for an > > immutable tag from the Marc Kleine-Budde(maintainer of net tree). I'm the maintainer of the "linux-can", not the "net" tree. > Here is the tag in [0] shared by Marc after applying patches [1] and > [2], linux-can-next-for-5.15-20210725, > > [0] - > https://git.kernel.org/pub/scm/linux/kernel/git/mkl/linux-can-next.git/log/?h=linux-can-next-for-5.15-20210725 That tag has been merged by David Miller into the net-next tree. https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/commit/?id=d20e5880fe9df149a9159673d9fec57aab43ac61 Marc
On 15:40-20210726, Aswath Govindraju wrote: > The following series of patches add support for CAN in SoC's AM65, J721e > and AM64. > > This patch series is dependent on [1] and [2] and I have requested for an > immutable tag from the Marc Kleine-Budde(maintainer of net tree). > > [1] - https://lore.kernel.org/patchwork/patch/1423048/ > [2] - https://www.spinics.net/lists/linux-can/msg08108.html > > changes since v1 - > - changed the message ram configuration to use the maximum value > in each field, for better performance. > > Aswath Govindraju (3): > arm64: dts: ti: am654-base-board: Disable mcan nodes > arm64: dts: ti: k3-am64-main: Add support for MCAN > arm64: dts: ti: k3-am642-evm/sk: Add support for main domain mcan > nodes in EVM and disable them on SK > > Faiz Abbas (3): > arm64: dts: ti: k3-am65-mcu: Add Support for MCAN > arm64: dts: ti: k3-j721e: Add support for MCAN nodes > arm64: dts: ti: k3-j721e-common-proc-board: Add support for mcu_mcan > nodes I noticed in my checkup: https://pastebin.ubuntu.com/p/zSk39M943N/ warnings with dtbs_check, I think the bindings need a little more help here (please also notice the iot platform warnings getting introduced). Since we are still working on the bindings[1], lets clean that up before we consider the dts addition. I suspect we need to cook this more towards the next cycle. [1] https://lore.kernel.org/patchwork/patch/1470806/
Hi, On 02/08/21 6:15 pm, Nishanth Menon wrote: > On 15:40-20210726, Aswath Govindraju wrote: >> The following series of patches add support for CAN in SoC's AM65, J721e >> and AM64. >> >> This patch series is dependent on [1] and [2] and I have requested for an >> immutable tag from the Marc Kleine-Budde(maintainer of net tree). >> >> [1] - https://lore.kernel.org/patchwork/patch/1423048/ >> [2] - https://www.spinics.net/lists/linux-can/msg08108.html >> >> changes since v1 - >> - changed the message ram configuration to use the maximum value >> in each field, for better performance. >> >> Aswath Govindraju (3): >> arm64: dts: ti: am654-base-board: Disable mcan nodes >> arm64: dts: ti: k3-am64-main: Add support for MCAN >> arm64: dts: ti: k3-am642-evm/sk: Add support for main domain mcan >> nodes in EVM and disable them on SK >> >> Faiz Abbas (3): >> arm64: dts: ti: k3-am65-mcu: Add Support for MCAN >> arm64: dts: ti: k3-j721e: Add support for MCAN nodes >> arm64: dts: ti: k3-j721e-common-proc-board: Add support for mcu_mcan >> nodes > > I noticed in my checkup: https://pastebin.ubuntu.com/p/zSk39M943N/ > warnings with dtbs_check, I think the bindings need a little more help > here (please also notice the iot platform warnings getting introduced). > Jan, Can you please point me to the schematics for iot platform? Also, is CAN subsystem brought out on the iot platform boards? > Since we are still working on the bindings[1], lets clean that up > before we consider the dts addition. I suspect we need to cook this > more towards the next cycle. > > [1] https://lore.kernel.org/patchwork/patch/1470806/ > Nishanth, Sorry for not taking of this earlier. I'll try to get everything ready for next release. Thanks, Aswath
On 05.08.21 14:32, Aswath Govindraju wrote: > Hi, > > On 02/08/21 6:15 pm, Nishanth Menon wrote: >> On 15:40-20210726, Aswath Govindraju wrote: >>> The following series of patches add support for CAN in SoC's AM65, J721e >>> and AM64. >>> >>> This patch series is dependent on [1] and [2] and I have requested for an >>> immutable tag from the Marc Kleine-Budde(maintainer of net tree). >>> >>> [1] - https://lore.kernel.org/patchwork/patch/1423048/ >>> [2] - https://www.spinics.net/lists/linux-can/msg08108.html >>> >>> changes since v1 - >>> - changed the message ram configuration to use the maximum value >>> in each field, for better performance. >>> >>> Aswath Govindraju (3): >>> arm64: dts: ti: am654-base-board: Disable mcan nodes >>> arm64: dts: ti: k3-am64-main: Add support for MCAN >>> arm64: dts: ti: k3-am642-evm/sk: Add support for main domain mcan >>> nodes in EVM and disable them on SK >>> >>> Faiz Abbas (3): >>> arm64: dts: ti: k3-am65-mcu: Add Support for MCAN >>> arm64: dts: ti: k3-j721e: Add support for MCAN nodes >>> arm64: dts: ti: k3-j721e-common-proc-board: Add support for mcu_mcan >>> nodes >> >> I noticed in my checkup: https://pastebin.ubuntu.com/p/zSk39M943N/ >> warnings with dtbs_check, I think the bindings need a little more help >> here (please also notice the iot platform warnings getting introduced). >> > > Jan, > > Can you please point me to the schematics for iot platform? Also, is CAN > subsystem brought out on the iot platform boards? Schematics aren't publicly available. If you have specific questions, I may help, though. CAN is not in use yet (not connected AFAIK). Jan > >> Since we are still working on the bindings[1], lets clean that up >> before we consider the dts addition. I suspect we need to cook this >> more towards the next cycle. >> >> [1] https://lore.kernel.org/patchwork/patch/1470806/ >> > > Nishanth, > > Sorry for not taking of this earlier. I'll try to get everything ready > for next release. > > Thanks, > Aswath >
Hi Jan, On 05/08/21 6:10 pm, Jan Kiszka wrote: > On 05.08.21 14:32, Aswath Govindraju wrote: >> Hi, >> >> On 02/08/21 6:15 pm, Nishanth Menon wrote: >>> On 15:40-20210726, Aswath Govindraju wrote: >>>> The following series of patches add support for CAN in SoC's AM65, J721e >>>> and AM64. >>>> >>>> This patch series is dependent on [1] and [2] and I have requested for an >>>> immutable tag from the Marc Kleine-Budde(maintainer of net tree). >>>> >>>> [1] - https://lore.kernel.org/patchwork/patch/1423048/ >>>> [2] - https://www.spinics.net/lists/linux-can/msg08108.html >>>> >>>> changes since v1 - >>>> - changed the message ram configuration to use the maximum value >>>> in each field, for better performance. >>>> >>>> Aswath Govindraju (3): >>>> arm64: dts: ti: am654-base-board: Disable mcan nodes >>>> arm64: dts: ti: k3-am64-main: Add support for MCAN >>>> arm64: dts: ti: k3-am642-evm/sk: Add support for main domain mcan >>>> nodes in EVM and disable them on SK >>>> >>>> Faiz Abbas (3): >>>> arm64: dts: ti: k3-am65-mcu: Add Support for MCAN >>>> arm64: dts: ti: k3-j721e: Add support for MCAN nodes >>>> arm64: dts: ti: k3-j721e-common-proc-board: Add support for mcu_mcan >>>> nodes >>> >>> I noticed in my checkup: https://pastebin.ubuntu.com/p/zSk39M943N/ >>> warnings with dtbs_check, I think the bindings need a little more help >>> here (please also notice the iot platform warnings getting introduced). >>> >> >> Jan, >> >> Can you please point me to the schematics for iot platform? Also, is CAN >> subsystem brought out on the iot platform boards? > > Schematics aren't publicly available. If you have specific questions, I > may help, though. > > CAN is not in use yet (not connected AFAIK). > Thank you for clarifying this. I will disable the CAN DT nodes in k3-am65-iot2050-common.dtsi in my respin. Thanks, Aswath > Jan > >> >>> Since we are still working on the bindings[1], lets clean that up >>> before we consider the dts addition. I suspect we need to cook this >>> more towards the next cycle. >>> >>> [1] https://lore.kernel.org/patchwork/patch/1470806/ >>> >> >> Nishanth, >> >> Sorry for not taking of this earlier. I'll try to get everything ready >> for next release. >> >> Thanks, >> Aswath >> >
On 05.08.21 14:44, Aswath Govindraju wrote: > Hi Jan, > > On 05/08/21 6:10 pm, Jan Kiszka wrote: >> On 05.08.21 14:32, Aswath Govindraju wrote: >>> Hi, >>> >>> On 02/08/21 6:15 pm, Nishanth Menon wrote: >>>> On 15:40-20210726, Aswath Govindraju wrote: >>>>> The following series of patches add support for CAN in SoC's AM65, J721e >>>>> and AM64. >>>>> >>>>> This patch series is dependent on [1] and [2] and I have requested for an >>>>> immutable tag from the Marc Kleine-Budde(maintainer of net tree). >>>>> >>>>> [1] - https://lore.kernel.org/patchwork/patch/1423048/ >>>>> [2] - https://www.spinics.net/lists/linux-can/msg08108.html >>>>> >>>>> changes since v1 - >>>>> - changed the message ram configuration to use the maximum value >>>>> in each field, for better performance. >>>>> >>>>> Aswath Govindraju (3): >>>>> arm64: dts: ti: am654-base-board: Disable mcan nodes >>>>> arm64: dts: ti: k3-am64-main: Add support for MCAN >>>>> arm64: dts: ti: k3-am642-evm/sk: Add support for main domain mcan >>>>> nodes in EVM and disable them on SK >>>>> >>>>> Faiz Abbas (3): >>>>> arm64: dts: ti: k3-am65-mcu: Add Support for MCAN >>>>> arm64: dts: ti: k3-j721e: Add support for MCAN nodes >>>>> arm64: dts: ti: k3-j721e-common-proc-board: Add support for mcu_mcan >>>>> nodes >>>> >>>> I noticed in my checkup: https://pastebin.ubuntu.com/p/zSk39M943N/ >>>> warnings with dtbs_check, I think the bindings need a little more help >>>> here (please also notice the iot platform warnings getting introduced). >>>> >>> >>> Jan, >>> >>> Can you please point me to the schematics for iot platform? Also, is CAN >>> subsystem brought out on the iot platform boards? >> >> Schematics aren't publicly available. If you have specific questions, I >> may help, though. >> >> CAN is not in use yet (not connected AFAIK). >> > > Thank you for clarifying this. I will disable the CAN DT nodes in > k3-am65-iot2050-common.dtsi in my respin. > That is not a problem for the current design, so you can go ahead with it. Current defconfig - though not yet upstream based - can be found at [1]. The CAN subsystem is enabled, but not the AM65x CAN driver. Jan [1] https://github.com/siemens/meta-iot2050/tree/master/recipes-kernel/linux/files