From patchwork Wed Nov 3 18:49:30 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jim Quinlan X-Patchwork-Id: 12601473 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93E2FC433F5 for ; Wed, 3 Nov 2021 18:51:46 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 63D83610E7 for ; Wed, 3 Nov 2021 18:51:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 63D83610E7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:List-Subscribe:List-Help: List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date:Subject:Cc:To :From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=57zNDu+rG9ShyzBvrgRzoRuIKoFENP9cwVJ9ktiDGAc=; b=naTcbM3nVERP/w iXJvc6IfA81t+bqyfOamxZMoGRl8Pod4DUMgzsniVej3wW070wGwRIFBPBKAfwmZAJ2bPdi94DEMw Y07SsxYVALYXyOuKWuhbNKWygTlmnZensZTiTvL+RiZEck9O9tvxSyycuscarOlIbe76F2w4qZX/9 TElRAQCjRaibp6yZU5WNqM0+HaFxSzVzibEBZC5vozYqyCieuo9L4XZABbYV7ZeB4H9pUTqc4il19 RcPwSy7QF0EXeyXX54HLqUSwJURl4B216YyqJgiSgFOuUc6HIjjDoN+TMOfHRSQJElp9FYB8J3z+G N9mRSjyeoGUnjY9qlSuw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1miLKa-006HF3-Id; Wed, 03 Nov 2021 18:49:52 +0000 Received: from mail-pl1-x633.google.com ([2607:f8b0:4864:20::633]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1miLKV-006HDH-Sa; Wed, 03 Nov 2021 18:49:49 +0000 Received: by mail-pl1-x633.google.com with SMTP id r5so3152170pls.1; Wed, 03 Nov 2021 11:49:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id; bh=3TUt2HAWz62F5Cjx111xJfglPvqm3GTWL2L9Knx1dck=; b=JHwZYdJqKRnTc44EBfVUZOT/kAGAK0crYduiqYGonc+MCsF6NFKfm7j+BpBok+3N7u 0gFQECVu2oeMclysYC1qQpve7oQlQ70+eugKMA7f+UFQd7/jYcyW6q6zlTUGDMwtWwsN LutWqjBiVcQT7n7rEaXf5DEcZ5JiDSlg5V4puW/xEAQBGn4GSIHiVtfckHzTGBhzrd7f 5NdsJbHp9QcUJIPzoUuxLlwGOLnJZGze6cn0hBLGkyaxnjON0vZPIsWNlc4u5rwAe6tB /hajt2DTRzYEe5jyAckGcVQgX5SGgjuReBVN6lF4XBtgs93ckRgCbfmrf/aVZs6rcfKX 88Tg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=3TUt2HAWz62F5Cjx111xJfglPvqm3GTWL2L9Knx1dck=; b=pb0+Bn/XnCnva2urle6jMXkgl8hC+H9cAyVv6oCW945lKXqusmfZWQUS/wVsTuDEyl hCben7sRTBpKt2Q7U3MvkYQuErZ5IkCTUhPI1WpZxW3BjFUFjafa6utzeWGCGj+JYzI7 dbIHLLuIduCc6fXW199YAutFahSIklphcmRe/GXLFeHaU5h7VCgMuuK8LYPedA1loT6X IrtuxtJCc/bEXju95DlmN9w1nF0WrkiJOEma6OFgm2tp5JqvW0aXcoTFvCF1yOKGvmiY oEzOkLgX+V/zGKM2OvqLzn7qhJVq7VOuUuUjkdIylwlnf3/oPjo53kKjwSlvLjAU+FV2 YgDw== X-Gm-Message-State: AOAM530eIQ21NBHHPmWUAQoIkpmyxK2ZJlgGi6Az3LNEAb0B2/Mqy2jq FGhCOW8h/bTD2czb3Cq6gHs= X-Google-Smtp-Source: ABdhPJxeWVpSrOhvFAtC0Ejv/vDroGUJizuSgT94TfsRd7f61drsrbu0QQsJelUeBxhgK5EYEQL1/A== X-Received: by 2002:a17:902:900c:b0:13f:974c:19b0 with SMTP id a12-20020a170902900c00b0013f974c19b0mr39501804plp.12.1635965385874; Wed, 03 Nov 2021 11:49:45 -0700 (PDT) Received: from stbsrv-and-01.and.broadcom.net ([192.19.11.250]) by smtp.gmail.com with ESMTPSA id j6sm2379065pgq.0.2021.11.03.11.49.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Nov 2021 11:49:45 -0700 (PDT) From: Jim Quinlan To: linux-pci@vger.kernel.org, Nicolas Saenz Julienne , Rob Herring , Mark Brown , bcm-kernel-feedback-list@broadcom.com, jim2101024@gmail.com, james.quinlan@broadcom.com Cc: devicetree@vger.kernel.org (open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS), =?utf-8?q?Krzysztof_Wilczy=C5=84ski?= , linux-arm-kernel@lists.infradead.org (moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE), linux-kernel@vger.kernel.org (open list), linux-rpi-kernel@lists.infradead.org (moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE), Saenz Julienne Subject: [PATCH v7 0/7] PCI: brcmstb: have host-bridge turn on sub-device power Date: Wed, 3 Nov 2021 14:49:30 -0400 Message-Id: <20211103184939.45263-1-jim2101024@gmail.com> X-Mailer: git-send-email 2.17.1 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211103_114947_960592_521F784F X-CRM114-Status: GOOD ( 22.35 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org v7 -- RobH suggested putting the "vpcixxx-supply" property under the bridge-node rather than the endpoint device node. Also, he said to use the pci-ops add_bus/remove methods. Doing so simplifies the code greatly and three commits were dropped. Thanks! -- Rob also suggested (I think) having this patchset be a general feature which is activated by an OF property under the bridge node. I tried to do that but realized that our root complex driver controls the regulators with its dev_pm_ops and there is no way to transfer this control when using general mechanism. Note that although the regulator core deals with suspend, our RC driver wants the right to sometimes to preclude this for WOL scenarios. -- One commit was added to change the response to the return value of the pci_ops add_bus() method. Currently, an error causes a WARNING, a dev_err(...), and continues to return the child bus. The modification was, for returning -ENOLINK only, to skip WARNING & dev_err() and return NULL. This is necessary for our RC HW, as if the code continues on it will do a pci_read_config_dword() for the vendor/id, and our HW flags a CPU abort (instead of returning 0xffffffff) when the is no pcie-link established. [NOTE: MarkB, I did not add one of your two "Reviewed-by"s because the commit had a decent amount of change.] v6 -- Dropped the idea of a placeholder regulator property (brcm-ep-a-supply). (MarkB) -- device_initialize() now called once. Two commits were added for this. (GKH) -- In two cases, separated a single function into two or more functions (MarkB) -- "(void)foo();" => "foo()". Note that although foo() returns an int, in this instance it is being invoked within a function returning void, and foo() already executes a dev_err() on error. (MarkB) -- Added a commit to correct PCIe interrupts in YAML. -- Removed "device_type = "pci";" for the EP node in the YAML example. -- Updated the URL related to the voltage regulator names on GitHub. Note that I added vpciev3v3aux. v5 [NOTE: It has been a while since v4. Sorry] -- See "PCI: allow for callback to prepare nascent subdev" commit message for the cornerstone of this patchset and the reasons behind it. This is a new commit. -- The RC driver now looks into its DT children and turns on regulators for a sub-device, and this occurs prior to PCIe link as it must. -- Dropped commits not related to the focus of this patchset. v4 [NOTE: I'm not sure this fixes RobH and MarkB constraints but I'd like to use this pullreq as a basis for future discussion.] [Commit: Add bindings for ...] -- Fix syntax error in YAML bindings example (RobH) -- {vpcie12v,vpcie3v3}-supply props are back in root complex DT node (I believe RobH said this was okay) [Commit: Add control of ..] -- Do not do global search for regulator; now we look specifically for the property {vpcie12v,vpcie3v3}-supply in the root complex DT node and then call devm_regulator_bulk_get() (MarkB) -- Use devm_regulator_bulk_get() (Bjorn) -- s/EP/slot0 device/ (Bjorn) -- Spelling, capitalization (Bjorn) -- Have brcm_phy_stop() return a void (Bjorn) [Commit: Do not turn off ...] -- Capitalization (Bjorn) [Commit: Check return value ...] -- Commit message content (Bjorn) -- Move 6/6 hunk to 2/6 where it belongs (Bjorn) -- Move the rest of 6/6 before all other commits (Bjorn) v3 -- Driver now searches for EP DT subnode for any regulators to turn on. If present, these regulators have the property names "vpcie12v-supply" and "vpcie3v3-supply". The existence of these regulators in the EP subnode are currently pending as a pullreq in pci-bus.yaml at https://github.com/devicetree-org/dt-schema/pull/54 (MarkB, RobH). -- Check return of brcm_set_regulators() (Florian) -- Specify one regulator string per line for easier update (Florian) -- Author/Committer/Signoff email changed from that of V2 from 'james.quinlan@broadcom.com' to 'jim2101024@gmail.com'. v2 -- Use regulator bulk API rather than multiple calls (MarkB). v1 -- Bindings are added for fixed regulators that may power the EP device. -- The brcmstb RC driver is modified to control these regulators during probe, suspend, and resume. -- 7216 type SOCs have additional error reporting HW and a panic handler is added to dump its info. -- A missing return value check is added. Jim Quinlan (7): dt-bindings: PCI: Correct brcmstb interrupts, interrupt-map. dt-bindings: PCI: Add bindings for Brcmstb EP voltage regulators PCI: brcmstb: Split brcm_pcie_setup() into two funcs PCI: pci_alloc_child_bus() return NULL if ->add_bus() returns -ENOLINK PCI: brcmstb: Add control of subdevice voltage regulators PCI: brcmstb: Do not turn off regulators if EP can wake up PCI: brcmstb: Change brcm_phy_stop() to return void .../bindings/pci/brcm,stb-pcie.yaml | 31 ++- drivers/pci/controller/pcie-brcmstb.c | 233 ++++++++++++++++-- drivers/pci/probe.c | 3 + 3 files changed, 250 insertions(+), 17 deletions(-) base-commit: 8e37395c3a5dceff62a5010ebbbc107f4145935c