mbox series

[v3,0/4] Add DTs for all Apple M1 (t8103) devices

Message ID 20211122225807.8105-1-j@jannau.net (mailing list archive)
Headers show
Series Add DTs for all Apple M1 (t8103) devices | expand

Message

Janne Grunau Nov. 22, 2021, 10:58 p.m. UTC
Hej All,

this series extends the device tree files and bindings to all current
Apple M1 devices. Specifically it adds DTs for following devices:
- MacBook Air (M1, 2020)
- Macbook Pro (13-inch, M1, 2020)
- iMac (24-inch, M1, 2021)

It also adds i2c and cd321x devices nodes. Bindings and code changes for
those were merged for 5.16 without adding devices to the device tree.
Patches are include in a single series for dependencies

Changes since v2:
 - split i2c and cd321x changes into 2 commit
 - add i2c4 used by MacBooc Pros (j293, 13-inch, M1, 2020)
 - add hpm2 and hpm3 for the additional USB-C ports on j456 iMac
   (24-inch, M1, 2021) models

Series depends for functionality and dtbs verification on
"[PATCH 0/3] Apple Arm patform device tree and bindings fixes".

thanks,
Janne

The series is available as branch from:
    https://github.com/jannau/linux/tree/apple_m1/dt-for-5.17_v3

Janne Grunau (4):
  dt-bindings: arm: apple: Add iMac (24-inch 2021) to Apple bindings
  arm64: dts: apple: Add missing M1 (t8103) devices
  arm64: dts: apple: t8103: Add i2c nodes
  arm64: dts: apple: t8103: Add cd321x nodes

 .../devicetree/bindings/arm/apple.yaml        |  6 +-
 arch/arm64/boot/dts/apple/Makefile            |  4 +
 arch/arm64/boot/dts/apple/t8103-j274.dts      | 33 +------
 arch/arm64/boot/dts/apple/t8103-j293.dts      | 41 +++++++++
 arch/arm64/boot/dts/apple/t8103-j313.dts      | 33 +++++++
 arch/arm64/boot/dts/apple/t8103-j456.dts      | 59 ++++++++++++
 arch/arm64/boot/dts/apple/t8103-j457.dts      | 47 ++++++++++
 arch/arm64/boot/dts/apple/t8103-jxxx.dtsi     | 67 ++++++++++++++
 arch/arm64/boot/dts/apple/t8103.dtsi          | 92 +++++++++++++++++++
 9 files changed, 352 insertions(+), 30 deletions(-)
 create mode 100644 arch/arm64/boot/dts/apple/t8103-j293.dts
 create mode 100644 arch/arm64/boot/dts/apple/t8103-j313.dts
 create mode 100644 arch/arm64/boot/dts/apple/t8103-j456.dts
 create mode 100644 arch/arm64/boot/dts/apple/t8103-j457.dts
 create mode 100644 arch/arm64/boot/dts/apple/t8103-jxxx.dtsi

Comments

Hector Martin Nov. 26, 2021, 5:39 a.m. UTC | #1
On 23/11/2021 07.58, Janne Grunau wrote:
> Hej All,
> 
> this series extends the device tree files and bindings to all current
> Apple M1 devices. Specifically it adds DTs for following devices:
> - MacBook Air (M1, 2020)
> - Macbook Pro (13-inch, M1, 2020)
> - iMac (24-inch, M1, 2021)
> 
> It also adds i2c and cd321x devices nodes. Bindings and code changes for
> those were merged for 5.16 without adding devices to the device tree.
> Patches are include in a single series for dependencies
> 
> Changes since v2:
>   - split i2c and cd321x changes into 2 commit
>   - add i2c4 used by MacBooc Pros (j293, 13-inch, M1, 2020)
>   - add hpm2 and hpm3 for the additional USB-C ports on j456 iMac
>     (24-inch, M1, 2021) models
> 
> Series depends for functionality and dtbs verification on
> "[PATCH 0/3] Apple Arm patform device tree and bindings fixes".
> 
> thanks,
> Janne
> 
> The series is available as branch from:
>      https://github.com/jannau/linux/tree/apple_m1/dt-for-5.17_v3
> 
> Janne Grunau (4):
>    dt-bindings: arm: apple: Add iMac (24-inch 2021) to Apple bindings
>    arm64: dts: apple: Add missing M1 (t8103) devices
>    arm64: dts: apple: t8103: Add i2c nodes
>    arm64: dts: apple: t8103: Add cd321x nodes
> 
>   .../devicetree/bindings/arm/apple.yaml        |  6 +-
>   arch/arm64/boot/dts/apple/Makefile            |  4 +
>   arch/arm64/boot/dts/apple/t8103-j274.dts      | 33 +------
>   arch/arm64/boot/dts/apple/t8103-j293.dts      | 41 +++++++++
>   arch/arm64/boot/dts/apple/t8103-j313.dts      | 33 +++++++
>   arch/arm64/boot/dts/apple/t8103-j456.dts      | 59 ++++++++++++
>   arch/arm64/boot/dts/apple/t8103-j457.dts      | 47 ++++++++++
>   arch/arm64/boot/dts/apple/t8103-jxxx.dtsi     | 67 ++++++++++++++
>   arch/arm64/boot/dts/apple/t8103.dtsi          | 92 +++++++++++++++++++
>   9 files changed, 352 insertions(+), 30 deletions(-)
>   create mode 100644 arch/arm64/boot/dts/apple/t8103-j293.dts
>   create mode 100644 arch/arm64/boot/dts/apple/t8103-j313.dts
>   create mode 100644 arch/arm64/boot/dts/apple/t8103-j456.dts
>   create mode 100644 arch/arm64/boot/dts/apple/t8103-j457.dts
>   create mode 100644 arch/arm64/boot/dts/apple/t8103-jxxx.dtsi
> 

Whole series is:

Tested-by: Hector Martin <marcan@marcan.st>

on j274, j313, j456.

Thanks! If you spin up a v4 with the minor comments addressed, I'll be 
happy to merge it :)
Janne Grunau Nov. 26, 2021, 6:33 a.m. UTC | #2
Hej,

On 2021-11-26 14:39:16 +0900, Hector Martin wrote:
> On 23/11/2021 07.58, Janne Grunau wrote:
> > 
> > Janne Grunau (4):
> >    dt-bindings: arm: apple: Add iMac (24-inch 2021) to Apple bindings
> >    arm64: dts: apple: Add missing M1 (t8103) devices
> >    arm64: dts: apple: t8103: Add i2c nodes
> >    arm64: dts: apple: t8103: Add cd321x nodes
> > 
> >   .../devicetree/bindings/arm/apple.yaml        |  6 +-
> >   arch/arm64/boot/dts/apple/Makefile            |  4 +
> >   arch/arm64/boot/dts/apple/t8103-j274.dts      | 33 +------
> >   arch/arm64/boot/dts/apple/t8103-j293.dts      | 41 +++++++++
> >   arch/arm64/boot/dts/apple/t8103-j313.dts      | 33 +++++++
> >   arch/arm64/boot/dts/apple/t8103-j456.dts      | 59 ++++++++++++
> >   arch/arm64/boot/dts/apple/t8103-j457.dts      | 47 ++++++++++
> >   arch/arm64/boot/dts/apple/t8103-jxxx.dtsi     | 67 ++++++++++++++
> >   arch/arm64/boot/dts/apple/t8103.dtsi          | 92 +++++++++++++++++++
> >   9 files changed, 352 insertions(+), 30 deletions(-)
> >   create mode 100644 arch/arm64/boot/dts/apple/t8103-j293.dts
> >   create mode 100644 arch/arm64/boot/dts/apple/t8103-j313.dts
> >   create mode 100644 arch/arm64/boot/dts/apple/t8103-j456.dts
> >   create mode 100644 arch/arm64/boot/dts/apple/t8103-j457.dts
> >   create mode 100644 arch/arm64/boot/dts/apple/t8103-jxxx.dtsi
> > 
> 
> Whole series is:
> 
> Tested-by: Hector Martin <marcan@marcan.st>
> 
> on j274, j313, j456.
> 
> Thanks! If you spin up a v4 with the minor comments addressed, I'll be happy
> to merge it :)

there is already a v4 with Sven's comments addressed at

https://lore.kernel.org/linux-arm-kernel/20211123224926.7722-1-j@jannau.net/

Jean-Marc Ranger notified me off-list of a typo in "arm64: dts: apple: 
t8103: Add cd321x nodes" commit messages: 'addiotional'.

I don't think it's worth spinning up a v5 for fixing that typo.

thanks,

Janne
Hector Martin Nov. 26, 2021, 6:50 a.m. UTC | #3
On 26/11/2021 15.33, Janne Grunau wrote:
> Hej,
> 
> On 2021-11-26 14:39:16 +0900, Hector Martin wrote:
>> On 23/11/2021 07.58, Janne Grunau wrote:
>>>
>>> Janne Grunau (4):
>>>     dt-bindings: arm: apple: Add iMac (24-inch 2021) to Apple bindings
>>>     arm64: dts: apple: Add missing M1 (t8103) devices
>>>     arm64: dts: apple: t8103: Add i2c nodes
>>>     arm64: dts: apple: t8103: Add cd321x nodes
>>>
>>>    .../devicetree/bindings/arm/apple.yaml        |  6 +-
>>>    arch/arm64/boot/dts/apple/Makefile            |  4 +
>>>    arch/arm64/boot/dts/apple/t8103-j274.dts      | 33 +------
>>>    arch/arm64/boot/dts/apple/t8103-j293.dts      | 41 +++++++++
>>>    arch/arm64/boot/dts/apple/t8103-j313.dts      | 33 +++++++
>>>    arch/arm64/boot/dts/apple/t8103-j456.dts      | 59 ++++++++++++
>>>    arch/arm64/boot/dts/apple/t8103-j457.dts      | 47 ++++++++++
>>>    arch/arm64/boot/dts/apple/t8103-jxxx.dtsi     | 67 ++++++++++++++
>>>    arch/arm64/boot/dts/apple/t8103.dtsi          | 92 +++++++++++++++++++
>>>    9 files changed, 352 insertions(+), 30 deletions(-)
>>>    create mode 100644 arch/arm64/boot/dts/apple/t8103-j293.dts
>>>    create mode 100644 arch/arm64/boot/dts/apple/t8103-j313.dts
>>>    create mode 100644 arch/arm64/boot/dts/apple/t8103-j456.dts
>>>    create mode 100644 arch/arm64/boot/dts/apple/t8103-j457.dts
>>>    create mode 100644 arch/arm64/boot/dts/apple/t8103-jxxx.dtsi
>>>
>>
>> Whole series is:
>>
>> Tested-by: Hector Martin <marcan@marcan.st>
>>
>> on j274, j313, j456.
>>
>> Thanks! If you spin up a v4 with the minor comments addressed, I'll be happy
>> to merge it :)
> 
> there is already a v4 with Sven's comments addressed at
> 
> https://lore.kernel.org/linux-arm-kernel/20211123224926.7722-1-j@jannau.net/
> 
> Jean-Marc Ranger notified me off-list of a typo in "arm64: dts: apple:
> t8103: Add cd321x nodes" commit messages: 'addiotional'.
> 
> I don't think it's worth spinning up a v5 for fixing that typo.

Oh whoops, I think I mixed that one up with this one when scrolling 
through email and thought they were the same series. Was just catching 
up on email and it hadn't hit me yet... thanks for pointing it out.