[v4,0/9] STM32 CRYP driver: many fixes

Message

Nicolas Toromanoff Nov. 30, 2021, 7:54 a.m. UTC

Hello,

This set of patches update the STM32 CRYP driver.

First two update about EPROBE_DEFER management.
Then many fixes to success the cryptomanager EXTRA_TESTS.
And finally we reorder the initialization to set the key as last step.

This patch series applies to cryptodev/master.

v1 -> v2 :
  - use crypto_inc() in "crypto: stm32/cryp - fix CTR counter carry".
  - more explicit commit description.
  - with CONFIG_CRYPTO_MANAGER_EXTRA_TESTS=y all tests pass, at boot
    if built into kernel, at insmod if in module. (as v1)

v2->v3:
  - fix smatch warning (that was a bug) in "crypto: stm32/cryp - fix bugs
    and crash in tests" add missing parenthesis in mask/shift operation in
    stm32_cryp_write_ccm_first_header(), was only visible in case of aad
    buffer bigger than 65280 bytes.
  - add a new commit to fix lrw chaining mode

v3->v4
  - Fix sparse warning
  - Rebase on cryptodev-2.6/master
  - rework 0004-patch: with v1 correction, the xts extra tests using
    stm32-cryp were still broken.

Etienne Carriere (2):
  crypto: stm32/cryp - defer probe for reset controller
  crypto: stm32/cryp - don't print error on probe deferral

Nicolas Toromanoff (7):
  crypto: stm32/cryp - fix CTR counter carry
  crypto: stm32/cryp - fix xts and race condition in crypto_engine
    requests
  crypto: stm32/cryp - check early input data
  crypto: stm32/cryp - fix double pm exit
  crypto: stm32/cryp - fix lrw chaining mode
  crypto: stm32/cryp - fix bugs and crash in tests
  crypto: stm32/cryp - reorder hw initialization

 drivers/crypto/stm32/stm32-cryp.c | 987 ++++++++++++------------------
 1 file changed, 404 insertions(+), 583 deletions(-)


base-commit: 330507fbc9d8c3bc4525ea2ae9c3774738bc0c80

Comments

Herbert Xu Dec. 11, 2021, 5:55 a.m. UTC | #1

On Tue, Nov 30, 2021 at 08:54:52AM +0100, Nicolas Toromanoff wrote:
> Hello,
> 
> This set of patches update the STM32 CRYP driver.
> 
> First two update about EPROBE_DEFER management.
> Then many fixes to success the cryptomanager EXTRA_TESTS.
> And finally we reorder the initialization to set the key as last step.
> 
> This patch series applies to cryptodev/master.
> 
> v1 -> v2 :
>   - use crypto_inc() in "crypto: stm32/cryp - fix CTR counter carry".
>   - more explicit commit description.
>   - with CONFIG_CRYPTO_MANAGER_EXTRA_TESTS=y all tests pass, at boot
>     if built into kernel, at insmod if in module. (as v1)
> 
> v2->v3:
>   - fix smatch warning (that was a bug) in "crypto: stm32/cryp - fix bugs
>     and crash in tests" add missing parenthesis in mask/shift operation in
>     stm32_cryp_write_ccm_first_header(), was only visible in case of aad
>     buffer bigger than 65280 bytes.
>   - add a new commit to fix lrw chaining mode
> 
> v3->v4
>   - Fix sparse warning
>   - Rebase on cryptodev-2.6/master
>   - rework 0004-patch: with v1 correction, the xts extra tests using
>     stm32-cryp were still broken.
> 
> Etienne Carriere (2):
>   crypto: stm32/cryp - defer probe for reset controller
>   crypto: stm32/cryp - don't print error on probe deferral
> 
> Nicolas Toromanoff (7):
>   crypto: stm32/cryp - fix CTR counter carry
>   crypto: stm32/cryp - fix xts and race condition in crypto_engine
>     requests
>   crypto: stm32/cryp - check early input data
>   crypto: stm32/cryp - fix double pm exit
>   crypto: stm32/cryp - fix lrw chaining mode
>   crypto: stm32/cryp - fix bugs and crash in tests
>   crypto: stm32/cryp - reorder hw initialization
> 
>  drivers/crypto/stm32/stm32-cryp.c | 987 ++++++++++++------------------
>  1 file changed, 404 insertions(+), 583 deletions(-)
> 
> 
> base-commit: 330507fbc9d8c3bc4525ea2ae9c3774738bc0c80
> -- 
> 2.17.1

All applied.  Thanks.