[v2,0/6] coresight: syscfg: Extend configfs for config load

Message

Mike Leach Nov. 30, 2021, 10 p.m. UTC

This set extends the configfs support to allow loading and unloading of
configurations as binary files via configfs.

Additional attributes - load, unload and last_load_status are provided to
implement the load functionality.

Routines to generate binary configuration files are supplied in
./samples/coresight.

Example generator and reader applications are provided.

Additional Makefile.host supplied to build the generator and reader
applications on the host system separate from a cross compiled kernel.

Documentation is updated to describe feature usage.

Applies and tested on latest coresight/next that includes the
previous coresight configuration dynamic load patchset.

Changes since v1:
1) Rebased to coresight/next - 5.16-rc1 with previous coresight config
set applied.
2) Makefile.host fixed to default to all target.

Mike Leach (6):
  coresight: configfs: Add in functionality for load via configfs
  coresight: configfs: Add in binary attributes to load files
  coresight: configfs: Modify config files to allow userspace use
  coresight: samples: Add an example config writer for configfs load
  coresight: samples: Add coresight file reader sample program
  Documentation: coresight: docs for config load via configfs

 .../trace/coresight/coresight-config.rst      | 151 +++++-
 drivers/hwtracing/coresight/Makefile          |   2 +-
 .../coresight/coresight-config-file.c         | 472 ++++++++++++++++++
 .../coresight/coresight-config-file.h         | 158 ++++++
 .../hwtracing/coresight/coresight-config.h    |  38 ++
 .../coresight/coresight-syscfg-configfs.c     | 148 +++++-
 .../coresight/coresight-syscfg-configfs.h     |   8 +
 .../hwtracing/coresight/coresight-syscfg.c    |  36 ++
 .../hwtracing/coresight/coresight-syscfg.h    |   2 +
 samples/coresight/Makefile                    |  23 +
 samples/coresight/Makefile.host               |  47 ++
 samples/coresight/coresight-cfg-bufw.c        | 302 +++++++++++
 samples/coresight/coresight-cfg-bufw.h        |  24 +
 samples/coresight/coresight-cfg-file-read.c   | 191 +++++++
 samples/coresight/coresight-cfg-filegen.c     |  89 ++++
 15 files changed, 1677 insertions(+), 14 deletions(-)
 create mode 100644 drivers/hwtracing/coresight/coresight-config-file.c
 create mode 100644 drivers/hwtracing/coresight/coresight-config-file.h
 create mode 100644 samples/coresight/Makefile.host
 create mode 100644 samples/coresight/coresight-cfg-bufw.c
 create mode 100644 samples/coresight/coresight-cfg-bufw.h
 create mode 100644 samples/coresight/coresight-cfg-file-read.c
 create mode 100644 samples/coresight/coresight-cfg-filegen.c

Comments

Mathieu Poirier Jan. 10, 2022, 6:58 p.m. UTC | #1

Good morning Mike,

On Tue, Nov 30, 2021 at 10:00:54PM +0000, Mike Leach wrote:
> This set extends the configfs support to allow loading and unloading of
> configurations as binary files via configfs.
> 
> Additional attributes - load, unload and last_load_status are provided to
> implement the load functionality.
> 
> Routines to generate binary configuration files are supplied in
> ./samples/coresight.
> 
> Example generator and reader applications are provided.
> 
> Additional Makefile.host supplied to build the generator and reader
> applications on the host system separate from a cross compiled kernel.
> 
> Documentation is updated to describe feature usage.
> 
> Applies and tested on latest coresight/next that includes the
> previous coresight configuration dynamic load patchset.
> 

I have started to review this set.

Thanks,
Mathieu

> Changes since v1:
> 1) Rebased to coresight/next - 5.16-rc1 with previous coresight config
> set applied.
> 2) Makefile.host fixed to default to all target.
> 
> Mike Leach (6):
>   coresight: configfs: Add in functionality for load via configfs
>   coresight: configfs: Add in binary attributes to load files
>   coresight: configfs: Modify config files to allow userspace use
>   coresight: samples: Add an example config writer for configfs load
>   coresight: samples: Add coresight file reader sample program
>   Documentation: coresight: docs for config load via configfs
> 
>  .../trace/coresight/coresight-config.rst      | 151 +++++-
>  drivers/hwtracing/coresight/Makefile          |   2 +-
>  .../coresight/coresight-config-file.c         | 472 ++++++++++++++++++
>  .../coresight/coresight-config-file.h         | 158 ++++++
>  .../hwtracing/coresight/coresight-config.h    |  38 ++
>  .../coresight/coresight-syscfg-configfs.c     | 148 +++++-
>  .../coresight/coresight-syscfg-configfs.h     |   8 +
>  .../hwtracing/coresight/coresight-syscfg.c    |  36 ++
>  .../hwtracing/coresight/coresight-syscfg.h    |   2 +
>  samples/coresight/Makefile                    |  23 +
>  samples/coresight/Makefile.host               |  47 ++
>  samples/coresight/coresight-cfg-bufw.c        | 302 +++++++++++
>  samples/coresight/coresight-cfg-bufw.h        |  24 +
>  samples/coresight/coresight-cfg-file-read.c   | 191 +++++++
>  samples/coresight/coresight-cfg-filegen.c     |  89 ++++
>  15 files changed, 1677 insertions(+), 14 deletions(-)
>  create mode 100644 drivers/hwtracing/coresight/coresight-config-file.c
>  create mode 100644 drivers/hwtracing/coresight/coresight-config-file.h
>  create mode 100644 samples/coresight/Makefile.host
>  create mode 100644 samples/coresight/coresight-cfg-bufw.c
>  create mode 100644 samples/coresight/coresight-cfg-bufw.h
>  create mode 100644 samples/coresight/coresight-cfg-file-read.c
>  create mode 100644 samples/coresight/coresight-cfg-filegen.c
> 
> -- 
> 2.17.1
>