[v5,0/7] MediaTek Ethernet Patches on MT8195

Message

Biao Huang (黄彪) Dec. 7, 2021, 1:54 a.m. UTC

Changes in v5:
1. remove useless inclusion in dwmac-mediatek.c as Angelo's comments.
2. add acked-by in "net-next: stmmac: dwmac-mediatek: add support for
   mt8195" patch

Changes in v4:
1. add changes in commit message in "net-next: dt-bindings: dwmac:
   Convert mediatek-dwmac to DT schema" patch.
2. remove ethernet-controller.yaml since snps,dwmac.yaml already include it.

Changes in v3:
1. Add prefix "net-next" to support new IC as Denis's suggestion.
2. Split dt-bindings to two patches, one for conversion, and the other for
   new IC.
3. add a new patch to update device node in mt2712-evb.dts to accommodate to
   changes in driver.
4. remove unnecessary wrapper as Angelo's suggestion.
5. Add acked-by in "net-next: stmmac: dwmac-mediatek: Reuse more common
   features" patch.

Changes in v2:
1. fix errors/warnings in mediatek-dwmac.yaml with upgraded dtschema tools

This series include 5 patches:
1. add platform level clocks management for dwmac-mediatek
2. resue more common features defined in stmmac_platform.c
3. add ethernet entry for mt8195
4. convert mediatek-dwmac.txt to mediatek-dwmac.yaml

Biao Huang (7):
  net-next: stmmac: dwmac-mediatek: add platform level clocks management
  net-next: stmmac: dwmac-mediatek: Reuse more common features
  arm64: dts: mt2712: update ethernet device node
  net-next: dt-bindings: dwmac: Convert mediatek-dwmac to DT schema
  net-next: stmmac: dwmac-mediatek: add support for mt8195
  arm64: dts: mt8195: add ethernet device node
  net-next: dt-bindings: dwmac: add support for mt8195

 .../bindings/net/mediatek-dwmac.txt           |  91 ------
 .../bindings/net/mediatek-dwmac.yaml          | 210 ++++++++++++
 arch/arm64/boot/dts/mediatek/mt2712-evb.dts   |   1 +
 arch/arm64/boot/dts/mediatek/mt2712e.dtsi     |  14 +-
 arch/arm64/boot/dts/mediatek/mt8195-evb.dts   |  92 ++++++
 arch/arm64/boot/dts/mediatek/mt8195.dtsi      |  70 ++++
 .../ethernet/stmicro/stmmac/dwmac-mediatek.c  | 306 ++++++++++++++++--
 7 files changed, 665 insertions(+), 119 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/net/mediatek-dwmac.txt
 create mode 100644 Documentation/devicetree/bindings/net/mediatek-dwmac.yaml

Comments

Jakub Kicinski Dec. 7, 2021, 2:43 p.m. UTC | #1

On Tue, 7 Dec 2021 09:54:58 +0800 Biao Huang wrote:
> Changes in v5:
> 1. remove useless inclusion in dwmac-mediatek.c as Angelo's comments.
> 2. add acked-by in "net-next: stmmac: dwmac-mediatek: add support for
>    mt8195" patch

Which tree is this series based on? It doesn't seem to apply to
net-next. Also the net-next in the subjects is misplaced. If the series
is supposed to be merged to net-next the subject should be like:

[PATCH net-next v5 1/7] stmmac: dwmac-mediatek: add platform level clocks management

You can use --subject-prefix="PATCH net-next v6" in git-format-patch to
add the prefix.

Jakub Kicinski Dec. 7, 2021, 2:46 p.m. UTC | #2

On Tue, 7 Dec 2021 06:43:45 -0800 Jakub Kicinski wrote:
> On Tue, 7 Dec 2021 09:54:58 +0800 Biao Huang wrote:
> > Changes in v5:
> > 1. remove useless inclusion in dwmac-mediatek.c as Angelo's comments.
> > 2. add acked-by in "net-next: stmmac: dwmac-mediatek: add support for
> >    mt8195" patch  
> 
> Which tree is this series based on? It doesn't seem to apply to
> net-next. Also the net-next in the subjects is misplaced. If the series
> is supposed to be merged to net-next the subject should be like:
> 
> [PATCH net-next v5 1/7] stmmac: dwmac-mediatek: add platform level clocks management
> 
> You can use --subject-prefix="PATCH net-next v6" in git-format-patch to
> add the prefix.

FWIW patch 6 is the one with the conflict: "arm64: dts: mt8195: add
ethernet device node"

Biao Huang (黄彪) Dec. 8, 2021, 1:20 a.m. UTC | #3

Dear Jakub,
	Thanks for your comments~
On Tue, 2021-12-07 at 06:46 -0800, Jakub Kicinski wrote:
> On Tue, 7 Dec 2021 06:43:45 -0800 Jakub Kicinski wrote:
> > On Tue, 7 Dec 2021 09:54:58 +0800 Biao Huang wrote:
> > > Changes in v5:
> > > 1. remove useless inclusion in dwmac-mediatek.c as Angelo's
> > > comments.
> > > 2. add acked-by in "net-next: stmmac: dwmac-mediatek: add support
> > > for
> > >    mt8195" patch  
> > 
> > Which tree is this series based on? It doesn't seem to apply to
> > net-next. Also the net-next in the subjects is misplaced. If the
> > series
> > is supposed to be merged to net-next the subject should be like:
> > 
> > [PATCH net-next v5 1/7] stmmac: dwmac-mediatek: add platform level
> > clocks management
> > 
> > You can use --subject-prefix="PATCH net-next v6" in git-format-
> > patch to
> > add the prefix.
> 
> FWIW patch 6 is the one with the conflict: "arm64: dts: mt8195: add
> ethernet device node"
I'll rebase to the latest net-next tree, and fix these issues in next
send