[v3,00/12] dmaengine: at_xdmac: Various fixes

Message

Tudor Ambarus Dec. 15, 2021, 11:01 a.m. UTC

Bugs identified when debugging a hang encountered when operating
an octal DTR SPI NOR memory. The culprit was the flash, not the
DMA driver, so all these bugs are not experienced in real life,
they are all theoretical fixes. Nevertheless the bugs are there
and I think they should be squashed.

Tested the serial with DMA on sama5d2_xplained. Tested QSPI with DMA on
sama7g5ek. All went well.

v3:
- drop tty patches, they were applied by Greg.
- improve all commit descriptions
- split v2's patch 13/13 in two: one removing a level of indentation
  and one fixing the race.

v2:
- drop local chan_rx local variable in patch 3/13, focus just on fixes
for now.
- collect Richard's Acked-by tag.
- add details in the cover letter about what tests were performed.

Tudor Ambarus (12):
  dmaengine: at_xdmac: Don't start transactions at tx_submit level
  dmaengine: at_xdmac: Start transfer for cyclic channels in
    issue_pending
  dmaengine: at_xdmac: Print debug message after realeasing the lock
  dmaengine: at_xdmac: Fix concurrency over chan's completed_cookie
  dmaengine: at_xdmac: Fix race for the tx desc callback
  dmaengine: at_xdmac: Move the free desc to the tail of the desc list
  dmaengine: at_xdmac: Fix concurrency over xfers_list
  dmaengine: at_xdmac: Remove a level of indentation in
    at_xdmac_advance_work()
  dmaengine: at_xdmac: Fix lld view setting
  dmaengine: at_xdmac: Fix at_xdmac_lld struct definition
  dmaengine: at_xdmac: Remove a level of indentation in
    at_xdmac_tasklet()
  dmaengine: at_xdmac: Fix race over irq_status

 drivers/dma/at_xdmac.c | 186 ++++++++++++++++++++---------------------
 1 file changed, 89 insertions(+), 97 deletions(-)

Comments

Vinod Koul Jan. 5, 2022, 10:20 a.m. UTC | #1

On 15-12-21, 13:01, Tudor Ambarus wrote:
> Bugs identified when debugging a hang encountered when operating
> an octal DTR SPI NOR memory. The culprit was the flash, not the
> DMA driver, so all these bugs are not experienced in real life,
> they are all theoretical fixes. Nevertheless the bugs are there
> and I think they should be squashed.
> 
> Tested the serial with DMA on sama5d2_xplained. Tested QSPI with DMA on
> sama7g5ek. All went well.

Applied all, thanks