mbox series

[v2,0/2] pinctrl: mediatek: Support pinctrl driver on mt8186

Message ID 20220121060120.10683-1-guodong.liu@mediatek.com (mailing list archive)
Headers show
Series pinctrl: mediatek: Support pinctrl driver on mt8186 | expand

Message

Guodong Liu Jan. 21, 2022, 6:01 a.m. UTC 
changes since v1:
- add default pinctrl config to consistent with other MTK pinctrl drivers

Patch 1 add pinctrl file and binding document.

Patch 2 add pinctrl chip driver on mt8186.

Guodong Liu (2):
  dt-bindings: pinctrl: mt8186: add pinctrl file and binding document
  pinctrl: add pinctrl driver on mt8186

 .../bindings/pinctrl/pinctrl-mt8186.yaml      |  303 +++
 drivers/pinctrl/mediatek/Kconfig              |    7 +
 drivers/pinctrl/mediatek/Makefile             |    1 +
 drivers/pinctrl/mediatek/pinctrl-mt8186.c     | 1313 ++++++++++
 drivers/pinctrl/mediatek/pinctrl-mtk-mt8186.h | 2186 +++++++++++++++++
 include/dt-bindings/pinctrl/mt8186-pinfunc.h  | 1174 +++++++++
 6 files changed, 4984 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/pinctrl/pinctrl-mt8186.yaml
 create mode 100644 drivers/pinctrl/mediatek/pinctrl-mt8186.c
 create mode 100644 drivers/pinctrl/mediatek/pinctrl-mtk-mt8186.h
 create mode 100644 include/dt-bindings/pinctrl/mt8186-pinfunc.h

Comments

Linus Walleij Jan. 30, 2022, 1:42 a.m. UTC | #1 
On Fri, Jan 21, 2022 at 7:01 AM Guodong Liu <guodong.liu@mediatek.com> wrote:

> changes since v1:
> - add default pinctrl config to consistent with other MTK pinctrl drivers
>
> Patch 1 add pinctrl file and binding document.
>
> Patch 2 add pinctrl chip driver on mt8186.
>
> Guodong Liu (2):
>   dt-bindings: pinctrl: mt8186: add pinctrl file and binding document
>   pinctrl: add pinctrl driver on mt8186

Looks good to me, just wanna loop this by Chen-Yu Tsai for a check that
it looks good to him too.

Yours,
Linus Walleij
Chen-Yu Tsai Feb. 2, 2022, 3:49 p.m. UTC | #2 
Hi,

On Sun, Jan 30, 2022 at 9:43 AM Linus Walleij <linus.walleij@linaro.org> wrote:
>
> On Fri, Jan 21, 2022 at 7:01 AM Guodong Liu <guodong.liu@mediatek.com> wrote:
>
> > changes since v1:
> > - add default pinctrl config to consistent with other MTK pinctrl drivers
> >
> > Patch 1 add pinctrl file and binding document.
> >
> > Patch 2 add pinctrl chip driver on mt8186.
> >
> > Guodong Liu (2):
> >   dt-bindings: pinctrl: mt8186: add pinctrl file and binding document
> >   pinctrl: add pinctrl driver on mt8186
>
> Looks good to me, just wanna loop this by Chen-Yu Tsai for a check that
> it looks good to him too.

I'm still on vacation, and even after that, I might not have the cycles to
do an in depth review of the hardware bits this month.

Since Angelo already gave an ack (which somehow was not added in v2), and
AFAIK the driver does work downstream in ChromeOS, I wouldn't block it.

However, there's an error in the DT binding that should be fixed sooner
than later.


Thanks
ChenYu