From patchwork Wed Mar 9 11:41:36 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexander Stein X-Patchwork-Id: 12774978 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 86911C433EF for ; Wed, 9 Mar 2022 11:43:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=LhPJlYPXl2V3hwnYvfdCu0R9S0XenpXXt2BVTLb9rwk=; b=zcztQdauFxFh3P sx9HuzN8HNXrUJWiIMrc1JUZOZuU7KnZwq171FLWBp9ZpNzo1+ghcfKrX+dC71RRPk3pEIPVG5aA5 /QadDwT9vfSVngio92oAMPaaxbiqLLOgFSwgsG2wzdUpD7MliRX7u2iN/ivz3/WUtUtoyi3NHd5hq RN8O4JKsCp+5XnmWqxtoLOfxGA3AmFyp+pVNKpZky0VOlkq6glxF/+XOFHGRy4WQBh4IPrlKkB3ov IM9G2r/HwXvYVETtRJltqwsqOQZPuzQPNknPxZwyZ/mjLBxLUgzunFX71+NckedR995Q7QA7UUeus bt5fn9Z3pq2tiNgoqOjg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nRuhb-008L8d-5w; Wed, 09 Mar 2022 11:41:59 +0000 Received: from mx1.tq-group.com ([93.104.207.81]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nRuhX-008L7T-BM for linux-arm-kernel@lists.infradead.org; Wed, 09 Mar 2022 11:41:57 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1646826115; x=1678362115; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=gF8J7HWv3bLfkhCArBXGHHbXjOWuWHrvcm/30Nahldg=; b=SmVONda5gWfU6vYNeA6bW7efD7hyfLhMrqnNMNrMoOvJKOPGgHIwGvjX 4RFJi8hGiRkukHfgGdxzMHL/Q1SsNKUfFMKPC1nX1MI8R0yx/RWPurtaP BK2Psxd9kq3Wl+9RSmDadSonM6YOsgguV//rD0M5dh2jn5+GbT85wqBxT vBeStZSE0zikAmqJY4S1fVe8XSfQIK/VYjFSYZme3I+axXg6D6j/HJxWV N49EgtUmW3UfkZ8z7Pf06DUFvo2MZGpLqnLGd04aiHk4XQBph9I4jdheJ wOumUJuStd6Ejj477OMCNHY6sx6yp1d/bthdiKWvZg0r55E+v0XIBtWAm g==; X-IronPort-AV: E=Sophos;i="5.90,167,1643670000"; d="scan'208";a="22553358" Received: from unknown (HELO tq-pgp-pr1.tq-net.de) ([192.168.6.15]) by mx1-pgp.tq-group.com with ESMTP; 09 Mar 2022 12:41:53 +0100 Received: from mx1.tq-group.com ([192.168.6.7]) by tq-pgp-pr1.tq-net.de (PGP Universal service); Wed, 09 Mar 2022 12:41:53 +0100 X-PGP-Universal: processed; by tq-pgp-pr1.tq-net.de on Wed, 09 Mar 2022 12:41:53 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1646826113; x=1678362113; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=gF8J7HWv3bLfkhCArBXGHHbXjOWuWHrvcm/30Nahldg=; b=VS5Y7Cv5L2T3+7Y7Cqeylm8/AQpWGAgj9ZcGo0NTByRwtKFueL+DXe/4 2PXkOP81n1Zy6si8sKxd/9vFtGoeS/P6o+ejHxT3nEkOXxrBkeIs0Rcrf tMu5cbzCPUhA5FfNJPrfIrKD+3MZPGTLcN8xCvRn7MZhzR8yft2YFNIJd 0FfCQoIaYylbaXCWC3hrMJakTCevsqmXhLZULIwkEw0y93dBFucPUh36U 9llFi4C6EE+9EMgk/EBgv7cPAM+Mwl3MOqCpZTnPF6maoojguyFxezpX3 0CVJ+FlmM7phoieXIH+vO2+bT2EG457qnmGlTLrWctziq6G3WJTogchAQ Q==; X-IronPort-AV: E=Sophos;i="5.90,167,1643670000"; d="scan'208";a="22553357" Received: from vtuxmail01.tq-net.de ([10.115.0.20]) by mx1.tq-group.com with ESMTP; 09 Mar 2022 12:41:53 +0100 Received: from steina-w.tq-net.de (unknown [10.123.49.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by vtuxmail01.tq-net.de (Postfix) with ESMTPSA id D7F56280065; Wed, 9 Mar 2022 12:41:52 +0100 (CET) From: Alexander Stein To: Steve Longerbeam , Philipp Zabel , Mauro Carvalho Chehab , Greg Kroah-Hartman , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Rui Miguel Silva , Laurent Pinchart , Dorota Czaplejewicz Cc: Alexander Stein , linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 0/8] imx7/imx8mm media / csi patches Date: Wed, 9 Mar 2022 12:41:36 +0100 Message-Id: <20220309114144.120643-1-alexander.stein@ew.tq-group.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220309_034155_775590_4849B44E X-CRM114-Status: GOOD ( 18.30 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hey everyone, thanks for the feedback in v2. Changes in v3: * Dropped PATCH v2 5/9, applied in commit a7a52e146d0e * Added R-b Laurent Pinchart to PATCH 1 & 4 * Fix bpp check in PATCH 3 Below is the original message slightly modified to match the v3 changes. This is a set of patch for imx7 media drivers based on next-20220308. With this set I was able to capture video frames from a MIPI CSI-2 camera in my TQMa8MQML + MBA8MX hardware. The actual camera used is a Vision Components 'VC MIPI IMX327 C' camera. IMX327 is compatible to IMX290. Patch 8 shows the DT overlay I'm using, not suitable for merging. Please ignore the FPGA part, this is mainly for power supply and GPIO reset line. This is currently a custom driver I'm working on, but I do not want to focus on in this series. Please note I tested this only on this imx8 platform. First thanks to Dorota for the patchset at [1] (patches 1-4) which is necessary to capture correct images. Starting from patch 5 there are small fixes which allows me to configure my media device. Device configuration: ``` media-ctl -l "'imx290 2-001a':0->'csis-32e30000.mipi-csi':0 [1]" media-ctl -V "'imx290 2-001a':0 [fmt:SRGGB10_1X10/1920x1080 field:none colorspace:raw]" media-ctl -V "'csi':0 [fmt:SRGGB10_1X10/1920x1080 field:none colorspace:raw]" v4l2-ctl -d0 --set-fmt-video width=1920,height=1080,pixelformat='RG10',field=none media-ctl -p ``` The media-ctl topology is: ``` $ media-ctl -p Media controller API version 5.17.0 Media device information ------------------------ driver imx7-csi model imx-media serial bus info platform:32e20000.csi hw revision 0x0 driver version 5.17.0 Device topology - entity 1: csi (2 pads, 2 links) type V4L2 subdev subtype Unknown flags 0 device node name /dev/v4l-subdev0 pad0: Sink [fmt:SRGGB10_1X10/1920x1080 field:none colorspace:raw xfer:none ycbcr:601 quantization:full-range] <- "csis-32e30000.mipi-csi":1 [ENABLED,IMMUTABLE] pad1: Source [fmt:SRGGB10_1X10/1920x1080 field:none colorspace:raw xfer:none ycbcr:601 quantization:full-range] -> "csi capture":0 [ENABLED,IMMUTABLE] - entity 4: csi capture (1 pad, 1 link) type Node subtype V4L flags 0 device node name /dev/video0 pad0: Sink <- "csi":1 [ENABLED,IMMUTABLE] - entity 10: csis-32e30000.mipi-csi (2 pads, 2 links) type V4L2 subdev subtype Unknown flags 0 device node name /dev/v4l-subdev1 pad0: Sink [fmt:SRGGB10_1X10/1920x1080 field:none colorspace:raw] <- "imx290 2-001a":0 [ENABLED] pad1: Source [fmt:SRGGB10_1X10/1920x1080 field:none colorspace:raw] -> "csi":0 [ENABLED,IMMUTABLE] - entity 15: imx290 2-001a (1 pad, 1 link) type V4L2 subdev subtype Sensor flags 0 device node name /dev/v4l-subdev2 pad0: Source [fmt:SRGGB10_1X10/1920x1080 field:none colorspace:raw] -> "csis-32e30000.mipi-csi":0 [ENABLED] ``` Note: MIPI CSI settle times are not calculated correctly right now and need a manual overwrite: echo 13 > /sys/kernel/debug/32e30000.mipi-csi/ths_settle echo 2 > /sys/kernel/debug/32e30000.mipi-csi/tclk_settle I did not focus on v4l2-compliance tool, this is a future task. Regards, Alexander [1] https://patchwork.linuxtv.org/project/linux-media/patch/20211104113631.206899-2-dorota.czaplejewicz@puri.sm/ Alexander Stein (4): media: imx: imx7_media-csi: Add support for additional Bayer patterns media: imx: utils: Add more Bayer formats media: imx: utils: initialize local variable [DNI] arm64: dts: tqma8mqml: add IMX327 MIPI-CSI overlay Dorota Czaplejewicz (4): media: imx: Store the type of hardware implementation media: imx: Forward type of hardware implementation media: imx: Use dedicated format handler for i.MX7/8 media: imx: Fail conversion if pixel format not supported arch/arm64/boot/dts/freescale/Makefile | 4 + .../imx8mm-tqma8mqml-mba8mx-imx327.dts | 95 ++++++++++++ drivers/staging/media/imx/imx-ic-prpencvf.c | 3 +- drivers/staging/media/imx/imx-media-capture.c | 20 ++- drivers/staging/media/imx/imx-media-csi.c | 3 +- drivers/staging/media/imx/imx-media-utils.c | 136 +++++++++++++++++- drivers/staging/media/imx/imx-media.h | 11 +- drivers/staging/media/imx/imx7-media-csi.c | 15 +- 8 files changed, 271 insertions(+), 16 deletions(-) create mode 100644 arch/arm64/boot/dts/freescale/imx8mm-tqma8mqml-mba8mx-imx327.dts