mbox series

[v3,0/2] HDMI Audio on RK356x/Quartz64 Model A

Message ID 20220611065300.885212-1-frattaroli.nicolas@gmail.com (mailing list archive)
Headers show
Series HDMI Audio on RK356x/Quartz64 Model A | expand

Message

Nicolas Frattaroli June 11, 2022, 6:52 a.m. UTC 
This enables HDMI audio on Quartz64 Model A, and the RK356x SoC in
general.

i2s0 on the RK356x is connected to HDMI, and only has one DMA. I've
confirmed this with the TRM.

To test this, one needs a video clock, i.e. there is no audio if your
screen is off. The framebuffer console or something else needs to be
running to get audio output.

Changes in v3:
 - rebased onto next-20220610

Changes in v2:
 - reordered nodes in rk356x.dtsi to conform
 - reordered properties in rk356x.dtsi to conform
 - add Michael Riesch's Tested-by to rk356x.dtsi

Nicolas Frattaroli (2):
  arm64: dts: rockchip: rk356x: Add HDMI audio nodes
  arm64: dts: rockchip: Enable HDMI audio on Quartz64 A

 .../boot/dts/rockchip/rk3566-quartz64-a.dts   |  8 +++++
 arch/arm64/boot/dts/rockchip/rk356x.dtsi      | 33 +++++++++++++++++++
 2 files changed, 41 insertions(+)

Comments

Peter Geis June 11, 2022, 1:50 p.m. UTC | #1 
On Sat, Jun 11, 2022 at 2:53 AM Nicolas Frattaroli
<frattaroli.nicolas@gmail.com> wrote:
>
> This enables HDMI audio on Quartz64 Model A, and the RK356x SoC in
> general.
>
> i2s0 on the RK356x is connected to HDMI, and only has one DMA. I've
> confirmed this with the TRM.
>
> To test this, one needs a video clock, i.e. there is no audio if your
> screen is off. The framebuffer console or something else needs to be
> running to get audio output.

Excellent work!
Tested on Quartz64 Model A.
Tested-by: Peter Geis <pgwipeout@gmail.com>

>
> Changes in v3:
>  - rebased onto next-20220610
>
> Changes in v2:
>  - reordered nodes in rk356x.dtsi to conform
>  - reordered properties in rk356x.dtsi to conform
>  - add Michael Riesch's Tested-by to rk356x.dtsi
>
> Nicolas Frattaroli (2):
>   arm64: dts: rockchip: rk356x: Add HDMI audio nodes
>   arm64: dts: rockchip: Enable HDMI audio on Quartz64 A
>
>  .../boot/dts/rockchip/rk3566-quartz64-a.dts   |  8 +++++
>  arch/arm64/boot/dts/rockchip/rk356x.dtsi      | 33 +++++++++++++++++++
>  2 files changed, 41 insertions(+)
>
> --
> 2.36.1
>
Heiko Stuebner June 11, 2022, 3:15 p.m. UTC | #2 
On Sat, 11 Jun 2022 08:52:58 +0200, Nicolas Frattaroli wrote:
> This enables HDMI audio on Quartz64 Model A, and the RK356x SoC in
> general.
> 
> i2s0 on the RK356x is connected to HDMI, and only has one DMA. I've
> confirmed this with the TRM.
> 
> To test this, one needs a video clock, i.e. there is no audio if your
> screen is off. The framebuffer console or something else needs to be
> running to get audio output.
> 
> [...]

Applied, thanks!

[1/2] arm64: dts: rockchip: rk356x: Add HDMI audio nodes
      commit: 697ee8546e241bd5fc175c0cfd5d8b0c8ce39697
[2/2] arm64: dts: rockchip: Enable HDMI audio on Quartz64 A
      commit: 4188962d993ef3633a61f66ba5afe9e43088f3c5

Best regards,