From patchwork Wed Jun 22 13:04:36 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexander Stein X-Patchwork-Id: 12890612 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A7F36C43334 for ; Wed, 22 Jun 2022 13:06:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=H3FuMN+pdiPb+mtNo0JCOgTjJpaHUNXTsDwqsLR7GF4=; b=upCGayemejYvMQ swYFLpFVGE+ue5cZeeL5ZAg46QSP/RAAMiIK6Y6xoSLWzK/hdHGP6+7plBCRgF7MjbCOsBfGoriOg KJSJIYRXrpejkOBGONt8n6WwmI7YRaS+xRtDdgAK9U/IWlnvA8FmbAZf3yyZV15bOUUjS66lpAPFr K6W6bz2Lkb6ks6K1E55wmwObBIqZBGiPSmVrlDfce5/u9b5ZXYpk2xdoDsxObQgnureMVYs8sGplj 8SQGqf/TwScGl69vILAuDZ6imNRsizb5Q6W0ZrW0VTvymWZtevvSAoeaEDtZ++sL9MmRv9eGLbcmv HMyOl4xyQ80ankywwHnQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o402Q-00AP6H-Md; Wed, 22 Jun 2022 13:04:54 +0000 Received: from mx1.tq-group.com ([93.104.207.81]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o402M-00AP5V-QL for linux-arm-kernel@lists.infradead.org; Wed, 22 Jun 2022 13:04:52 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1655903090; x=1687439090; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=cD6loB9Vms5aqUj8mQhHVmslSoLHNbSElmDSCr9sutQ=; b=Cfgkklp+Qc75BuIq06Qtx0/++dcrm+8xoxe2EugQbAf5rBnQBcixkbTv OByGl0WlTlqIlS3Tjw3CvsUxfPmMKwkPJA9CSMAvpoLG1PHWLVeij0S4K P1aIcta9hXhQUyNPJLLKPweLRqWqLQ2xFiI6ZEIA2uwiXsHTNMEWPriae HWdvPkAUW8sgJzTDS/QnHf0E5D4CkQ8cJ8DYGSdhxPi2NhUDOwdc6O2E4 0+apJq7Hvxc3xIk0m8zt2iLz7oprAvpHnOw8MJLesw6aaHdA1pWAwHKJj aAySENjh1A1Il/OX506DBosLiNjbeHk6Ds5UV+KXXRo1ZSOB+TiLUHffK A==; X-IronPort-AV: E=Sophos;i="5.92,212,1650924000"; d="scan'208";a="24605516" Received: from unknown (HELO tq-pgp-pr1.tq-net.de) ([192.168.6.15]) by mx1-pgp.tq-group.com with ESMTP; 22 Jun 2022 15:04:47 +0200 Received: from mx1.tq-group.com ([192.168.6.7]) by tq-pgp-pr1.tq-net.de (PGP Universal service); Wed, 22 Jun 2022 15:04:47 +0200 X-PGP-Universal: processed; by tq-pgp-pr1.tq-net.de on Wed, 22 Jun 2022 15:04:47 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1655903087; x=1687439087; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=cD6loB9Vms5aqUj8mQhHVmslSoLHNbSElmDSCr9sutQ=; b=P4vqNL7Of/XK6UOV51rEoDKR0CLNJnmsmoAmsyASCqaTOygwBWq9z4ic VZ5SwJKXy6lYEGnj5d7VQ4G2ssi4qk91P39K0eJqbn4ILBYarfjXE7gpX deHwjiDlTS4zeb1f7RlBUhosZ+W9BJZkIIAVXIw5m87Lzdxcs/p+QhQIv xPa12GK3u6qOJIEP3Pk+GTTbdVCHV+pjt2mzfMmOt8hV1N4smBaVDpUAx b3+xc4AXaA5IkCE0CsKlcqGH/ZCeiDDuu4GpJZEUcbG3xF2YF1SJvJ6m1 Z0O7zo+HFwvvTcu70pL1U0+wvVnyxKbCNUvJ7xMegYR68qZ2D1WGswZGX A==; X-IronPort-AV: E=Sophos;i="5.92,212,1650924000"; d="scan'208";a="24605515" Received: from vtuxmail01.tq-net.de ([10.115.0.20]) by mx1.tq-group.com with ESMTP; 22 Jun 2022 15:04:47 +0200 Received: from steina-w.tq-net.de (unknown [10.123.49.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by vtuxmail01.tq-net.de (Postfix) with ESMTPSA id 23132280056; Wed, 22 Jun 2022 15:04:47 +0200 (CEST) From: Alexander Stein To: Greg Kroah-Hartman , Shawn Guo , Sascha Hauer , Fabio Estevam , Felipe Balbi Cc: Alexander Stein , linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [RFC PATCH 0/4] USB support for TQMa8MPxL + MBa8MPxL Date: Wed, 22 Jun 2022 15:04:36 +0200 Message-Id: <20220622130440.955465-1-alexander.stein@ew.tq-group.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220622_060451_281844_CF090D58 X-CRM114-Status: GOOD ( 19.17 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi everybody, this is an RFC for USB support on TQMa8MPxL + MBa8MPxL. DT support is currently in progress at [1]. This series is on top of that. The DT configuration itself (patch 4) is rather straight forward, but leads to the following dmesg errors regarding superspeed ports: > [ 8.549243] hub 2-1:1.0: hub_ext_port_status failed (err = -110) > [ 22.885263] usb 2-1: Failed to suspend device, error -110 This hardware works fine using the downstream kernel, because for imx8mp this ITP sync feature is enabled conditionally [2] & [3]. Hacking this into mainline resulted in a working superspeed setup as well. I also noticed that on some android kernel [4] depending in IP core version either GCTL.SOFTITPSYNC or GFLADJ.GFLADJ_REFCLK_LPM_SEL is enabled unconditionally. So I opted for the latter one using some quirk (patch 1-3). I have to admit I do not know what this is actually about, nor why my setup does not work without this change or why this fixed my problem. So maybe someone with more knowledge can say if this is the way to go or what this is about. Note: I excluded the DT guys (for now) as this is more about usb internals, the DT patches are for completeness. Thanks and best regards, Alexander [1] https://patchwork.kernel.org/project/linux-arm-kernel/cover/20220622114949.889274-1-alexander.stein@ew.tq-group.com/ [2] https://source.codeaurora.org/external/imx/linux-imx/tree/drivers/usb/dwc3/dwc3-imx8mp.c?h=lf-5.10.y#n134 [3] https://source.codeaurora.org/external/imx/linux-imx/tree/drivers/usb/dwc3/core.c?h=lf-5.10.y#n333 [4] https://android.googlesource.com/kernel/msm/+/87a6b154766907020cc74c7726e8a68aaa9d7f6b%5E%21/#F0 Alexander Stein (4): dt-bindings: usb: dwc3: Add gfladj-refclk-lpm-sel-quirk usb: dwc3: core: add gfladj_refclk_lpm_sel quirk arm64: dts: imx8mp: Add snps,gfladj-refclk-lpm-sel quirk to USB nodes arm64: dts: tqma8mpql: add USB support .../devicetree/bindings/usb/snps,dwc3.yaml | 5 ++ .../freescale/imx8mp-tqma8mpql-mba8mpxl.dts | 68 ++++++++++++++++++- arch/arm64/boot/dts/freescale/imx8mp.dtsi | 2 + drivers/usb/dwc3/core.c | 8 ++- drivers/usb/dwc3/core.h | 2 + 5 files changed, 83 insertions(+), 2 deletions(-)