[0/3] clk: bcm: rpi: Fixes and improvement

Message

Stefan Wahren July 13, 2022, 3:49 p.m. UTC

This series tries to fix and improvement the Raspberry Pi firmware clock
driver. This mostly focus on clock discovery mechanism.

Just a note patch #3 depends on patch #2.

Stefan Wahren (3):
  clk: bcm: rpi: Prevent out-of-bounds access
  clk: bcm: rpi: Add missing newline
  clk: bcm: rpi: Show clock id limit in error case

 drivers/clk/bcm/clk-raspberrypi.c | 14 ++++++++++----
 1 file changed, 10 insertions(+), 4 deletions(-)

Comments

Ivan T . Ivanov July 25, 2022, 8:18 a.m. UTC | #1

Hi,

On 07-13 17:49, Stefan Wahren wrote:
> 
> This series tries to fix and improvement the Raspberry Pi firmware clock
> driver. This mostly focus on clock discovery mechanism.
> 
> Just a note patch #3 depends on patch #2.
> 
> Stefan Wahren (3):
>   clk: bcm: rpi: Prevent out-of-bounds access
>   clk: bcm: rpi: Add missing newline
>   clk: bcm: rpi: Show clock id limit in error case
> 

Maybe is little bit late, but still :-)

Reviewed-by: Ivan T. Ivanov <[e-mail]>

Thank you!
Ivan

Florian Fainelli Aug. 4, 2022, 5:58 p.m. UTC | #2

On 7/25/22 01:18, Ivan T. Ivanov wrote:
> Hi,
> 
> On 07-13 17:49, Stefan Wahren wrote:
>>
>> This series tries to fix and improvement the Raspberry Pi firmware clock
>> driver. This mostly focus on clock discovery mechanism.
>>
>> Just a note patch #3 depends on patch #2.
>>
>> Stefan Wahren (3):
>>   clk: bcm: rpi: Prevent out-of-bounds access
>>   clk: bcm: rpi: Add missing newline
>>   clk: bcm: rpi: Show clock id limit in error case
>>
> 
> Maybe is little bit late, but still :-)
> 
> Reviewed-by: Ivan T. Ivanov <[e-mail]>

Stephen, can you apply those patches? Thanks!

Stefan Wahren Aug. 15, 2022, 6:15 p.m. UTC | #3

Hi Stephen,

Am 04.08.22 um 19:58 schrieb Florian Fainelli:
> On 7/25/22 01:18, Ivan T. Ivanov wrote:
>> Hi,
>>
>> On 07-13 17:49, Stefan Wahren wrote:
>>> This series tries to fix and improvement the Raspberry Pi firmware clock
>>> driver. This mostly focus on clock discovery mechanism.
>>>
>>> Just a note patch #3 depends on patch #2.
>>>
>>> Stefan Wahren (3):
>>>    clk: bcm: rpi: Prevent out-of-bounds access
>>>    clk: bcm: rpi: Add missing newline
>>>    clk: bcm: rpi: Show clock id limit in error case
>>>
>> Maybe is little bit late, but still :-)
>>
>> Reviewed-by: Ivan T. Ivanov <[e-mail]>
> Stephen, can you apply those patches? Thanks!

should i resend this series?

Best regards

Stephen Boyd Aug. 23, 2022, 10:50 p.m. UTC | #4

Quoting Stefan Wahren (2022-08-15 11:15:56)
> Hi Stephen,
> 
> Am 04.08.22 um 19:58 schrieb Florian Fainelli:
> > On 7/25/22 01:18, Ivan T. Ivanov wrote:
> >> Hi,
> >>
> >> On 07-13 17:49, Stefan Wahren wrote:
> >>> This series tries to fix and improvement the Raspberry Pi firmware clock
> >>> driver. This mostly focus on clock discovery mechanism.
> >>>
> >>> Just a note patch #3 depends on patch #2.
> >>>
> >>> Stefan Wahren (3):
> >>>    clk: bcm: rpi: Prevent out-of-bounds access
> >>>    clk: bcm: rpi: Add missing newline
> >>>    clk: bcm: rpi: Show clock id limit in error case
> >>>
> >> Maybe is little bit late, but still :-)
> >>
> >> Reviewed-by: Ivan T. Ivanov <[e-mail]>
> > Stephen, can you apply those patches? Thanks!
> 
> should i resend this series?
> 

No. Thanks!