mbox series

[v5,0/3] Add IMX8 SCU GPIO support

Message ID 20220812133012.7283-1-shenwei.wang@nxp.com (mailing list archive)
Headers show
Series Add IMX8 SCU GPIO support | expand

Message

Shenwei Wang Aug. 12, 2022, 1:30 p.m. UTC
The system controller (SCU) is the central unit to manage the resources
on i.MX8 platforms. The SCU firmware provides a set of APIs to access
the GPIO PINs on the SCU domain.

This patch series implements the standard GPIO driver over the SCU
firmware APIs, so that the GPIOs on the SCU domain could be accessed
like a local GPIO PINs.

Changes in V5:
 - rename the file name from fsl,imx-sc-gpio to fsl,imx8qxp-sc-gpio
   to match the compatible string

Changes in V4:
 - remove the generic compatible of "fsl,imx-sc-gpio"
 - update the gpio $ref in "fsl,scu.yaml" as the file name is changed
 - update the commit comment for 0003 because the driver is moved to the
   directory of "drivers/gpio"

Changes in V3:
 - follow the other imx8 SCU binding rule and rename the compatible string
   from fsl,imx8-scu-gpio to fsl,imx8qxp-sc-gpio
 - rename the doc file from fsl,imx8-scu-gpio.yaml to fsl,imx-sc-gpio.yaml

Changes in V2:
 - move the driver into the gpio directory per Krzysztof's feedback
 - change the subnode description in file fsl,scu.yaml
 - fix the dt_binding_check error

Shenwei Wang (3):
  dt-bindings: gpio: Add imx scu gpio driver bindings
  dt-bindings: firmware: imx: Add imx-scu gpio node
  gpio: imx-scu: add imx-scu GPIO driver

 .../devicetree/bindings/firmware/fsl,scu.yaml |   5 +
 .../bindings/gpio/fsl,imx8qxp-sc-gpio.yaml    |  39 +++++
 drivers/gpio/Kconfig                          |   4 +
 drivers/gpio/Makefile                         |   1 +
 drivers/gpio/gpio-imx-scu.c                   | 139 ++++++++++++++++++
 5 files changed, 188 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/gpio/fsl,imx8qxp-sc-gpio.yaml
 create mode 100644 drivers/gpio/gpio-imx-scu.c

--
2.25.1

Comments

Linus Walleij Aug. 22, 2022, 8:51 a.m. UTC | #1
On Fri, Aug 12, 2022 at 3:30 PM Shenwei Wang <shenwei.wang@nxp.com> wrote:

> Changes in V5:
>  - rename the file name from fsl,imx-sc-gpio to fsl,imx8qxp-sc-gpio
>    to match the compatible string

v5 looks good to me!
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

Yours,
Linus Walleij
Bartosz Golaszewski Aug. 31, 2022, 3:21 p.m. UTC | #2
On Fri, Aug 12, 2022 at 3:30 PM Shenwei Wang <shenwei.wang@nxp.com> wrote:
>
> The system controller (SCU) is the central unit to manage the resources
> on i.MX8 platforms. The SCU firmware provides a set of APIs to access
> the GPIO PINs on the SCU domain.
>
> This patch series implements the standard GPIO driver over the SCU
> firmware APIs, so that the GPIOs on the SCU domain could be accessed
> like a local GPIO PINs.
>
> Changes in V5:
>  - rename the file name from fsl,imx-sc-gpio to fsl,imx8qxp-sc-gpio
>    to match the compatible string
>
> Changes in V4:
>  - remove the generic compatible of "fsl,imx-sc-gpio"
>  - update the gpio $ref in "fsl,scu.yaml" as the file name is changed
>  - update the commit comment for 0003 because the driver is moved to the
>    directory of "drivers/gpio"
>
> Changes in V3:
>  - follow the other imx8 SCU binding rule and rename the compatible string
>    from fsl,imx8-scu-gpio to fsl,imx8qxp-sc-gpio
>  - rename the doc file from fsl,imx8-scu-gpio.yaml to fsl,imx-sc-gpio.yaml
>
> Changes in V2:
>  - move the driver into the gpio directory per Krzysztof's feedback
>  - change the subnode description in file fsl,scu.yaml
>  - fix the dt_binding_check error
>
> Shenwei Wang (3):
>   dt-bindings: gpio: Add imx scu gpio driver bindings
>   dt-bindings: firmware: imx: Add imx-scu gpio node
>   gpio: imx-scu: add imx-scu GPIO driver
>
>  .../devicetree/bindings/firmware/fsl,scu.yaml |   5 +
>  .../bindings/gpio/fsl,imx8qxp-sc-gpio.yaml    |  39 +++++
>  drivers/gpio/Kconfig                          |   4 +
>  drivers/gpio/Makefile                         |   1 +
>  drivers/gpio/gpio-imx-scu.c                   | 139 ++++++++++++++++++
>  5 files changed, 188 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/gpio/fsl,imx8qxp-sc-gpio.yaml
>  create mode 100644 drivers/gpio/gpio-imx-scu.c
>
> --
> 2.25.1
>

Applied the series, thanks!

Bart