mbox series

[v1,0/7] drm/vc4: Fix the core clock behaviour

Message ID 20220815-rpi-fix-4k-60-v1-0-c52bd642f7c6@cerno.tech (mailing list archive)
Headers show
Series drm/vc4: Fix the core clock behaviour | expand

Message

Maxime Ripard Aug. 15, 2022, 3:31 p.m. UTC 
Hi,

Those patches used to be part of a larger clock fixes series:
https://lore.kernel.org/linux-clk/20220715160014.2623107-1-maxime@cerno.tech/

However, that series doesn't seem to be getting anywhere, so I've split out
these patches that fix a regression that has been there since 5.18 and that
prevents the 4k output from working on the RaspberryPi4.

Hopefully, we will be able to merge those patches through the DRM tree to avoid
any further disruption.

Let me know what you think,
Maxime

---
Dom Cobley (1):
      drm/vc4: hdmi: Add more checks for 4k resolutions

Maxime Ripard (6):
      clk: bcm: rpi: Create helper to retrieve private data
      clk: bcm: rpi: Add a function to retrieve the maximum
      clk: bcm: rpi: Add a function to retrieve the minimum
      drm/vc4: hdmi: Fix hdmi_enable_4kp60 detection
      drm/vc4: hdmi: Rework hdmi_enable_4kp60 detection code
      drm/vc4: Make sure we don't end up with a core clock too high

 drivers/clk/bcm/clk-raspberrypi.c        | 73 ++++++++++++++++++++++++++++----
 drivers/gpu/drm/vc4/vc4_drv.h            | 14 ++++++
 drivers/gpu/drm/vc4/vc4_hdmi.c           | 25 +++++------
 drivers/gpu/drm/vc4/vc4_hdmi.h           |  8 ----
 drivers/gpu/drm/vc4/vc4_hvs.c            | 13 ++++++
 drivers/gpu/drm/vc4/vc4_kms.c            | 17 +++++---
 include/soc/bcm2835/raspberrypi-clocks.h | 21 +++++++++
 7 files changed, 138 insertions(+), 33 deletions(-)
---
base-commit: 568035b01cfb107af8d2e4bd2fb9aea22cf5b868
change-id: 20220815-rpi-fix-4k-60-17273650429d

Best regards,

Comments

Maxime Ripard Aug. 29, 2022, 3:11 p.m. UTC | #1 
Hi Stephen, Mike,

On Mon, Aug 15, 2022 at 05:31:22PM +0200, Maxime Ripard wrote:
> Those patches used to be part of a larger clock fixes series:
> https://lore.kernel.org/linux-clk/20220715160014.2623107-1-maxime@cerno.tech/
> 
> However, that series doesn't seem to be getting anywhere, so I've split out
> these patches that fix a regression that has been there since 5.18 and that
> prevents the 4k output from working on the RaspberryPi4.
> 
> Hopefully, we will be able to merge those patches through the DRM tree to avoid
> any further disruption.

I've ping'd Stephen privately on IRC multiple times, and it's basically
a resend of the previous clock series linked above that has been around
since almost a month and a half.

Can you Ack the first three patches so we can merge those patches
through the DRM tree and close this regression?

Maxime