From patchwork Wed Sep 21 04:55:58 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bhupesh Sharma X-Patchwork-Id: 12983228 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E6219C32771 for ; Wed, 21 Sep 2022 04:57:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=5372/o1Q/zdYhYP6C7BAJnH6VH4VN7NQMLu3vNxinUM=; b=Pf47f0QxaUKsIa csAWNgzNWIN3nfI3Rn0ZSW8AehdrA8Is8cK5woXFMa7GJFXiRXrJ38YGIp32FRPhmhN+yL434x8yc YUMiATT2s8b6gUeiCXeXzYhCizYNwVMZE0CCaaxJ/cfJDNNOFFho/rRYtJIL/19XrlI1SIXv8tonu 2+PL2gF8iWlNLlIelJs5kWKE/ujC/rWo2hXmACkGL0vtHWXVHEFr/pk9u3ZrS9o77y9/tz+hEyGBK B7eGSII6TJfWw3/o+SU96ekUn8xTvZvxqohVUnGkSbGXmNnpWcKHtlv6ijwB/QKx1smeyAZj+c+ui H884oXf0/ONqSgrlE/fg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oarmW-008uxs-Gt; Wed, 21 Sep 2022 04:56:20 +0000 Received: from mail-pl1-x635.google.com ([2607:f8b0:4864:20::635]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oarmT-008uwF-AE for linux-arm-kernel@lists.infradead.org; Wed, 21 Sep 2022 04:56:19 +0000 Received: by mail-pl1-x635.google.com with SMTP id b21so4494500plz.7 for ; Tue, 20 Sep 2022 21:56:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date; bh=uLS0pqX8ABlHPyY6IrFy7TWkhrlEvTMPKR/GQlZ1z0w=; b=hNex4eY8EhXjnt1674fczrOqm70GjFPvOV1SNGPjimcyMKTk2Jh5me9A1MpxXqw39r iJf0sJrHHqz3rzTJF2FltTmteto7EU4nfh7HfjIxFcvLwG7fwnIju+VC/A+F98h+h0cD l/v2jC3fOkRIpIvZn/3DxFbtwM8d6gVOyqVYrRFJ2JlXWjl1vpxg92Dg+SGtWK39Affi eSMBCnqEPlb/VDKmziCuN8m5R41/EhIlES8lhm/qPqIBHGZ81VifTJpnEbEUTHwsd6PR lK1wo0ZqJL2G9RktxofIa1MhsrRxrS0ZZXtmRvAHObgrI8nBfZ36SSYjncl6g7KL58+H PDIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date; bh=uLS0pqX8ABlHPyY6IrFy7TWkhrlEvTMPKR/GQlZ1z0w=; b=0Rnq2nFNP0T/vgpL3fpL54Gvx05qKGLT0vBDdEhpJef9yZrYC7wvPuJ0Nkn71w72aM h1K13LtknZWkGddydsh54j7UOC7M/dUGDH2JwCBvxMgj0sqQ4Y9EB0Q/zrB7xk3pSLiv g5a1dgFLCwzjCdGzVkH640jJhWc8XLYKZUd893dDAKhvh2rLZ7lenCkiNgqyubO1wqeY /Uo4XDSgbI2aDlhhQklj+cI2+Sh2SNuef5cp0i8Zqqzx0ku0G2D6TDPnKZFNzfNzyEFn II389B+it8L9T/xL40ZhlRndfY9a37f0zTuHbD1SNAXpZp+54NRXcOPqLSPNNTVEmDxc gENA== X-Gm-Message-State: ACrzQf2hRSHi2jGoX55xqZwxP2smU2TXqCxIocljMWRmxqEBB/f8xHPP KioQBdCY2SdqQuAODNL+TiSiV89JCSgQGw== X-Google-Smtp-Source: AMsMyM5nWzgZ2Rl60J9B4u0WHGfzX97RusUs4fUlT2dpP12UcASoz+ZehA35R85RZDRSQO/R+ynJRg== X-Received: by 2002:a17:902:b7c6:b0:178:b625:e9f7 with SMTP id v6-20020a170902b7c600b00178b625e9f7mr2959524plz.128.1663736173521; Tue, 20 Sep 2022 21:56:13 -0700 (PDT) Received: from localhost.localdomain ([2401:4900:1c61:8e50:8ba8:7ad7:f34c:2f5]) by smtp.gmail.com with ESMTPSA id p12-20020a170902e74c00b00176e2fa216csm871829plf.52.2022.09.20.21.56.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Sep 2022 21:56:12 -0700 (PDT) From: Bhupesh Sharma To: linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org Cc: agross@kernel.org, linux-kernel@vger.kernel.org, robh+dt@kernel.org, thara.gopinath@gmail.com, devicetree@vger.kernel.org, robh@kernel.org, krzysztof.kozlowski@linaro.org, andersson@kernel.org, bhupesh.sharma@linaro.org, bhupesh.linux@gmail.com, catalin.marinas@arm.com, will@kernel.org, arnd@arndb.de, Jordan Crouse Subject: [PATCH v7 0/4] ARM: dts + defconfig: Add support for Qualcomm QCE block on new SoCs and in defconfig Date: Wed, 21 Sep 2022 10:25:58 +0530 Message-Id: <20220921045602.1462007-1-bhupesh.sharma@linaro.org> X-Mailer: git-send-email 2.37.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220920_215617_410047_21DE31A2 X-CRM114-Status: GOOD ( 19.08 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Changes since v6: ================= - v6 can be seen here: https://lore.kernel.org/linux-arm-msm/30756e6f-952f-ccf2-b493-e515ba4f0a64@linaro.org/ - No code changes since v6. - As per Krzysztof's suggestion on v6, clubbed the crypto driver and dt-bindings changes together. Now the overall v5 patchset into 3 separate patchsets, one each for the following areas to allow easier review and handling from the maintainer: arm-msm, crypto and dma - This patch targets the arm/arm-msm tree specifically. - This patchset is dependent on the crypto + dt-binding patchset, which can be seen here: https://lore.kernel.org/linux-arm-msm/20220920114051.1116441-1-bhupesh.sharma@linaro.org/ Changes since v5: ================= - v5 can be seen here: https://lore.kernel.org/lkml/20211110105922.217895-1-bhupesh.sharma@linaro.org/ - As per Bjorn's suggestion on irc, broke down the patchset into 4 separate patchsets, one each for the following areas to allow easier review and handling from the respective maintainer(s): 'arm-msm', 'crypto', 'dma' and 'devicetree' This patchset is directed for the 'arm-msm' tree / area. - Addressed Rob's, Vladimir's and Bjorn's review comments on v5. - Added Tested-by from Jordan received on the v5. - Also added a 'defconfig' change where I enabled the QCE block as a module. Changes since v4: ================= - v4 for sm8250 can be seen here: https://lore.kernel.org/linux-arm-msm/20211013105541.68045-1-bhupesh.sharma@linaro.org/ - v1 for sm8150 qce enablement can be seen here: https://lore.kernel.org/linux-arm-msm/20211013165823.88123-1-bhupesh.sharma@linaro.org/ - Merged the sm8150 and sm8250 enablement patches in the same patchset, as per suggestions from Bjorn. - Dropped a couple of patches from v4, as these have been picked by Bjorn already via his tree. - Addressed review comments from Vladimir, Thara and Rob. - Collect Reviewed-by from Rob and Thara on some of the patches from the v4 patchset. Changes since v3: ================= - v3 can be seen here: https://lore.kernel.org/linux-arm-msm/20210519143700.27392-1-bhupesh.sharma@linaro.org/ - Dropped a couple of patches from v3, on basis of the review comments: ~ [PATCH 13/17] crypto: qce: core: Make clocks optional ~ [PATCH 15/17] crypto: qce: Convert the device found dev_dbg() to dev_info() - Addressed review comments from Thara, Rob and Stephan Gerhold. - Collect Reviewed-by from Rob and Thara on some of the patches from the v3 patchset. Changes since v2: ================= - v2 can be seen here: https://lore.kernel.org/dmaengine/20210505213731.538612-1-bhupesh.sharma@linaro.org/ - Drop a couple of patches from v1, which tried to address the defered probing of qce driver in case bam dma driver is not yet probed. Replace it instead with a single (simpler) patch [PATCH 16/17]. - Convert bam dma and qce crypto dt-bindings to YAML. - Addressed review comments from Thara, Bjorn, Vinod and Rob. Changes since v1: ================= - v1 can be seen here: https://lore.kernel.org/linux-arm-msm/20210310052503.3618486-1-bhupesh.sharma@linaro.org/ - v1 did not work well as reported earlier by Dmitry, so v2 contains the following changes/fixes: ~ Enable the interconnect path b/w BAM DMA and main memory first before trying to access the BAM DMA registers. ~ Enable the interconnect path b/w qce crytpo and main memory first before trying to access the qce crypto registers. ~ Make sure to document the required and optional properties for both BAM DMA and qce crypto drivers. ~ Add a few debug related print messages in case the qce crypto driver passes or fails to probe. ~ Convert the qce crypto driver probe to a defered one in case the BAM DMA or the interconnect driver(s) (needed on specific Qualcomm parts) are not yet probed. Qualcomm crypto engine (qce) is available on several Snapdragon SoCs. The qce block supports hardware accelerated algorithms for encryption and authentication. It also provides support for aes, des, 3des encryption algorithms and sha1, sha256, hmac(sha1), hmac(sha256) authentication algorithms. Tested the enabled crypto algorithms with cryptsetup test utilities on sm8150-mtp, sa8155p-adp, sm8250-mtp and RB5 boards (see [1]) and also with crypto self-tests, including the fuzz tests (CONFIG_CRYPTO_MANAGER_EXTRA_TESTS=y). [1]. https://linux.die.net/man/8/cryptsetup Cc: thara.gopinath@gmail.com Cc: robh@kernel.org Cc: andersson@kernel.org Tested-by: Jordan Crouse Bhupesh Sharma (4): ARM: dts: qcom: Use new compatibles for crypto nodes arm64: dts: qcom: sm8250: Add dt entries to support crypto engine. arm64: dts: qcom: sm8150: Add dt entries to support crypto engine. arm64: defconfig: Enable Qualcomm QCE crypto arch/arm/boot/dts/qcom-ipq4019.dtsi | 2 +- arch/arm64/boot/dts/qcom/ipq6018.dtsi | 2 +- arch/arm64/boot/dts/qcom/ipq8074.dtsi | 2 +- arch/arm64/boot/dts/qcom/msm8996.dtsi | 2 +- arch/arm64/boot/dts/qcom/sdm845.dtsi | 2 +- arch/arm64/boot/dts/qcom/sm8150.dtsi | 28 +++++++++++++++++++++++++++ arch/arm64/boot/dts/qcom/sm8250.dtsi | 28 +++++++++++++++++++++++++++ arch/arm64/configs/defconfig | 1 + 8 files changed, 62 insertions(+), 5 deletions(-)