From patchwork Tue Oct 18 12:43:37 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Li Huafei X-Patchwork-Id: 13010490 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CE09EC433FE for ; Tue, 18 Oct 2022 12:48:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:Subject:CC :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=+6ZYn/nXVst6T+3FhPl6pAdyBEXShpyUY94Xt4CMPqA=; b=S5OZ1Pe/0pRZzh gAbH4UDWV1ZHRrt+JU2yOqmCXI7zN3E6qmDViszda0Uggzqtqp6QZ/PLrcPiebH0YD/ZfT24f5wUp NxStw5val1WBeJc932XwW75G29vnbxDkytpeNnkyHa3zUqm7VfSYkmeF6FQq1F/YtuVhaxsTGe44j Ft7qMdz8lhXMhdoCz0LCdxRe0FyrFOf95q6hVt4CzH26KfVyxqxHhk3cLiOuFx0ilEDM6gDv6xJ92 RHKBJTv1Wrbm0g4Og3UJ0fZUdrWuJtxkjRnp4mHzlRVxy4HlkYa2fog6eOsKFhZNZylshcTJskLnn 31NsSEmCWXYKOc1IWduQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1okm07-006iRr-IJ; Tue, 18 Oct 2022 12:47:19 +0000 Received: from szxga03-in.huawei.com ([45.249.212.189]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1okm01-006iMf-Nt for linux-arm-kernel@lists.infradead.org; Tue, 18 Oct 2022 12:47:16 +0000 Received: from dggemv711-chm.china.huawei.com (unknown [172.30.72.55]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4MsD8B5qhhzJn2r; Tue, 18 Oct 2022 20:44:26 +0800 (CST) Received: from kwepemm600010.china.huawei.com (7.193.23.86) by dggemv711-chm.china.huawei.com (10.1.198.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Tue, 18 Oct 2022 20:47:04 +0800 Received: from ubuntu1804.huawei.com (10.67.174.174) by kwepemm600010.china.huawei.com (7.193.23.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Tue, 18 Oct 2022 20:47:03 +0800 From: Li Huafei To: , CC: , , , , , , , , , , , , , , , , , , , , , , Subject: [PATCH v4 0/2] ARM: Convert to ARCH_STACKWALK Date: Tue, 18 Oct 2022 20:43:37 +0800 Message-ID: <20221018124339.115793-1-lihuafei1@huawei.com> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 X-Originating-IP: [10.67.174.174] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To kwepemm600010.china.huawei.com (7.193.23.86) X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221018_054714_152437_AE1DBE16 X-CRM114-Status: GOOD ( 13.69 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org This series mainly updates the ARM stack trace code to use the newer and simpler arch_stack_walk() interface. When Russell applied patch 1, the patch tracker complained of a minor conflict with Lei Zhen's patch (see [1]). Lei Zhen's patch has been merged into v6.1-rc1. Now rebase to v6.1-rc1 and resend this patch set. Thanks! [1] https://www.armlinux.org.uk/developer/patches/viewpatch.php?id=9235/1 v4: - Rebase to v6.1-rc1. - Fix commit log for patch 2: 'arch _stack_walk()' -> 'arch_stack_walk()'. - Remove the two bugfix patches that have been merged in: ARM: stacktrace: Skip frame pointer boundary check for call_with_stack() ARM: stacktrace: Avoid duplicate saving of exception PC value v3 resend: https://lore.kernel.org/lkml/20220826074047.107357-1-lihuafei1@huawei.com/ It's been a month since I sent the v3. Linus told me I needed to add the patch to Russell's patch tracker myself, rebase to v6.0-rc1 before that. Thanks Linus for the tip! Since commit af6f23b88e95 ("ARM/dma-mapping: use the generic versions of dma_to_phys/phys_to_dma by default") and commit ae626eb97376 ("ARM/dma-mapping: use dma-direct unconditionally") modified arch/arm/Kconfig, there is a minor conflict with patch 4 when rebase. v3: https://lore.kernel.org/lkml/20220727040022.139387-1-lihuafei1@huawei.com/ - According to the discussion with Linus and Russell in v1: - Add a comment about "regs[1]" in patch 2, and remove the unnecessary ternary operator in the initialization of "frame->ex_frame". - Remove the patch "ARM: stacktrace: Allow stack trace saving for non-current tasks", and keep the check for not being able to unwind non-current tasks (including tasks running on other CPUs) when CONFIG_SMP=y in patch 4. - Rebase to linux-5.19-rc8. v2: https://lore.kernel.org/lkml/20220713110020.85511-1-lihuafei1@huawei.com/ - As suggested by Mark, the commit logs for patch 4 and 5 were refined for easy review. v1: https://lore.kernel.org/lkml/20220712021527.109921-1-lihuafei1@huawei.com/ Li Huafei (2): ARM: stacktrace: Make stack walk callback consistent with generic code ARM: stacktrace: Convert stacktrace to generic ARCH_STACKWALK arch/arm/Kconfig | 1 + arch/arm/include/asm/stacktrace.h | 2 +- arch/arm/kernel/perf_callchain.c | 9 +-- arch/arm/kernel/return_address.c | 8 +- arch/arm/kernel/stacktrace.c | 119 +++++++++--------------------- 5 files changed, 44 insertions(+), 95 deletions(-)