[v2,0/3] media: rkisp1: Miscellaneous improvements

Message

Paul Elder Nov. 17, 2022, 8:42 a.m. UTC

This patch series adds small improvements to the rkisp1 driver:
- Add NV16M and NV61M output
- Implement ENUM_FRAMESIZES

As well as a small code cleanup.

These patches have been sent before individually, so really this is a
resend, which also bunches them together.

Laurent Pinchart (1):
  media: rkisp1: Make local immutable array variables static const

Paul Elder (2):
  media: rkisp1: Add NV16M and NV61M to output formats
  media: rkisp1: Implement ENUM_FRAMESIZES

 .../platform/rockchip/rkisp1/rkisp1-capture.c | 64 +++++++++++++++++--
 1 file changed, 60 insertions(+), 4 deletions(-)

Comments

Jacopo Mondi Feb. 21, 2023, 1:57 p.m. UTC | #1

Hello

On Thu, Nov 17, 2022 at 05:42:14PM +0900, Paul Elder wrote:
> This patch series adds small improvements to the rkisp1 driver:
> - Add NV16M and NV61M output
> - Implement ENUM_FRAMESIZES
>
> As well as a small code cleanup.
>
> These patches have been sent before individually, so really this is a
> resend, which also bunches them together.
>
> Laurent Pinchart (1):
>   media: rkisp1: Make local immutable array variables static const
>
> Paul Elder (2):
>   media: rkisp1: Add NV16M and NV61M to output formats
>   media: rkisp1: Implement ENUM_FRAMESIZES

Has this series fell into cracks ? Support for VIDIOC_ENUM_FRAMESIZES
in particular is a relevant feature and seems not controversial at all...

>
>  .../platform/rockchip/rkisp1/rkisp1-capture.c | 64 +++++++++++++++++--
>  1 file changed, 60 insertions(+), 4 deletions(-)
>
> --
> 2.35.1
>

Laurent Pinchart March 25, 2023, 8 p.m. UTC | #2

Hi Jacopo,

On Tue, Feb 21, 2023 at 02:57:30PM +0100, Jacopo Mondi wrote:
> On Thu, Nov 17, 2022 at 05:42:14PM +0900, Paul Elder wrote:
> > This patch series adds small improvements to the rkisp1 driver:
> > - Add NV16M and NV61M output
> > - Implement ENUM_FRAMESIZES
> >
> > As well as a small code cleanup.
> >
> > These patches have been sent before individually, so really this is a
> > resend, which also bunches them together.
> >
> > Laurent Pinchart (1):
> >   media: rkisp1: Make local immutable array variables static const
> >
> > Paul Elder (2):
> >   media: rkisp1: Add NV16M and NV61M to output formats
> >   media: rkisp1: Implement ENUM_FRAMESIZES
> 
> Has this series fell into cracks ? Support for VIDIOC_ENUM_FRAMESIZES
> in particular is a relevant feature and seems not controversial at all...

An alternative version of the first patch has been merged already, and
I've just sent a pull request for the other two.

> >  .../platform/rockchip/rkisp1/rkisp1-capture.c | 64 +++++++++++++++++--
> >  1 file changed, 60 insertions(+), 4 deletions(-)