[v5,net-next,0/3] net: axienet: Use a DT property to configure frequency of the MDIO bus

Message

Andy Chiu Nov. 17, 2022, 3:40 p.m. UTC

Some FPGA platforms have to set frequency of the MDIO bus lower than 2.5
MHz. Thus, we use a DT property, which is "clock-frequency", to work
with it at boot time. The default 2.5 MHz would be set if the property
is not pressent. Also, factor out mdio enable/disable functions due to
the api change since 253761a0e61b7.

Changelog:
--- v5 ---
1. Make dt-binding patch prior to the implementation patch.
2. Disable mdio bus in error path.
3. Update description of some functions.
--- v4 ---
1. change MAX_MDIO_FREQ to DEFAULT_MDIO_FREQ as suggested by Andrew.
--- v3 RESEND ---
1. Repost the exact same patch again
--- v3 ---
1. Fix coding style, and make probing of the driver fail if MDC overflow
--- v2 ---
1. Use clock-frequency, as defined in mdio.yaml, to configure MDIO
   clock.
2. Only print out frequency if it is set to a non-standard value.
3. Reduce the scope of axienet_mdio_enable and remove
   axienet_mdio_disable because no one really uses it anymore.

Andy Chiu (3):
  net: axienet: Unexport and remove unused mdio functions
  dt-bindings: describe the support of "clock-frequency" in mdio
  net: axienet: set mdio clock according to bus-frequency

 .../bindings/net/xilinx_axienet.txt           |  2 +
 drivers/net/ethernet/xilinx/xilinx_axienet.h  |  2 -
 .../net/ethernet/xilinx/xilinx_axienet_mdio.c | 79 +++++++++++--------
 3 files changed, 50 insertions(+), 33 deletions(-)

Comments

[e-mail] Nov. 21, 2022, 10:40 a.m. UTC | #1

Hello:

This series was applied to netdev/net-next.git (master)
by David S. Miller <[e-mail]>:

On Thu, 17 Nov 2022 23:40:11 +0800 you wrote:
> Some FPGA platforms have to set frequency of the MDIO bus lower than 2.5
> MHz. Thus, we use a DT property, which is "clock-frequency", to work
> with it at boot time. The default 2.5 MHz would be set if the property
> is not pressent. Also, factor out mdio enable/disable functions due to
> the api change since 253761a0e61b7.
> 
> Changelog:
> 
> [...]

Here is the summary with links:
  - [v5,net-next,1/3] net: axienet: Unexport and remove unused mdio functions
    https://git.kernel.org/netdev/net-next/c/29f8eefba3ba
  - [v5,net-next,2/3] dt-bindings: describe the support of "clock-frequency" in mdio
    https://git.kernel.org/netdev/net-next/c/6830604ec0c7
  - [v5,net-next,3/3] net: axienet: set mdio clock according to bus-frequency
    https://git.kernel.org/netdev/net-next/c/2e1f2c1066c1

You are awesome, thank you!