From patchwork Mon Nov 28 14:05:16 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Georgi Vlaev X-Patchwork-Id: 13057548 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DF60DC433FE for ; Mon, 28 Nov 2022 14:06:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:Subject:CC :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=UaafSxbvftKU/ksc/G6QPl6qSgJyIiEtZlCPKdZAmes=; b=HHm0+R1Cs0UHgT I5YsCPBnPDfjg5LPch2WhcBllk5Ms6dFZ+PXE9c97d+eFCRJZD+70jqPi9w221JiMa1nIJilRBhf0 9I8iCwbTOaQGfki86FOrHsRdMeqCp6ac7tK4+hDOlKZYrNQ5FloRYcD3/hfLaNut9mED+aX6+FF/u gWKS0+g7F1zpiZN4IojXG3bjslePCbOHJxr/F4hKmHZtI2hJ32CLS//k5B9wnmSC/XXiUmoUYCogI toPl8m51rrzXmDJ8GlMGF17/lK0NhGjK5Fx0G+zyzBq+b5f8De+0vS/5Qdv4R8asSQ5/7cP8dg6mZ imEYx16De2vdbw8o+NTw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ozelV-00247K-A6; Mon, 28 Nov 2022 14:05:45 +0000 Received: from lelv0142.ext.ti.com ([198.47.23.249]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ozelR-00244r-Fi for linux-arm-kernel@lists.infradead.org; Mon, 28 Nov 2022 14:05:43 +0000 Received: from lelv0265.itg.ti.com ([10.180.67.224]) by lelv0142.ext.ti.com (8.15.2/8.15.2) with ESMTP id 2ASE5UFl080196; Mon, 28 Nov 2022 08:05:30 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1669644330; bh=suB2wvVLmMI0fwbk/GMLtYWSvPHngTiQ5DE/mjnQeZk=; h=From:To:CC:Subject:Date; b=bbs0pD8AG0KEi+4TyWL5thZtrzY9rktHdbd3PbhlEUlyY8qE9Dvwmsm6un2mY2RM5 0anGaux2oQJIxQg8Wvzv0gql3W/PYTHQS21h47SjVrowO84ks86/x7kyscKa8jxtkd Cqbbo6o/lQs6VOQXopwwqkB6NFkSqBtG0DOxZv/8= Received: from DFLE106.ent.ti.com (dfle106.ent.ti.com [10.64.6.27]) by lelv0265.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 2ASE5UEO023655 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 28 Nov 2022 08:05:30 -0600 Received: from DFLE100.ent.ti.com (10.64.6.21) by DFLE106.ent.ti.com (10.64.6.27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.16; Mon, 28 Nov 2022 08:05:30 -0600 Received: from fllv0039.itg.ti.com (10.64.41.19) by DFLE100.ent.ti.com (10.64.6.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.16 via Frontend Transport; Mon, 28 Nov 2022 08:05:30 -0600 Received: from jti.ent.ti.com (ileaxei01-snat2.itg.ti.com [10.180.69.6]) by fllv0039.itg.ti.com (8.15.2/8.15.2) with ESMTP id 2ASE5NQZ125815; Mon, 28 Nov 2022 08:05:24 -0600 From: Georgi Vlaev To: Nishanth Menon , Tero Kristo , Santosh Shilimkar , Rob Herring , Krzysztof Kozlowski CC: , , , Vibhore Vardhan , Vignesh Raghavendra , Roger Quadros , Georgi Vlaev Subject: [PATCH v5 0/5] firmware: ti_sci: Introduce system suspend support Date: Mon, 28 Nov 2022 16:05:16 +0200 Message-ID: <20221128140522.49474-1-g-vlaev@ti.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221128_060541_714112_4F6E2D7F X-CRM114-Status: GOOD ( 20.67 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org This series introduces necessary ti_sci driver functionality in preparation of supporting DeepSleep mode for suspend to mem on TI K3 AM62x. This version is a fixup and rebase of the patch series by Dave Gerlach [1]. It applies on top of v6.1-rc7. Deep Sleep mode is described in section "5.2.4.4 DeepSleep" of the AM62x Technical Reference Manual [2]. The kernel triggers entry to Deep Sleep mode through the mem suspend transition with the following: * Use a TF-A binary that supports PSCI_SYSTEM_SUSPEND call. This causes system to use PSCI system suspend as last step of mem sleep. * The firmware requires that the OS sends a TISCI_MSG_PREPARE_SLEEP message in order to provide details about suspend, so we must add the ability to send this message. We also add TISCI_MSG_LPM_WAKE_REASON and TISCI_MSG_SET_IO_ISOLATION messages as part of a new PM ops. These messages are part of the TISCI PM Low Power Mode API [3]. (Patch 2) * A memory address must be provided to the firmware using the above message, which is allocated and managed by dma_alloc_coherent() and friends. (Patch 3) * System must load firmware to a specific location before Deep Sleep is entered, and this is accomplished using a memory region in device tree to indicate where this firmware should be loaded, and also a "firmware-name" property to indicate the name of the firmware to load. The ti_sci driver checks in its pm handler to see if the firmware has been loaded and if not, loads it. (Patch 4) * Finally, the ti_sci driver must actually send TISCI_MSG_PREPARE_SLEEP message to firmware with the above information included, which it does during the driver suspend handler when PM_MEM_SUSPEND is the determined state being entered. (Patch 5) This is tested on am625-sk using a limited dts with all devices disabled apart from cpu0, main_uart0, i2c, rtc, mmc/sd, dmsc, and secure_proxy_main. Testing this sequence requires K3 sdhci suspend/resume support [4], enable the wkup_rtc in the am625-sk.dts, disable devices that don't support system suspend/resume like OSPI and CPSW3G. In can be tested on the following branch: https://github.com/gvlaev/linux/tree/upstream-v6.2/lpm-ti-sci-v4 Changelog: v5: - Add support (patch 3) for detecting the low power modes (LPM) of the FW/SoC with a recently introduced core TISCI_MSG_QUERY_FW_CAPS message. - Use TISCI_MSG_QUERY_FW_CAPS instead of misusing the TISCI_MSG_PREPARE_SLEEP to detect the FW/SoC low power caps (patch 4). - Take into account the supported LPMs in ti_sci_prepare_system_suspend() and handle the case when CONFIG_SUSPEND is not enabled (patch 6) that was reported by Roger Quadros and LKP. - Pick up Rob Herring's "Reviewed-by" tag for the binding patch. v4: - Fix checkpacth warnings in patches 2 and 3. - Drop the links with anchors in patch 2. v3: - Fix the compile warnings on 32-bit platforms reported by the kernel test robot in patches (3,5). - Pick up Roger's "Tested-by" tags. v2: - Addressed comments received for v1 series [1]. - Updated v1 patch 5 to use pm notifier to avoid firmware loading issues. - Dropped the reserved region requirement and allocate DMA memory instead. The reserved region binding patch is also removed. - Introduce two more TISCI LPM messages that are supported in SysFW. - Fixes in error handling. [1] https://lore.kernel.org/lkml/20220421203659.27853-1-d-gerlach@ti.com [2] https://www.ti.com/lit/pdf/spruiv7 [3] https://software-dl.ti.com/tisci/esd/latest/2_tisci_msgs/pm/lpm.html [4] https://lore.kernel.org/lkml/20220408124338.27090-1-a-govindraju@ti.com Georgi Vlaev (6): dt-bindings: ti, sci: Add lpm region and firmware-name firmware: ti_sci: Introduce Power Management Ops firmware: ti_sci: Add support for querying the firmware caps firmware: ti_sci: Allocate memory for the LPM modes firmware: ti_sci: Use dt provided fw name and address to load at suspend time firmware: ti_sci: Introduce prepare system suspend call .../bindings/arm/keystone/ti,sci.yaml | 21 +- drivers/firmware/ti_sci.c | 410 ++++++++++++++++++ drivers/firmware/ti_sci.h | 90 +++- include/linux/soc/ti/ti_sci_protocol.h | 44 ++ 4 files changed, 560 insertions(+), 5 deletions(-) base-commit: b7b275e60bcd5f89771e865a8239325f86d9927d