mbox series

[0/5] drm: Do not include <linux/fb.h> unnecessarily

Message ID 20230109101243.26995-1-tzimmermann@suse.de (mailing list archive)
Headers show
Series drm: Do not include <linux/fb.h> unnecessarily | expand

Message

Thomas Zimmermann Jan. 9, 2023, 10:12 a.m. UTC 
Remove unnecessary include statements for <linux/fb.h>. I recently
changed this header and had to rebuild a good part of DRM. So avoid
this by removing the dependency.

Some source files require the OF or backlight headers. Include those
instead.

Thomas Zimmermann (5):
  drm: Include <linux/backlight.h> where needed
  drm: Don't include linux/fb.h in drm_crtc_helper.h
  drm/amdgpu: Do not include <linux/fb.h>
  drm/panel: Do not include <linux/fb.h>
  drm: Include <linux/of.h> in drm_modes.c

 drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c                     | 2 +-
 drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c                      | 1 -
 drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c            | 1 +
 drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu7_hwmgr.c          | 1 -
 drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega10_hwmgr.c        | 1 -
 .../gpu/drm/amd/pm/powerplay/hwmgr/vega10_processpptables.c  | 1 -
 drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega12_hwmgr.c        | 1 -
 .../gpu/drm/amd/pm/powerplay/hwmgr/vega12_processpptables.c  | 1 -
 drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega20_hwmgr.c        | 1 -
 .../gpu/drm/amd/pm/powerplay/hwmgr/vega20_processpptables.c  | 1 -
 drivers/gpu/drm/amd/pm/powerplay/smumgr/ci_smumgr.c          | 1 -
 drivers/gpu/drm/drm_modes.c                                  | 5 +++--
 drivers/gpu/drm/gma500/backlight.c                           | 2 ++
 drivers/gpu/drm/panel/panel-ilitek-ili9881c.c                | 1 -
 drivers/gpu/drm/panel/panel-raspberrypi-touchscreen.c        | 1 -
 drivers/gpu/drm/panel/panel-ronbo-rb070d30.c                 | 2 +-
 drivers/gpu/drm/radeon/radeon_acpi.c                         | 2 +-
 include/drm/drm_crtc_helper.h                                | 2 --
 18 files changed, 9 insertions(+), 18 deletions(-)


base-commit: ac04152253dccfb02dcedfa0c57443122cf79314

Comments

Maxime Ripard Jan. 13, 2023, 10:36 a.m. UTC | #1 
On Mon, Jan 09, 2023 at 11:12:38AM +0100, Thomas Zimmermann wrote:
> Remove unnecessary include statements for <linux/fb.h>. I recently
> changed this header and had to rebuild a good part of DRM. So avoid
> this by removing the dependency.
> 
> Some source files require the OF or backlight headers. Include those
> instead.

For the series:
Acked-by: Maxime Ripard <maxime@cerno.tech>

Maxime
Thomas Zimmermann Jan. 13, 2023, 12:10 p.m. UTC | #2 
Am 13.01.23 um 11:36 schrieb Maxime Ripard:
> On Mon, Jan 09, 2023 at 11:12:38AM +0100, Thomas Zimmermann wrote:
>> Remove unnecessary include statements for <linux/fb.h>. I recently
>> changed this header and had to rebuild a good part of DRM. So avoid
>> this by removing the dependency.
>>
>> Some source files require the OF or backlight headers. Include those
>> instead.
> 
> For the series:
> Acked-by: Maxime Ripard <maxime@cerno.tech>

per irc discussion, acked for all of v2 as well

> 
> Maxime