From patchwork Wed Jan 18 11:58:06 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Umang Jain X-Patchwork-Id: 13106239 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 32B5FC32793 for ; Wed, 18 Jan 2023 11:59:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=IRpJY1R75DOWvI3e779zZunD/RgKZ7mruWnsfNVwT2E=; b=DKnT5ytiNodfYI YXR0EFc9Y5dO88r2yn6sA61aRZt7UVkD6MlFfw5vYf0zLacu/+Y8js/HQtqUzNsofIWNiDGB7+Jac 4wyUhm0uoyNEamFvMyvKC3KIEAleRtv0PYIyhnOa+rselCaqAC/DzS1U14sdcODjRXe/T50R4MyPO fUPi+T7JBHxbo/LrP0GYdMAtgEHUDm+wUP5WqKhDZBYkAfHx64YNoQgraIW0CykN6knXv0gwBYkLv /6EQy03p3NzUlY9xiZey/TMcJuFZLkiNJsaV6vcAMmKyaQD2BwKUqCy5ia1bnqjcL9xfLinRWBSeW ZFUC9vGdpc98uBrbwu2g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pI75K-000dPn-Q3; Wed, 18 Jan 2023 11:58:30 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pI75H-000dON-Hq; Wed, 18 Jan 2023 11:58:28 +0000 Received: from umang.jainideasonboard.com (unknown [103.86.18.190]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 408671643; Wed, 18 Jan 2023 12:58:15 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1674043099; bh=4ZkEehY0EKcMSSK/FWZM4yQ45U26CQ/uPHxtUY8/+Kw=; h=From:To:Cc:Subject:Date:From; b=mr0XK0dJNxcu3fFvP7C+BBGG9i618Wp2a6bHZ4j0KZhNxdYBGNuju4tgCE/dVaS5x vPradXpHtzLbV0a8YcUOCmv/JXCNWzYeUqGHYLkRfxp+CZoi9WUk3T7oNYeY+3lL// Zyx45aew3KRMeYAPPkqHCT1swWhfj2xxzQgXBMJw= From: Umang Jain To: linux-staging@lists.linux.dev, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Stefan Wahren , Greg Kroah-Hartman , Florian Fainelli , Adrien Thierry , Dan Carpenter , Dave Stevenson , Kieran Bingham , Laurent Pinchart , Umang Jain Subject: [RFC PATCH 0/4] Drop custom logging Date: Wed, 18 Jan 2023 17:28:06 +0530 Message-Id: <20230118115810.21979-1-umang.jain@ideasonboard.com> X-Mailer: git-send-email 2.39.0 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230118_035827_768362_CF9B192D X-CRM114-Status: UNSURE ( 7.53 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Drop custom logging from the vchiq interface. Mostly of them are replaced with dev_dbg and friends and/or pr_info and friends. The debugfs log levels (in 4/4) are mapped to kernel logs levels (coming from include/linux/kern_levels.h) Would like some thoughts on it as I am not sure (hence marking this is RFC) From drivers/staging/vc04_services/interface/TODO: """ * Cleanup logging mechanism The driver should probably be using the standard kernel logging mechanisms such as dev_info, dev_dbg, and friends. """ Umang Jain (4): staging: vc04_services: vchiq_core: Drop custom logging staging: vc04_services: vchiq_arm: Drop custom logging staging: vc04_services: Drop custom logging staging: vc04_services: Drop remnants of custom logging .../interface/vchiq_arm/vchiq_arm.c | 151 +++--- .../interface/vchiq_arm/vchiq_connected.c | 5 +- .../interface/vchiq_arm/vchiq_core.c | 479 ++++++++---------- .../interface/vchiq_arm/vchiq_core.h | 39 -- .../interface/vchiq_arm/vchiq_debugfs.c | 26 +- .../interface/vchiq_arm/vchiq_dev.c | 78 ++- 6 files changed, 329 insertions(+), 449 deletions(-)