| Message ID | 20230210151008.4587-1-mike.leach@linaro.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | Extend logging on TMC start / stop errors | expand |
On 10/02/2023 15:10, Mike Leach wrote: > Recent issues with trying to debug TMC timeouts and flush issues shows > a general lack of logging and context around the possible errors > > Patchset addresses that. > > Signed-off-by: Mike Leach <mike.leach@linaro.org> > > Mike Leach (3): > coresight: Update timeout functions to allow return of test register > value > coresight: tmc: Update error logging in tmc common functions > coresight: etf: etr: Update logging around flush_and_stop() errors > > drivers/hwtracing/coresight/coresight-core.c | 50 +++++++++++++++---- > .../hwtracing/coresight/coresight-tmc-core.c | 37 +++++++++++--- > .../hwtracing/coresight/coresight-tmc-etf.c | 12 +++-- > .../hwtracing/coresight/coresight-tmc-etr.c | 8 ++- > drivers/hwtracing/coresight/coresight-tmc.h | 2 +- > include/linux/coresight.h | 10 +++- > 6 files changed, 93 insertions(+), 26 deletions(-) > Looks good to me. Reviewed-by: James Clark <james.clark@arm.com> At some point I might go and add some TRACE_EVENT(coresight_...)s around things like enabling and disabling devices. It might help to see what led up to an error rather than just the error itself.
Recent issues with trying to debug TMC timeouts and flush issues shows a general lack of logging and context around the possible errors Patchset addresses that. Signed-off-by: Mike Leach <mike.leach@linaro.org> Mike Leach (3): coresight: Update timeout functions to allow return of test register value coresight: tmc: Update error logging in tmc common functions coresight: etf: etr: Update logging around flush_and_stop() errors drivers/hwtracing/coresight/coresight-core.c | 50 +++++++++++++++---- .../hwtracing/coresight/coresight-tmc-core.c | 37 +++++++++++--- .../hwtracing/coresight/coresight-tmc-etf.c | 12 +++-- .../hwtracing/coresight/coresight-tmc-etr.c | 8 ++- drivers/hwtracing/coresight/coresight-tmc.h | 2 +- include/linux/coresight.h | 10 +++- 6 files changed, 93 insertions(+), 26 deletions(-)