From patchwork Wed Mar 15 14:50:56 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Leo Yan X-Patchwork-Id: 13175979 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2A398C6FD1D for ; Wed, 15 Mar 2023 14:52:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=HpiYE07sjAHiaI0mpr5zz7GjrmJ9UoPs7KcSkC5gmBs=; b=Te6fH9hAX/wWju g/139jmkvWVB5PNi15FRWntpMwSklSCS1RFzHWHhc8wK24xm9BKIv9vjm5v+EtQnh5FlumfHKU35c 4P6TwD90NRU3VgkE6n227spi4Ew6v/fyr1/rWavolaOkBu69YrAkjcZmje/9xE7w/nL8n7k6jErPb AAe+aJvxp6av/byT5GLPLTTdm0t6TBHHnd3oYYmSCd8hKb0IQv6TZHvKnmU+p8EXIKZokRJwi469A tKfVVUYmaUDOtzGEsnIuupC48HO6uys6o146XgWjv2yDrk1eIl2L88kS8ErINdcYiLUvw5svqTOvC rNZ7mbYSYI9ICXrEAxyw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pcSTZ-00Df6f-1l; Wed, 15 Mar 2023 14:51:37 +0000 Received: from mail-pl1-x62b.google.com ([2607:f8b0:4864:20::62b]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pcSTW-00Df5G-0I for linux-arm-kernel@lists.infradead.org; Wed, 15 Mar 2023 14:51:35 +0000 Received: by mail-pl1-x62b.google.com with SMTP id c18so1711068ple.11 for ; Wed, 15 Mar 2023 07:51:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1678891890; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=Bu4kxPfj7aIJx2I6pw2/A71GwgwBL/cX002kwanRK0c=; b=tyNRqzSJPRKtY5LNcM6dZEmVfMM65dt3L9q2kkBYCu7OE8sI6uVYE1LAfnbA/pAM/Q wja1CAysLDHEslicv7D4P4qE5dMF3tg0nh7hmkw+/9Itks2fAIIJr6a9WyoPt/JM9fMB bV8J34pNnVfaRD3Y/DB9MhjvH84gvyahf/bCsNB1D35JyuGi0m5vrcM6bru5YBJimRaO 48JoZeFei6FBrcZ4W8muU8JbV0SaDaOBYlDJpf5YSBWlpdV6TXgvZNeu0OmoLMdUYoXM pcBpFvDM5MPdWndxuiELOpw7KqN3F4o78pbG9yCNTEHiL2spXBVipkI1BXfizjAMaq+R mX4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678891890; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Bu4kxPfj7aIJx2I6pw2/A71GwgwBL/cX002kwanRK0c=; b=lG15qU03lix70BqMrqivQTpE1EPHleUJLc5cvcR6IAao0ZoDuxDUJVE9hKIuVjl1bK fBA3EDaqEFmYDKNBjFPlPDLelee8XtAncd1Z5+8c/crxd1GFB0+ZWMs7NSXiSD2fNW5H ND1CU+oJ6ed+WZnTceljMiqBrohAyKMXGAjA3pzalTfdE4MM23lcWDzYM2s9txLp0NB1 UKgdVBYSQMioU1HW6mZogKkyDs5w0urA8bPNPT+hXCHzkEJOWQKMbxBvg9DhRP0D61WB hnE/69AfjxR32NKTHu3iJp1cQEprmOw3TL+yA7XQ/Ppef7ajyyWm6ZpNELMCKOG/vTgF S+9w== X-Gm-Message-State: AO0yUKXntp/RCW5s4j4emh6wyDBSYF9MyNR/igxjGekMrTc5DO4jIi1a +f3//omX3cjbkq2FIJSv9/0mBA== X-Google-Smtp-Source: AK7set8J8AEmLGC58l903GZXDnUrjgGzARKnedfsmeb3OmriJj+UQPTB0Yb6xgtAngvU93KxxBaJEA== X-Received: by 2002:a17:903:228d:b0:19a:9686:ea85 with SMTP id b13-20020a170903228d00b0019a9686ea85mr3543724plh.17.1678891890198; Wed, 15 Mar 2023 07:51:30 -0700 (PDT) Received: from leoy-huanghe.lan ([107.151.177.133]) by smtp.gmail.com with ESMTPSA id kh3-20020a170903064300b0019926c77577sm3781587plb.90.2023.03.15.07.51.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Mar 2023 07:51:29 -0700 (PDT) From: Leo Yan To: Arnaldo Carvalho de Melo , Jiri Olsa , Namhyung Kim , Ian Rogers , John Garry , James Clark , Adrian Hunter , Peter Zijlstra , Ingo Molnar , Mark Rutland , Alexander Shishkin , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: Leo Yan Subject: [PATCH v5 00/16] perf kvm: Support histograms and TUI mode Date: Wed, 15 Mar 2023 22:50:56 +0800 Message-Id: <20230315145112.186603-1-leo.yan@linaro.org> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230315_075134_152708_274931ED X-CRM114-Status: GOOD ( 15.41 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org This patch set is to enable histograms and (partially) TUI mode in perf kvm tool; patch set v1 [1] gives brief introduction for the change. We can use below commands for testing this series: In a terminal, you could launch a virtual machine with qemu command; in below case, I downloaded a Ubuntu (or Debian) iso file and used it as the file system image: $ qemu-system-x86_64 -M pc -enable-kvm -cpu host -m 4096 -hda ubuntu-22.04-desktop-amd64.iso Then in another terminal, I can use below command to capture KVM trace data and report the result: # cd linux/tools/perf # ./perf kvm stat record # ./perf kvm stat report => Output in TUI mode # ./perf kvm stat report --stdio => Output in stdio mode Changes from v4: * Fixed building failure in patch 04; compiled successfully for every patch to ensure bisection. Changes from v3: * Updated patch 04 to change comparison function return type from int to int64_t to avoid overflow; * Added a refactoring patch 05 "perf kvm: Use macro to replace variable 'decode_str_len'"; * Refined to use hists__add_entry_ops() and hist_entry__cmp() to compare hist entry and add new entries, to support comparison between hist entry, added a new patch 09; (Namhyung Kim) * Updated patch 10 for comparison event name; (Namhyung Kim) * Refined patch 11 to move init_stats() and hists__inc_nr_samples() into kvm_he_zalloc(); (Namhyung Kim) * Minor refactoring for sort_result() and kvm_hists__init() in patch 15. Changes from v2: * Found building failure with command 'make VF=1 DEBUG=1 NO_SLANG=1', fixed it in the patch 13. (James Clark) Changes from v1: * Updated the patch 13 'perf kvm: Add TUI mode for stat report' to avoid building failure if no support HAVE_SLANG_SUPPORT. [1] https://lore.kernel.org/lkml/20230226042053.1492409-1-leo.yan@linaro.org/ Leo Yan (16): perf kvm: Refactor overall statistics perf kvm: Add pointer to 'perf_kvm_stat' in kvm event perf kvm: Move up metrics helpers perf kvm: Use subtraction for comparison metrics perf kvm: Use macro to replace variable 'decode_str_len' perf kvm: Introduce histograms data structures perf kvm: Pass argument 'sample' to kvm_alloc_init_event() perf kvm: Parse address location for samples perf hist: Add 'kvm_info' field in histograms entry perf kvm: Add dimensions for KVM event statistics perf kvm: Use histograms list to replace cached list perf kvm: Polish sorting key perf kvm: Support printing attributions for dimensions perf kvm: Add dimensions for percentages perf kvm: Add TUI mode for stat report perf kvm: Update documentation to reflect new changes tools/perf/Documentation/perf-kvm.txt | 9 +- tools/perf/arch/arm64/util/kvm-stat.c | 1 - tools/perf/arch/powerpc/util/kvm-stat.c | 3 +- tools/perf/arch/s390/util/kvm-stat.c | 1 - tools/perf/arch/x86/util/kvm-stat.c | 7 +- tools/perf/builtin-annotate.c | 2 +- tools/perf/builtin-c2c.c | 4 +- tools/perf/builtin-diff.c | 4 +- tools/perf/builtin-kvm.c | 859 +++++++++++++++++++----- tools/perf/tests/hists_link.c | 4 +- tools/perf/util/hist.c | 19 +- tools/perf/util/hist.h | 3 + tools/perf/util/kvm-stat.h | 33 +- tools/perf/util/sort.h | 1 + 14 files changed, 745 insertions(+), 205 deletions(-)