From patchwork Tue Apr 11 16:59:15 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jim Quinlan X-Patchwork-Id: 13207908 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 78CFCC77B6F for ; Tue, 11 Apr 2023 17:00:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:List-Subscribe:List-Help: List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date:Subject:Cc:To :From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=H4NfKWWvOLfQa4098GEErteWGwh9riBhJK4S8fJ9ZBI=; b=VcCmUtgt3xvryt fD7j3k71x+PteCZGZ3HE9VYBBsD3ERytOd7q9TZxc9MvPWXS58XwU39RtwiCq0ay13XqjISyRGTPi oAPYVsmrD6kHuhAtwdkjDdLSDnSnE1/hgEiwcM9+sVB33zOeunTmxMzgu00ndYycvWz4DglENqAOY 9shhFJELJcJJpcmQYQcK1FHkLMliWP9OBK0kkG0Vn/env1VNw7Qb5Oe217wNwavyxftfonNoXr4Tv WxXepTrF4WavgpHHI5Zt1DWnuWA2ccECf7BCYPK4HG5AgHzWsX+8uPj7gk9icmjjVv+C7vyKGAfNA Ik+L74aTWnZx13hEfNTA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pmHL8-000dso-2a; Tue, 11 Apr 2023 16:59:30 +0000 Received: from mail-pj1-x1031.google.com ([2607:f8b0:4864:20::1031]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pmHL5-000drf-28; Tue, 11 Apr 2023 16:59:28 +0000 Received: by mail-pj1-x1031.google.com with SMTP id e18-20020a17090ac21200b00246952d917fso7120506pjt.4; Tue, 11 Apr 2023 09:59:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1681232364; x=1683824364; h=message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=+7qLDfiZbNO+Q2Yr81Hjhejq+oc1OaATNXiVCU+g8g4=; b=JS/RzfI7675sYkOuqnYKH1fRl0w7+oS00uH+1wDFmr1snSRx4XIKnKZMF9/SO/M2BC yTiSvUEiGJSJCFDq/sGr5PfowBK7VhwwJEOWftpZJP+0rifuAPVTeEWC0QprwlsbIgW9 1ic/h9dmyzG8VkOduyEf56ZrTnPzOJjpAHi4XqSNL6hPKESb679+zZNyspVSqTEW03B9 iXZclmHl6CzYW/Wo9Esju4AbwmXDP6aLR/o7NNYpnWIteOwV6CVaW5qtaqy65iG+zYaP WS9uwmwtRACjm0UdgVjGkd2Cl2YUQ3KerXN/slYKOLboWOD3x6emJ/e+DjaID3YtcDJ+ OA5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1681232364; x=1683824364; h=message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+7qLDfiZbNO+Q2Yr81Hjhejq+oc1OaATNXiVCU+g8g4=; b=Oyv2aBjCd6Yvv3cM3hg0JH0qwnKAsN3pV5dFWrSfPiydHFabsz1k9iHJdjJfOB+zGH Au5GtWolTTcQ6GOOd7P6CgBymb7g4xkRSnx90sbGUY9rxtjaj7qlI5ojXjxSlincoHZi CwoopLgsseCnWJiY6ye24UGXzu9MZCsIBHRcogaVA0frIONDeXh/6w/V0mBP/tJBfEJ6 2gCMYiIE1onVf/FofXCr6yN7gJmel6udXHek0ierw3m9F66wgyIfeA+9JVChxLt1gsgV Q6IeooVouiMz8pjUm7uBdzVTMeOlkcwkk35pbJ7AJXLeA38Y+66+6eISPTN8VLlGxkgW 49bQ== X-Gm-Message-State: AAQBX9cNrN60JoffUjZ+no0rX1jVD3Naq45cbmE6cnG7OPU9jjLjF6ER Mo4Hdu/87Z7o5ruuvDhgGCw= X-Google-Smtp-Source: AKy350Y3qpy1sqVEgMY+D7orFkH5D3UvFg7kbarVzV3LOMDgtwBx+RwlfKyAhGr3DiKmXYSvQUSHoA== X-Received: by 2002:a05:6a20:8b0a:b0:d9:4c19:fe69 with SMTP id l10-20020a056a208b0a00b000d94c19fe69mr16983016pzh.25.1681232364198; Tue, 11 Apr 2023 09:59:24 -0700 (PDT) Received: from stbsrv-and-01.and.broadcom.net ([192.19.144.250]) by smtp.gmail.com with ESMTPSA id m6-20020aa79006000000b0063989aab89fsm3484519pfo.23.2023.04.11.09.59.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Apr 2023 09:59:23 -0700 (PDT) From: Jim Quinlan To: linux-pci@vger.kernel.org, Nicolas Saenz Julienne , Bjorn Helgaas , Lorenzo Pieralisi , Cyril Brulebois , Phil Elwell , bcm-kernel-feedback-list@broadcom.com, jim2101024@gmail.com, james.quinlan@broadcom.com Cc: devicetree@vger.kernel.org (open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS), linux-arm-kernel@lists.infradead.org (moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE), linux-kernel@vger.kernel.org (open list), linux-rpi-kernel@lists.infradead.org (moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE), Rob Herring Subject: [PATCH v2 0/3] PCI: brcmstb: CLKREQ# accomodations of downstream device Date: Tue, 11 Apr 2023 12:59:15 -0400 Message-Id: <20230411165919.23955-1-jim2101024@gmail.com> X-Mailer: git-send-email 2.17.1 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230411_095927_714495_E00EC77A X-CRM114-Status: UNSURE ( 8.58 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org v2 -- Changed binding property 'brcm,completion-timeout-msec' to 'brcm,completion-timeout-us'. (StefanW for standard suffix). -- Warn when clamping timeout value, and include clamped region in message. Also add min and max in YAML. (StefanW) -- Qualify description of "brcm,completion-timeout-us" so that it refers to PCIe transactions. (StefanW) -- Remvove mention of Linux specifics in binding description. (StefanW) -- s/clkreq#/CLKREQ#/g (Bjorn) -- Refactor completion-timeout-us code to compare max and min to value given by the property (as opposed to the computed value). v1 -- The current driver assumes the downstream devices can provide CLKREQ# for ASPM. These commits accomodate devices w/ or w/o clkreq# and also handle L1SS-capable devices. -- The Raspian Linux folks have already been using a PCIe RC property "brcm,enable-l1ss". These commits use the same property, in a backward-compatible manner, and the implementaion adds more detail and also automatically identifies devices w/o a clkreq# signal, i.e. most devices plugged into an RPi CM4 IO board. Jim Quinlan (3): PCI: brcmstb: CLKREQ# accomodations of downstream device PCI: brcmstb: Set PCIe transaction completion timeout blah blah drivers/pci/controller/pcie-brcmstb.c | 99 ++++++++++++++++++++++++--- init/do_mounts.c | 16 ++++- 2 files changed, 102 insertions(+), 13 deletions(-) base-commit: 76f598ba7d8e2bfb4855b5298caedd5af0c374a8 prerequisite-patch-id: f38de8681d8746126d60b3430eaf218d2dd169cd prerequisite-patch-id: 23e13189f200358976abf5bf3600973a20cf386c prerequisite-patch-id: edfbe6ea39ed6a4937e2cec3bb8ee0e60091546d prerequisite-patch-id: c87dd155e8506a2a277726c47d85bf3fa83727d5 prerequisite-patch-id: 579841e1dc179517506a7a7c42e0e651b3bc3649 prerequisite-patch-id: b5b079998ea451821edffd7c52cd3d89d06046a1 prerequisite-patch-id: b51b3918e554e279b2ace1f68ed6b4176f8ccc24 prerequisite-patch-id: 333e5188fb27d0ed010f5359e83e539172a67690 prerequisite-patch-id: bb107ee7b4811a9719508ea667cad2466933dec0 prerequisite-patch-id: 1258db336e778eb57d5cbea88834cd25aa1346ba Tested-by: Florian Fainelli